From e33ef4429ef208f75469ec404c8d83dacc31839e Mon Sep 17 00:00:00 2001 From: Nikita Bykov Date: Wed, 26 Aug 2020 15:58:05 +0300 Subject: [PATCH] resolved comments --- .github/workflows/build-go-packages.yml | 8 ++------ tests/Go.Tests.ps1 | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build-go-packages.yml b/.github/workflows/build-go-packages.yml index 8f9b676..c5b6d3c 100644 --- a/.github/workflows/build-go-packages.yml +++ b/.github/workflows/build-go-packages.yml @@ -33,7 +33,6 @@ jobs: submodules: true - name: Build Go ${{ env.VERSION }} - shell: pwsh run: | ./builders/build-go.ps1 -Version $env:VERSION ` -Platform ${{ matrix.platform }} @@ -100,7 +99,6 @@ jobs: Write-Host "We need it because log of previous step 'Setup Go' is not available here yet." Write-Host "In testing step (Go.Tests.ps1) we analyze build log of 'Setup Go' task" Write-Host "to determine if Go.js version was consumed from cache and was downloaded" - Write-Host "Random values:" for ($i = 0; $i -lt 200; $i++) { Get-Random } - name: Run tests @@ -115,8 +113,6 @@ jobs: if: github.event.inputs.PUBLISH_RELEASES == 'true' needs: test_go runs-on: ubuntu-latest - outputs: - upload_url: ${{ steps.create_release.outputs.upload_url }} steps: - uses: actions/download-artifact@v2 @@ -129,7 +125,7 @@ jobs: tag_name: ${{ env.VERSION }}-${{ github.run_id }} release_name: ${{ env.VERSION }} body: | - Upload Go ${{ env.VERSION }} + Go ${{ env.VERSION }} - name: Upload release assets uses: actions/github-script@v2 @@ -155,7 +151,7 @@ jobs: runs-on: ubuntu-latest steps: - name: Trigger "Create Pull Request" workflow - uses: actions/github-script@v2 + uses: actions/github-script@v3 with: github-token: ${{ secrets.PERSONAL_TOKEN }} script: | diff --git a/tests/Go.Tests.ps1 b/tests/Go.Tests.ps1 index 598cc02..c9ac579 100644 --- a/tests/Go.Tests.ps1 +++ b/tests/Go.Tests.ps1 @@ -4,6 +4,7 @@ Import-Module (Join-Path $PSScriptRoot "../helpers/common-helpers.psm1") BeforeAll { Set-Location -Path "source" $sourceLocation = Get-Location + function Get-UseGoLogs { # GitHub Windows images don't have `HOME` variable $homeDir = $env:HOME ?? $env:HOMEDRIVE @@ -17,7 +18,6 @@ BeforeAll { } } - Describe "Go" { It "is available" { "go version" | Should -ReturnZeroExitCode