From 47f342ca958ba87a7719783bd5c855cebdd4aa65 Mon Sep 17 00:00:00 2001
From: EntifiedOptics <137791538+EntifiedOptics@users.noreply.github.com>
Date: Tue, 18 Mar 2025 21:01:49 +0000
Subject: [PATCH] Fix server not correctly removing clients (#588)

* Properly remove connection from clients list

* Changed misname in onCloseConnection

* Update server.js fix

---------

Co-authored-by: JSbETms <137791538+JSbETms@users.noreply.github.com>
Co-authored-by: extremeheat <extreme@protonmail.ch>
---
 src/server.js | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/server.js b/src/server.js
index 4dc9852..0f51bae 100644
--- a/src/server.js
+++ b/src/server.js
@@ -89,12 +89,10 @@ class Server extends EventEmitter {
     this.emit('connect', player)
   }
 
-  onCloseConnection = (inetAddr, reason) => {
-    this.conLog('Connection closed: ', inetAddr?.address, reason)
-
-    delete this.clients[inetAddr]?.connection // Prevent close loop
-    this.clients[inetAddr?.address ?? inetAddr]?.close()
-    delete this.clients[inetAddr]
+  onCloseConnection = (conn, reason) => {
+    this.conLog('Connection closed: ', conn.address, reason)
+    this.clients[conn.address]?.close()
+    delete this.clients[conn.address]
     this.clientCount--
   }