From 836d56d2dc5e41a59c522e187e3f829c7de9e899 Mon Sep 17 00:00:00 2001
From: LucienHH <lucienharryholloway@hotmail.co.uk>
Date: Sat, 16 Aug 2025 00:04:29 +0100
Subject: [PATCH] Cleanup unused methods

---
 src/server/advertisement.js | 18 +-----------------
 src/xsapi/rest.js           |  5 -----
 src/xsapi/session.js        |  4 ----
 3 files changed, 1 insertion(+), 26 deletions(-)

diff --git a/src/server/advertisement.js b/src/server/advertisement.js
index 2804620..b5f892c 100644
--- a/src/server/advertisement.js
+++ b/src/server/advertisement.js
@@ -19,42 +19,27 @@ class NethernetServerAdvertisement {
     const advertisement = new NethernetServerAdvertisement()
     let offset = 0
 
-    // Version (1 byte)
-    if (buffer.length < 1) return advertisement
     advertisement.version = buffer.readUInt8(offset++)
     
-    // MOTD (1 byte length + string)
-    if (offset >= buffer.length) return advertisement
     const motdLength = buffer.readUInt8(offset++)
-    if (offset + motdLength > buffer.length) return advertisement
     advertisement.motd = buffer.toString('utf8', offset, offset + motdLength)
     offset += motdLength
 
-    // Level name (1 byte length + string)
-    if (offset >= buffer.length) return advertisement
     const levelNameLength = buffer.readUInt8(offset++)
-    if (offset + levelNameLength > buffer.length) return advertisement
     advertisement.levelName = buffer.toString('utf8', offset, offset + levelNameLength)
     offset += levelNameLength
 
-    // Gamemode ID (4 bytes LE)
-    if (offset + 4 > buffer.length) return advertisement
     advertisement.gamemodeId = buffer.readInt32LE(offset)
     offset += 4
     
-    // Player count (4 bytes LE)
-    if (offset + 4 > buffer.length) return advertisement
     advertisement.playerCount = buffer.readInt32LE(offset)
     offset += 4
-    
-    // The remaining structure seems different from expected
-    // Let's just read what we can safely
+
     if (offset + 4 <= buffer.length) {
       advertisement.playersMax = buffer.readInt32LE(offset)
       offset += 4
     }
     
-    // Try to read remaining bytes as individual flags/values
     if (offset < buffer.length) {
       advertisement.isEditorWorld = buffer.readUInt8(offset++) === 1
     }
@@ -63,7 +48,6 @@ class NethernetServerAdvertisement {
       advertisement.hardcore = buffer.readUInt8(offset++) === 1
     }
     
-    // The last few bytes might be a different format
     if (offset < buffer.length) {
       advertisement.transportLayer = buffer.readUInt8(offset++)
     }
diff --git a/src/xsapi/rest.js b/src/xsapi/rest.js
index 8dec827..3283757 100644
--- a/src/xsapi/rest.js
+++ b/src/xsapi/rest.js
@@ -152,11 +152,6 @@ class Rest {
     return response
   }
 
-  async updateMemberCount (sessionName, count, maxCount) {
-    const payload = maxCount ? { MemberCount: count, MaxMemberCount: maxCount } : { MemberCount: count }
-    await this.updateSession(sessionName, { properties: { custom: payload } })
-  }
-
   async addConnection (sessionName, xuid, connectionId, subscriptionId) {
     const payload = {
       members: {
diff --git a/src/xsapi/session.js b/src/xsapi/session.js
index 98ca5e3..848bdde 100644
--- a/src/xsapi/session.js
+++ b/src/xsapi/session.js
@@ -127,10 +127,6 @@ class SessionDirectory {
     debug(`Invited player, xuid: ${identifier}`)
   }
 
-  async updateMemberCount (count, maxCount) {
-    await this.host.rest.updateMemberCount(this.session.name, count, maxCount)
-  }
-
   async getSession () {
     return await this.host.rest.getSession(this.session.name)
   }