From b35b88236d3a635ab76423dd0a1e20f4c6ffa547 Mon Sep 17 00:00:00 2001 From: Vitaly Turovsky Date: Mon, 7 Apr 2025 16:20:06 +0300 Subject: [PATCH 1/2] use whitelist to active touch cancel hack to avoid issues with side integrations --- src/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/index.ts b/src/index.ts index f51311ae..42346606 100644 --- a/src/index.ts +++ b/src/index.ts @@ -850,8 +850,8 @@ document.body.addEventListener('touchend', (e) => { activeTouch = undefined }) document.body.addEventListener('touchstart', (e) => { - const ignoreElem = (e.target as HTMLElement).matches('vercel-live-feedback') || (e.target as HTMLElement).closest('.hotbar') - if (!isGameActive(true) || ignoreElem) return + const targetElement = (e.target as HTMLElement).closest('#ui-root') + if (!isGameActive(true) || !targetElement) return // we always prevent default behavior to disable magnifier on ios, but by doing so we also disable click events e.preventDefault() let firstClickable // todo remove composedPath and this workaround when lit-element is fully dropped From 4dce591f8bd0f6f3084885104f65ec9b02407ccf Mon Sep 17 00:00:00 2001 From: Vitaly Turovsky Date: Mon, 7 Apr 2025 16:45:48 +0300 Subject: [PATCH 2/2] fix if for benchmark --- .github/workflows/benchmark.yml | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 1bee9e5c..2b2deb1b 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -8,11 +8,13 @@ on: jobs: deploy: runs-on: ubuntu-latest - # if: >- - # github.event.issue.pull_request != '' && - # ( - # contains(github.event.comment.body, '/benchmark') - # ) + if: >- + (github.event_name == 'push' && github.ref == 'refs/heads/perf-test') || + ( + github.event_name == 'issue_comment' && + github.event.issue.pull_request != '' && + contains(github.event.comment.body, '/benchmark') + ) permissions: pull-requests: write steps: