From c4097975bf8ea14764bf7f2b70aa00e45dc5b399 Mon Sep 17 00:00:00 2001
From: Vitaly Turovsky <vital2580@icloud.com>
Date: Mon, 8 Sep 2025 05:29:34 +0300
Subject: [PATCH] add a way to disable sky box for old behavior (not tested)

---
 renderer/viewer/lib/worldrendererCommon.ts  |  1 +
 renderer/viewer/three/skyboxRenderer.ts     | 25 ++++++++++++++++++++-
 renderer/viewer/three/worldrendererThree.ts |  5 ++++-
 src/defaultOptions.ts                       |  1 +
 src/watchOptions.ts                         |  4 ++++
 5 files changed, 34 insertions(+), 2 deletions(-)

diff --git a/renderer/viewer/lib/worldrendererCommon.ts b/renderer/viewer/lib/worldrendererCommon.ts
index e2455915..4140e3fa 100644
--- a/renderer/viewer/lib/worldrendererCommon.ts
+++ b/renderer/viewer/lib/worldrendererCommon.ts
@@ -47,6 +47,7 @@ export const defaultWorldRendererConfig = {
   smoothLighting: true,
   enableLighting: true,
   starfield: true,
+  defaultSkybox: true,
   renderEntities: true,
   extraBlockRenderers: true,
   foreground: true,
diff --git a/renderer/viewer/three/skyboxRenderer.ts b/renderer/viewer/three/skyboxRenderer.ts
index aa8c3bb6..cd7bd879 100644
--- a/renderer/viewer/three/skyboxRenderer.ts
+++ b/renderer/viewer/three/skyboxRenderer.ts
@@ -18,7 +18,7 @@ export class SkyboxRenderer {
   private fogBrightness = 0
   private prevFogBrightness = 0
 
-  constructor (private readonly scene: THREE.Scene, public initialImage: string | null) {
+  constructor (private readonly scene: THREE.Scene, public defaultSkybox: boolean, public initialImage: string | null) {
     if (!initialImage) {
       this.createGradientSky()
     }
@@ -119,6 +119,12 @@ export class SkyboxRenderer {
     this.updateSkyColors()
   }
 
+  // Update default skybox setting
+  updateDefaultSkybox (defaultSkybox: boolean) {
+    this.defaultSkybox = defaultSkybox
+    this.updateSkyColors()
+  }
+
   private createGradientSky () {
     const size = 64
     const scale = 256 / size + 2
@@ -279,6 +285,23 @@ export class SkyboxRenderer {
   private updateSkyColors () {
     if (!this.skyMesh || !this.voidMesh) return
 
+    // If default skybox is disabled, hide the skybox meshes
+    if (!this.defaultSkybox) {
+      this.skyMesh.visible = false
+      this.voidMesh.visible = false
+      if (this.mesh) {
+        this.mesh.visible = false
+      }
+      return
+    }
+
+    // Show skybox meshes when default skybox is enabled
+    this.skyMesh.visible = true
+    this.voidMesh.visible = true
+    if (this.mesh) {
+      this.mesh.visible = true
+    }
+
     // Update fog brightness with smooth transition
     this.prevFogBrightness = this.fogBrightness
     const renderDistance = this.viewDistance / 32
diff --git a/renderer/viewer/three/worldrendererThree.ts b/renderer/viewer/three/worldrendererThree.ts
index 29e9223c..1b4e6152 100644
--- a/renderer/viewer/three/worldrendererThree.ts
+++ b/renderer/viewer/three/worldrendererThree.ts
@@ -98,7 +98,7 @@ export class WorldRendererThree extends WorldRendererCommon {
     this.holdingBlockLeft = new HoldingBlock(this, true)
 
     // Initialize skybox renderer
-    this.skyboxRenderer = new SkyboxRenderer(this.scene, null)
+    this.skyboxRenderer = new SkyboxRenderer(this.scene, this.worldRendererConfig.defaultSkybox, null)
     void this.skyboxRenderer.init()
 
     this.addDebugOverlay()
@@ -206,6 +206,9 @@ export class WorldRendererThree extends WorldRendererCommon {
     this.onReactiveConfigUpdated('showChunkBorders', (value) => {
       this.updateShowChunksBorder(value)
     })
+    this.onReactiveConfigUpdated('defaultSkybox', (value) => {
+      this.skyboxRenderer.updateDefaultSkybox(value)
+    })
   }
 
   changeHandSwingingState (isAnimationPlaying: boolean, isLeft = false) {
diff --git a/src/defaultOptions.ts b/src/defaultOptions.ts
index 6045e70b..361879be 100644
--- a/src/defaultOptions.ts
+++ b/src/defaultOptions.ts
@@ -41,6 +41,7 @@ export const defaultOptions = {
   renderEars: true,
   lowMemoryMode: false,
   starfieldRendering: true,
+  defaultSkybox: true,
   enabledResourcepack: null as string | null,
   useVersionsTextures: 'latest',
   serverResourcePacks: 'prompt' as 'prompt' | 'always' | 'never',
diff --git a/src/watchOptions.ts b/src/watchOptions.ts
index da75cc74..779aa29f 100644
--- a/src/watchOptions.ts
+++ b/src/watchOptions.ts
@@ -116,6 +116,10 @@ export const watchOptionsAfterViewerInit = () => {
     appViewer.inWorldRenderingConfig.starfield = o.starfieldRendering
   })
 
+  watchValue(options, o => {
+    appViewer.inWorldRenderingConfig.defaultSkybox = o.defaultSkybox
+  })
+
   watchValue(options, o => {
     // appViewer.inWorldRenderingConfig.neighborChunkUpdates = o.neighborChunkUpdates
   })