From f577c68755e0f1ea983d23480150852565b94ede Mon Sep 17 00:00:00 2001 From: Gabriel Poma Date: Tue, 24 Jun 2025 11:03:07 +0200 Subject: [PATCH] flatten: return true early when rect found We don't need to iterate on all objects if one rect is found --- public/js/signature.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/public/js/signature.js b/public/js/signature.js index 9c9e371..63464bf 100644 --- a/public/js/signature.js +++ b/public/js/signature.js @@ -476,13 +476,13 @@ function addObjectInCanvas(canvas, item) { function updateFlatten() { let flatten = Boolean(document.querySelector('input[name=watermark]').value); - canvasEditions.forEach(function(canvasEdition, index) { - canvasEdition.getObjects().forEach(function(object) { - if(object.type == "rect") { - flatten = true; - } - }); + + flatten = flatten || canvasEditions.some(function (canvas) { + return canvas.getObjects().some(function (object) { + return object.type === "rect" + }) }) + document.querySelector('input[name=flatten]').checked = flatten; if(document.getElementById('save_flatten_indicator')) { document.getElementById('save_flatten_indicator').classList.toggle('invisible', !flatten);