Merge pull request #197 from JayKid/fix/extra-parameter-in-add-item

Fix extra parameter in call to _addItem

README.md

@@ -768,7 +768,7 @@ example.setValueByChoice('Two'); // Choice with value of 'Two' has now been sele
 ### disable();
 **Input types affected:** `text`, `select-one`, `select-multiple`
 
-**Usage:** Disables input from accepting new value/sselecting further choices.
+**Usage:** Disables input from accepting new value/selecting further choices.
 
 ### enable();
 **Input types affected:** `text`, `select-one`, `select-multiple`

assets/scripts/src/choices.js

@@ -2205,7 +2205,6 @@ class Choices {
         choiceLabel,
         choiceId,
         undefined,
-        undefined,
         customProperties
       );
     }
@@ -2254,7 +2253,8 @@ class Choices {
           label,
           option.selected,
           isOptDisabled,
-          groupId
+          groupId,
+          option.customProperties
         );
       });
     } else {

tests/spec/choices_spec.js

@@ -1038,5 +1038,23 @@ describe('Choices', () => {
       expect(selectedItems.length).toBe(1);
       expect(selectedItems[0].customProperties).toBe(expectedCustomProperties);
     });
+
+    it('should allow the user to supply custom properties when directly creating a selected item', function() {
+      const expectedCustomProperties = {
+        isBestOptionEver: true
+      };
+
+      this.choices = new Choices(this.input);
+
+      this.choices.setValue([{
+          value: 'bar',
+          label: 'foo',
+          customProperties: expectedCustomProperties
+      }]);
+      const selectedItems = this.choices.getValue();
+
+      expect(selectedItems.length).toBe(1);
+      expect(selectedItems[0].customProperties).toBe(expectedCustomProperties);
+    });
   });
 });