From 61204b917320695168d2c6e345a9d77f4a798017 Mon Sep 17 00:00:00 2001
From: Josh Johnson <josh@joshuajohnson.co.uk>
Date: Sat, 24 Nov 2018 17:48:03 +0000
Subject: [PATCH] Fix form submission bug in firefox (#470)

* Fix form submission bug in firefox

* 4.1.1
---
 test/select-multiple.html | 11 +++++++++++
 test/select-one.html      | 11 +++++++++++
 test/text.html            |  9 +++++++++
 3 files changed, 31 insertions(+)

diff --git a/test/select-multiple.html b/test/select-multiple.html
index eb24cac5..54e0561c 100644
--- a/test/select-multiple.html
+++ b/test/select-multiple.html
@@ -176,6 +176,15 @@
           <label for="choices-custom-properties">Custom properties</label>
           <select class="form-control" name="choices-custom-properties" id="choices-custom-properties" multiple></select>
         </div>
+
+        <div data-test-hook="within-form">
+          <form>
+            <label for="choices-within-form">Within form</label>
+            <select class="form-control" name="choices-within-form" id="choices-within-form" multiple>
+              <option value="Choice 1">Choice 1</option>
+            </select>
+          </form>
+        </div>
       </div>
     </div>
     <script>
@@ -285,6 +294,8 @@
             }
           ]
         });
+
+        new Choices('#choices-within-form');
       });
     </script>
   </body>
diff --git a/test/select-one.html b/test/select-one.html
index 89a9359a..5772c265 100644
--- a/test/select-one.html
+++ b/test/select-one.html
@@ -180,6 +180,15 @@
           <label for="choices-custom-properties">Custom properties</label>
           <select class="form-control" name="choices-custom-properties" id="choices-custom-properties"></select>
         </div>
+
+        <div data-test-hook="within-form">
+          <form>
+            <label for="choices-within-form">Within form</label>
+            <select class="form-control" name="choices-within-form" id="choices-within-form">
+              <option value="Choice 1">Choice 1</option>
+            </select>
+          </form>
+        </div>
       </div>
     </div>
     <script>
@@ -297,6 +306,8 @@
             }
           ]
         });
+
+        new Choices('#choices-within-form');
       });
     </script>
   </body>
diff --git a/test/text.html b/test/text.html
index 0576325c..cc5d6486 100644
--- a/test/text.html
+++ b/test/text.html
@@ -83,6 +83,13 @@
           <label for="choices-placeholder">Placeholder</label>
           <input class="form-control" id="choices-placeholder" type="text">
         </div>
+
+        <div data-test-hook="within-form">
+          <form>
+            <label for="choices-within-form">Within form</label>
+            <input class="form-control" id="choices-within-form" type="text">
+          </form>
+        </div>
       </div>
     </div>
     <script>
@@ -134,6 +141,8 @@
           placeholder: true,
           placeholderValue: 'I am a placeholder',
         });
+
+        new Choices('#choices-within-form');
       });
     </script>
   </body>