diff --git a/cypress/integration/select-one.spec.js b/cypress/integration/select-one.spec.js index 3d2c35d..3b3b0b0 100644 --- a/cypress/integration/select-one.spec.js +++ b/cypress/integration/select-one.spec.js @@ -5,13 +5,6 @@ describe('Choices - select one', () => { describe('scenarios', () => { describe('basic', () => { - beforeEach(() => { - // open dropdown - cy.get('[data-test-hook=basic]') - .find('.choices') - .click(); - }); - describe('focusing on container', () => { describe('pressing enter key', () => { it('toggles the dropdown', () => { @@ -22,7 +15,7 @@ describe('Choices - select one', () => { cy.get('[data-test-hook=basic]') .find('.choices__list--dropdown') - .should('not.be.visible'); + .should('be.visible'); cy.get('[data-test-hook=basic]') .find('.choices') @@ -31,42 +24,38 @@ describe('Choices - select one', () => { cy.get('[data-test-hook=basic]') .find('.choices__list--dropdown') - .should('be.visible'); + .should('not.be.visible'); }); }); - }); - describe('focusing on text input', () => { - it('displays a dropdown of choices', () => { - cy.get('[data-test-hook=basic]') - .find('.choices__list--dropdown') - .should('be.visible'); + describe('pressing an alpha-numeric key', () => { + it('opens the dropdown and the input value', () => { + const inputValue = 'test'; - cy.get('[data-test-hook=basic]') - .find('.choices__list--dropdown .choices__list') - .children() - .should('have.length', 4) - .each(($choice, index) => { - expect($choice.text().trim()).to.equal(`Choice ${index + 1}`); - }); - }); - - describe('pressing escape', () => { - beforeEach(() => { cy.get('[data-test-hook=basic]') - .find('.choices__input--cloned') - .type('{esc}'); - }); + .find('.choices') + .focus() + .type(inputValue); - it('closes the dropdown', () => { cy.get('[data-test-hook=basic]') .find('.choices__list--dropdown') - .should('not.be.visible'); + .should('be.visible'); + + cy.get('[data-test-hook=basic]') + .find('.choices__input--cloned') + .should('have.value', inputValue); }); }); }); describe('selecting choices', () => { + beforeEach(() => { + // open dropdown + cy.get('[data-test-hook=basic]') + .find('.choices') + .click(); + }); + const selectedChoiceText = 'Choice 1'; it('allows selecting choices from dropdown', () => { @@ -102,6 +91,13 @@ describe('Choices - select one', () => { }); describe('searching choices', () => { + beforeEach(() => { + // open dropdown + cy.get('[data-test-hook=basic]') + .find('.choices') + .click(); + }); + describe('on input', () => { describe('searching by label', () => { it('displays choices filtered by inputted value', () => { diff --git a/public/assets/styles/choices.css b/public/assets/styles/choices.css index 4dff1dc..29c488b 100644 --- a/public/assets/styles/choices.css +++ b/public/assets/styles/choices.css @@ -61,7 +61,7 @@ height: 20px; width: 20px; border-radius: 10em; - opacity: 0.5; + opacity: 0.25; } .choices[data-type*='select-one'] .choices__button:hover, .choices[data-type*='select-one'] .choices__button:focus { diff --git a/public/assets/styles/choices.min.css b/public/assets/styles/choices.min.css index 19adaba..3b7c255 100644 --- a/public/assets/styles/choices.min.css +++ b/public/assets/styles/choices.min.css @@ -1 +1 @@ -.choices{position:relative;margin-bottom:24px;font-size:16px}.choices:focus{outline:0}.choices:last-child{margin-bottom:0}.choices.is-disabled .choices__inner,.choices.is-disabled .choices__input{background-color:#eaeaea;cursor:not-allowed;-webkit-user-select:none;-ms-user-select:none;user-select:none}.choices.is-disabled .choices__item{cursor:not-allowed}.choices [hidden]{display:none!important}.choices[data-type*=select-one]{cursor:pointer}.choices[data-type*=select-one] .choices__inner{padding-bottom:7.5px}.choices[data-type*=select-one] .choices__input{display:block;width:100%;padding:10px;border-bottom:1px solid #ddd;background-color:#fff;margin:0}.choices[data-type*=select-one] .choices__button{background-image:url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMjEiIGhlaWdodD0iMjEiIHZpZXdCb3g9IjAgMCAyMSAyMSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj48ZyBmaWxsPSIjMDAwIiBmaWxsLXJ1bGU9ImV2ZW5vZGQiPjxwYXRoIGQ9Ik0yLjU5Mi4wNDRsMTguMzY0IDE4LjM2NC0yLjU0OCAyLjU0OEwuMDQ0IDIuNTkyeiIvPjxwYXRoIGQ9Ik0wIDE4LjM2NEwxOC4zNjQgMGwyLjU0OCAyLjU0OEwyLjU0OCAyMC45MTJ6Ii8+PC9nPjwvc3ZnPg==);padding:0;background-size:8px;position:absolute;top:50%;right:0;margin-top:-10px;margin-right:25px;height:20px;width:20px;border-radius:10em;opacity:.5}.choices[data-type*=select-one] .choices__button:focus,.choices[data-type*=select-one] .choices__button:hover{opacity:1}.choices[data-type*=select-one] .choices__button:focus{box-shadow:0 0 0 2px #00bcd4}.choices[data-type*=select-one] .choices__item[data-value=''] .choices__button{display:none}.choices[data-type*=select-one]:after{content:'';height:0;width:0;border-style:solid;border-color:#333 transparent transparent;border-width:5px;position:absolute;right:11.5px;top:50%;margin-top:-2.5px;pointer-events:none}.choices[data-type*=select-one].is-open:after{border-color:transparent transparent #333;margin-top:-7.5px}.choices[data-type*=select-one][dir=rtl]:after{left:11.5px;right:auto}.choices[data-type*=select-one][dir=rtl] .choices__button{right:auto;left:0;margin-left:25px;margin-right:0}.choices[data-type*=select-multiple] .choices__inner,.choices[data-type*=text] .choices__inner{cursor:text}.choices[data-type*=select-multiple] .choices__button,.choices[data-type*=text] .choices__button{position:relative;display:inline-block;margin:0 -4px 0 8px;padding-left:16px;border-left:1px solid #008fa1;background-image:url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMjEiIGhlaWdodD0iMjEiIHZpZXdCb3g9IjAgMCAyMSAyMSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj48ZyBmaWxsPSIjRkZGIiBmaWxsLXJ1bGU9ImV2ZW5vZGQiPjxwYXRoIGQ9Ik0yLjU5Mi4wNDRsMTguMzY0IDE4LjM2NC0yLjU0OCAyLjU0OEwuMDQ0IDIuNTkyeiIvPjxwYXRoIGQ9Ik0wIDE4LjM2NEwxOC4zNjQgMGwyLjU0OCAyLjU0OEwyLjU0OCAyMC45MTJ6Ii8+PC9nPjwvc3ZnPg==);background-size:8px;width:8px;line-height:1;opacity:.75;border-radius:0}.choices[data-type*=select-multiple] .choices__button:focus,.choices[data-type*=select-multiple] .choices__button:hover,.choices[data-type*=text] .choices__button:focus,.choices[data-type*=text] .choices__button:hover{opacity:1}.choices__inner{display:inline-block;vertical-align:top;width:100%;background-color:#f9f9f9;padding:7.5px 7.5px 3.75px;border:1px solid #ddd;border-radius:2.5px;font-size:14px;min-height:44px;overflow:hidden}.is-focused .choices__inner,.is-open .choices__inner{border-color:#b7b7b7}.is-open .choices__inner{border-radius:2.5px 2.5px 0 0}.is-flipped.is-open .choices__inner{border-radius:0 0 2.5px 2.5px}.choices__list{margin:0;padding-left:0;list-style:none}.choices__list--single{display:inline-block;padding:4px 16px 4px 4px;width:100%}[dir=rtl] .choices__list--single{padding-right:4px;padding-left:16px}.choices__list--single .choices__item{width:100%}.choices__list--multiple{display:inline}.choices__list--multiple .choices__item{display:inline-block;vertical-align:middle;border-radius:20px;padding:4px 10px;font-size:12px;font-weight:500;margin-right:3.75px;margin-bottom:3.75px;background-color:#00bcd4;border:1px solid #00a5bb;color:#fff;word-break:break-all;box-sizing:border-box}.choices__list--multiple .choices__item[data-deletable]{padding-right:5px}[dir=rtl] .choices__list--multiple .choices__item{margin-right:0;margin-left:3.75px}.choices__list--multiple .choices__item.is-highlighted{background-color:#00a5bb;border:1px solid #008fa1}.is-disabled .choices__list--multiple .choices__item{background-color:#aaa;border:1px solid #919191}.choices__list--dropdown{visibility:hidden;z-index:1;position:absolute;width:100%;background-color:#fff;border:1px solid #ddd;top:100%;margin-top:-1px;border-bottom-left-radius:2.5px;border-bottom-right-radius:2.5px;overflow:hidden;word-break:break-all;will-change:visibility}.choices__list--dropdown.is-active{visibility:visible}.is-open .choices__list--dropdown{border-color:#b7b7b7}.is-flipped .choices__list--dropdown{top:auto;bottom:100%;margin-top:0;margin-bottom:-1px;border-radius:.25rem .25rem 0 0}.choices__list--dropdown .choices__list{position:relative;max-height:300px;overflow:auto;-webkit-overflow-scrolling:touch;will-change:scroll-position}.choices__list--dropdown .choices__item{position:relative;padding:10px;font-size:14px}[dir=rtl] .choices__list--dropdown .choices__item{text-align:right}@media (min-width:640px){.choices__list--dropdown .choices__item--selectable{padding-right:100px}.choices__list--dropdown .choices__item--selectable:after{content:attr(data-select-text);font-size:12px;opacity:0;position:absolute;right:10px;top:50%;transform:translateY(-50%)}[dir=rtl] .choices__list--dropdown .choices__item--selectable{text-align:right;padding-left:100px;padding-right:10px}[dir=rtl] .choices__list--dropdown .choices__item--selectable:after{right:auto;left:10px}}.choices__list--dropdown .choices__item--selectable.is-highlighted{background-color:#f2f2f2}.choices__list--dropdown .choices__item--selectable.is-highlighted:after{opacity:.5}.choices__item{cursor:default}.choices__item--selectable{cursor:pointer}.choices__item--disabled{cursor:not-allowed;-webkit-user-select:none;-ms-user-select:none;user-select:none;opacity:.5}.choices__heading{font-weight:600;font-size:12px;padding:10px;border-bottom:1px solid #f7f7f7;color:gray}.choices__button{text-indent:-9999px;-webkit-appearance:none;-moz-appearance:none;appearance:none;border:0;background-color:transparent;background-repeat:no-repeat;background-position:center;cursor:pointer}.choices__button:focus,.choices__input:focus{outline:0}.choices__input{display:inline-block;vertical-align:baseline;background-color:#f9f9f9;font-size:14px;margin-bottom:5px;border:0;border-radius:0;max-width:100%;padding:4px 0 4px 2px}[dir=rtl] .choices__input{padding-right:2px;padding-left:0}.choices__placeholder{opacity:.5} \ No newline at end of file +.choices{position:relative;margin-bottom:24px;font-size:16px}.choices:focus{outline:0}.choices:last-child{margin-bottom:0}.choices.is-disabled .choices__inner,.choices.is-disabled .choices__input{background-color:#eaeaea;cursor:not-allowed;-webkit-user-select:none;-ms-user-select:none;user-select:none}.choices.is-disabled .choices__item{cursor:not-allowed}.choices [hidden]{display:none!important}.choices[data-type*=select-one]{cursor:pointer}.choices[data-type*=select-one] .choices__inner{padding-bottom:7.5px}.choices[data-type*=select-one] .choices__input{display:block;width:100%;padding:10px;border-bottom:1px solid #ddd;background-color:#fff;margin:0}.choices[data-type*=select-one] .choices__button{background-image:url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMjEiIGhlaWdodD0iMjEiIHZpZXdCb3g9IjAgMCAyMSAyMSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj48ZyBmaWxsPSIjMDAwIiBmaWxsLXJ1bGU9ImV2ZW5vZGQiPjxwYXRoIGQ9Ik0yLjU5Mi4wNDRsMTguMzY0IDE4LjM2NC0yLjU0OCAyLjU0OEwuMDQ0IDIuNTkyeiIvPjxwYXRoIGQ9Ik0wIDE4LjM2NEwxOC4zNjQgMGwyLjU0OCAyLjU0OEwyLjU0OCAyMC45MTJ6Ii8+PC9nPjwvc3ZnPg==);padding:0;background-size:8px;position:absolute;top:50%;right:0;margin-top:-10px;margin-right:25px;height:20px;width:20px;border-radius:10em;opacity:.25}.choices[data-type*=select-one] .choices__button:focus,.choices[data-type*=select-one] .choices__button:hover{opacity:1}.choices[data-type*=select-one] .choices__button:focus{box-shadow:0 0 0 2px #00bcd4}.choices[data-type*=select-one] .choices__item[data-value=''] .choices__button{display:none}.choices[data-type*=select-one]:after{content:'';height:0;width:0;border-style:solid;border-color:#333 transparent transparent;border-width:5px;position:absolute;right:11.5px;top:50%;margin-top:-2.5px;pointer-events:none}.choices[data-type*=select-one].is-open:after{border-color:transparent transparent #333;margin-top:-7.5px}.choices[data-type*=select-one][dir=rtl]:after{left:11.5px;right:auto}.choices[data-type*=select-one][dir=rtl] .choices__button{right:auto;left:0;margin-left:25px;margin-right:0}.choices[data-type*=select-multiple] .choices__inner,.choices[data-type*=text] .choices__inner{cursor:text}.choices[data-type*=select-multiple] .choices__button,.choices[data-type*=text] .choices__button{position:relative;display:inline-block;margin:0 -4px 0 8px;padding-left:16px;border-left:1px solid #008fa1;background-image:url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMjEiIGhlaWdodD0iMjEiIHZpZXdCb3g9IjAgMCAyMSAyMSIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj48ZyBmaWxsPSIjRkZGIiBmaWxsLXJ1bGU9ImV2ZW5vZGQiPjxwYXRoIGQ9Ik0yLjU5Mi4wNDRsMTguMzY0IDE4LjM2NC0yLjU0OCAyLjU0OEwuMDQ0IDIuNTkyeiIvPjxwYXRoIGQ9Ik0wIDE4LjM2NEwxOC4zNjQgMGwyLjU0OCAyLjU0OEwyLjU0OCAyMC45MTJ6Ii8+PC9nPjwvc3ZnPg==);background-size:8px;width:8px;line-height:1;opacity:.75;border-radius:0}.choices[data-type*=select-multiple] .choices__button:focus,.choices[data-type*=select-multiple] .choices__button:hover,.choices[data-type*=text] .choices__button:focus,.choices[data-type*=text] .choices__button:hover{opacity:1}.choices__inner{display:inline-block;vertical-align:top;width:100%;background-color:#f9f9f9;padding:7.5px 7.5px 3.75px;border:1px solid #ddd;border-radius:2.5px;font-size:14px;min-height:44px;overflow:hidden}.is-focused .choices__inner,.is-open .choices__inner{border-color:#b7b7b7}.is-open .choices__inner{border-radius:2.5px 2.5px 0 0}.is-flipped.is-open .choices__inner{border-radius:0 0 2.5px 2.5px}.choices__list{margin:0;padding-left:0;list-style:none}.choices__list--single{display:inline-block;padding:4px 16px 4px 4px;width:100%}[dir=rtl] .choices__list--single{padding-right:4px;padding-left:16px}.choices__list--single .choices__item{width:100%}.choices__list--multiple{display:inline}.choices__list--multiple .choices__item{display:inline-block;vertical-align:middle;border-radius:20px;padding:4px 10px;font-size:12px;font-weight:500;margin-right:3.75px;margin-bottom:3.75px;background-color:#00bcd4;border:1px solid #00a5bb;color:#fff;word-break:break-all;box-sizing:border-box}.choices__list--multiple .choices__item[data-deletable]{padding-right:5px}[dir=rtl] .choices__list--multiple .choices__item{margin-right:0;margin-left:3.75px}.choices__list--multiple .choices__item.is-highlighted{background-color:#00a5bb;border:1px solid #008fa1}.is-disabled .choices__list--multiple .choices__item{background-color:#aaa;border:1px solid #919191}.choices__list--dropdown{visibility:hidden;z-index:1;position:absolute;width:100%;background-color:#fff;border:1px solid #ddd;top:100%;margin-top:-1px;border-bottom-left-radius:2.5px;border-bottom-right-radius:2.5px;overflow:hidden;word-break:break-all;will-change:visibility}.choices__list--dropdown.is-active{visibility:visible}.is-open .choices__list--dropdown{border-color:#b7b7b7}.is-flipped .choices__list--dropdown{top:auto;bottom:100%;margin-top:0;margin-bottom:-1px;border-radius:.25rem .25rem 0 0}.choices__list--dropdown .choices__list{position:relative;max-height:300px;overflow:auto;-webkit-overflow-scrolling:touch;will-change:scroll-position}.choices__list--dropdown .choices__item{position:relative;padding:10px;font-size:14px}[dir=rtl] .choices__list--dropdown .choices__item{text-align:right}@media (min-width:640px){.choices__list--dropdown .choices__item--selectable{padding-right:100px}.choices__list--dropdown .choices__item--selectable:after{content:attr(data-select-text);font-size:12px;opacity:0;position:absolute;right:10px;top:50%;transform:translateY(-50%)}[dir=rtl] .choices__list--dropdown .choices__item--selectable{text-align:right;padding-left:100px;padding-right:10px}[dir=rtl] .choices__list--dropdown .choices__item--selectable:after{right:auto;left:10px}}.choices__list--dropdown .choices__item--selectable.is-highlighted{background-color:#f2f2f2}.choices__list--dropdown .choices__item--selectable.is-highlighted:after{opacity:.5}.choices__item{cursor:default}.choices__item--selectable{cursor:pointer}.choices__item--disabled{cursor:not-allowed;-webkit-user-select:none;-ms-user-select:none;user-select:none;opacity:.5}.choices__heading{font-weight:600;font-size:12px;padding:10px;border-bottom:1px solid #f7f7f7;color:gray}.choices__button{text-indent:-9999px;-webkit-appearance:none;-moz-appearance:none;appearance:none;border:0;background-color:transparent;background-repeat:no-repeat;background-position:center;cursor:pointer}.choices__button:focus,.choices__input:focus{outline:0}.choices__input{display:inline-block;vertical-align:baseline;background-color:#f9f9f9;font-size:14px;margin-bottom:5px;border:0;border-radius:0;max-width:100%;padding:4px 0 4px 2px}[dir=rtl] .choices__input{padding-right:2px;padding-left:0}.choices__placeholder{opacity:.5} \ No newline at end of file diff --git a/src/scripts/choices.js b/src/scripts/choices.js index 5e05e21..99404c8 100644 --- a/src/scripts/choices.js +++ b/src/scripts/choices.js @@ -1327,6 +1327,7 @@ class Choices { const hasActiveDropdown = this.dropdown.isActive; const hasItems = this.itemList.hasChildren(); const keyString = String.fromCharCode(keyCode); + const wasAlphaNumericChar = /[a-zA-Z0-9-_ ]/.test(keyString); const { BACK_KEY, @@ -1340,9 +1341,17 @@ class Choices { PAGE_DOWN_KEY, } = KEY_CODES; - // If a user is typing and the dropdown is not active - if (!this._isTextElement && /[a-zA-Z0-9-_ ]/.test(keyString)) { + if (!this._isTextElement && !hasActiveDropdown && wasAlphaNumericChar) { this.showDropdown(); + + if (!this.input.isFocussed) { + /* + We update the input value with the pressed key as + the input was not focussed at the time of key press + therefore does not have the value of the key. + */ + this.input.value += keyString.toLowerCase(); + } } // Map keys to key actions @@ -1358,7 +1367,6 @@ class Choices { [BACK_KEY]: this._onDeleteKey, }; - // If keycode has a function, run it if (keyDownActions[keyCode]) { keyDownActions[keyCode]({ event, @@ -1380,6 +1388,7 @@ class Choices { // notice. Otherwise hide the dropdown if (this._isTextElement) { const canShowDropdownNotice = canAddItem.notice && value; + if (canShowDropdownNotice) { const dropdownItem = this._getTemplate('notice', canAddItem.notice); this.dropdown.element.innerHTML = dropdownItem.outerHTML; @@ -1388,8 +1397,8 @@ class Choices { this.hideDropdown(true); } } else { - const userHasRemovedValue = - (keyCode === backKey || keyCode === deleteKey) && !target.value; + const wasRemovalKeyCode = keyCode === backKey || keyCode === deleteKey; + const userHasRemovedValue = wasRemovalKeyCode && !target.value; const canReactivateChoices = !this._isTextElement && this._isSearching; const canSearch = this._canSearch && canAddItem.response; @@ -1407,6 +1416,7 @@ class Choices { _onAKey({ event, hasItems }) { const { ctrlKey, metaKey } = event; const hasCtrlDownKeyPressed = ctrlKey || metaKey; + // If CTRL + A or CMD + A have been pressed and there are items to select if (hasCtrlDownKeyPressed && hasItems) { this._canSearch = false; diff --git a/src/scripts/choices.test.js b/src/scripts/choices.test.js index 7cb5427..3c0b69b 100644 --- a/src/scripts/choices.test.js +++ b/src/scripts/choices.test.js @@ -3,7 +3,7 @@ import { spy, stub } from 'sinon'; import sinonChai from 'sinon-chai'; import Choices from './choices'; -import { EVENTS, ACTION_TYPES, DEFAULT_CONFIG } from './constants'; +import { EVENTS, ACTION_TYPES, DEFAULT_CONFIG, KEY_CODES } from './constants'; import { WrappedSelect, WrappedInput } from './components/index'; chai.use(sinonChai); @@ -2025,5 +2025,135 @@ describe('choices', () => { }); }); }); + + describe('_onKeyDown', () => { + beforeEach(() => { + instance.showDropdown = stub(); + instance._onAKey = stub(); + instance._onEnterKey = stub(); + instance._onEscapeKey = stub(); + instance._onDirectionKey = stub(); + instance._onDeleteKey = stub(); + }); + + const scenarios = [ + { + keyCode: KEY_CODES.BACK_KEY, + expectedFunctionCall: '_onDeleteKey', + }, + { + keyCode: KEY_CODES.DELETE_KEY, + expectedFunctionCall: '_onDeleteKey', + }, + { + keyCode: KEY_CODES.A_KEY, + expectedFunctionCall: '_onAKey', + }, + { + keyCode: KEY_CODES.ENTER_KEY, + expectedFunctionCall: '_onEnterKey', + }, + { + keyCode: KEY_CODES.UP_KEY, + expectedFunctionCall: '_onDirectionKey', + }, + { + keyCode: KEY_CODES.DOWN_KEY, + expectedFunctionCall: '_onDirectionKey', + }, + { + keyCode: KEY_CODES.DOWN_KEY, + expectedFunctionCall: '_onDirectionKey', + }, + { + keyCode: KEY_CODES.ESC_KEY, + expectedFunctionCall: '_onEscapeKey', + }, + ]; + + describe('when called with a keydown event', () => { + scenarios.forEach(({ keyCode, expectedFunctionCall }) => { + describe(`when the keyCode is ${keyCode}`, () => { + it(`calls ${expectedFunctionCall} with the expected arguments`, () => { + const mockEvent = { + keyCode, + }; + + instance._onKeyDown(mockEvent); + + expect(instance[expectedFunctionCall]).to.have.been.calledWith({ + event: mockEvent, + activeItems: instance._store.activeItems, + hasActiveDropdown: instance.dropdown.isActive, + hasFocusedInput: instance.input.isFocussed, + hasItems: instance.itemList.hasChildren(), + }); + }); + }); + }); + + describe('select input', () => { + describe('when the dropdown is not active', () => { + describe('when the key was alpha-numeric', () => { + beforeEach(() => { + instance._isTextElement = false; + instance.dropdown.isActive = false; + }); + + it('shows the dropdown', () => { + instance._onKeyDown({ + keyCode: KEY_CODES.A_KEY, + }); + + expect(instance.showDropdown).to.have.been.calledWith(); + }); + + describe('when the input is not focussed', () => { + beforeEach(() => { + instance.input.isFocussed = false; + }); + + it('updates the input value with the character corresponding to the key code', () => { + instance._onKeyDown({ + keyCode: KEY_CODES.A_KEY, + }); + + expect(instance.input.value).to.contain('a'); + }); + }); + + describe('when the input is focussed', () => { + beforeEach(() => { + instance.input.isFocussed = true; + }); + + it('does not update the input value', () => { + instance._onKeyDown({ + keyCode: KEY_CODES.A_KEY, + }); + + expect(instance.input.value).to.not.contain('a'); + }); + }); + }); + + describe('when the input was not alpha-numeric', () => { + beforeEach(() => { + instance._isTextElement = false; + instance.dropdown.isActive = false; + }); + + it('does not show the dropdown', () => { + instance._onKeyDown({ + keyCode: KEY_CODES.DELETE_KEY, + }); + + expect(instance.showDropdown).to.not.have.been.called; + }); + }); + }); + }); + }); + }); }); }); diff --git a/src/styles/choices.scss b/src/styles/choices.scss index 9912f5f..57987fd 100644 --- a/src/styles/choices.scss +++ b/src/styles/choices.scss @@ -74,7 +74,7 @@ $choices-icon-cross-inverse: url(data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMjEiI height: 20px; width: 20px; border-radius: 10em; - opacity: 0.5; + opacity: 0.25; &:hover, &:focus { opacity: 1;