From 7a784270b2fb62b4759e7608543d01834aa206a4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Tr=C3=A9bel?= Date: Wed, 14 Dec 2016 12:22:18 +0100 Subject: [PATCH] Remove choice from choices list when duplicateItems is false --- assets/scripts/src/choices.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/assets/scripts/src/choices.js b/assets/scripts/src/choices.js index 8d6a23e..9c3bffc 100644 --- a/assets/scripts/src/choices.js +++ b/assets/scripts/src/choices.js @@ -1392,14 +1392,14 @@ class Choices { } else { let isUnique; if (!duplicateItems) { - isUnique = !this.store + existingChoice = !this.store .getItems() - .some((item) => item.value === value.trim()); + .filter((item) => item.value === value.trim()); } - if (duplicateItems || isUnique) { + if (duplicateItems) { this._addChoice(true, false, value, value); } else { - this._addItem(value); + this._addItem(existingChoice.value, existingChoice.label, existingChoice.id); } this.containerOuter.focus(); }