More appropriate naming

This commit is contained in:
Josh Johnson 2017-06-27 16:35:46 +01:00
parent f6ea9224e2
commit 8485137121
3 changed files with 6 additions and 8 deletions

View file

@ -70,7 +70,7 @@ Or include Choices directly:
searchEnabled: true,
searchChoices: true,
searchFloor: 1,
searchChoiceLimit: 4,
searchResultLimit: 4,
searchFields: ['label', 'value'],
position: 'auto',
resetScrollPosition: true,
@ -278,7 +278,7 @@ Pass an array of objects:
**Usage:** The minimum length a search value should be before choices are searched.
### searchChoiceLimit: 4,
### searchResultLimit: 4,
**Type:** `Number` **Default:** `4`
**Input types affected:** `select-one`, `select-multiple`

View file

@ -65,7 +65,7 @@ class Choices {
searchEnabled: true,
searchChoices: true,
searchFloor: 1,
searchChoiceLimit: 4,
searchResultLimit: 4,
searchFields: ['label', 'value'],
position: 'auto',
resetScrollPosition: true,
@ -350,16 +350,14 @@ class Choices {
}
if (this.isSearching) {
for (var i = 0; i < this.config.searchChoiceLimit; i++) {
for (let i = 0; i < this.config.searchResultLimit; i++) {
const choice = choices[i];
if (choice) {
appendChoice(choice);
}
}
} else {
choices.forEach((choice) => {
appendChoice(choice);
});
choices.forEach(choice => appendChoice(choice));
}
return choicesFragment;

View file

@ -78,7 +78,7 @@ describe('Choices', () => {
expect(this.choices.config.searchEnabled).toEqual(jasmine.any(Boolean));
expect(this.choices.config.searchChoices).toEqual(jasmine.any(Boolean));
expect(this.choices.config.searchFloor).toEqual(jasmine.any(Number));
expect(this.choices.config.searchChoiceLimit).toEqual(jasmine.any(Number));
expect(this.choices.config.searchResultLimit).toEqual(jasmine.any(Number));
expect(this.choices.config.searchFields).toEqual(jasmine.any(Array) || jasmine.any(String));
expect(this.choices.config.position).toEqual(jasmine.any(String));
expect(this.choices.config.regexFilter).toEqual(null);