From b3486ccfbb94c0611b26b0bc15469ab2586ce307 Mon Sep 17 00:00:00 2001
From: Josh Johnson <josh@joshuajohnson.co.uk>
Date: Tue, 21 Nov 2017 16:17:00 +0000
Subject: [PATCH] Further public method unit tests

---
 src/scripts/src/choices.js      |   2 +-
 src/scripts/src/choices.test.js | 106 ++++++++++++++++++++++++++++++--
 2 files changed, 103 insertions(+), 5 deletions(-)

diff --git a/src/scripts/src/choices.js b/src/scripts/src/choices.js
index 9cb5a74..1d66560 100644
--- a/src/scripts/src/choices.js
+++ b/src/scripts/src/choices.js
@@ -610,7 +610,7 @@ class Choices {
    * @public
    */
   removeActiveItemsByValue(value) {
-    if (!value || !isType('String', value)) {
+    if (!value) {
       return this;
     }
 
diff --git a/src/scripts/src/choices.test.js b/src/scripts/src/choices.test.js
index 52e86a2..81ba405 100644
--- a/src/scripts/src/choices.test.js
+++ b/src/scripts/src/choices.test.js
@@ -1147,13 +1147,111 @@ describe('choices', () => {
     });
 
     describe('removeActiveItemsByValue', () => {
-      beforeEach(() => {});
-      it('removes each active item in store with matching value', () => {});
+      describe('passing invalid value', () => {
+        beforeEach(() => {
+          output = instance.removeActiveItemsByValue(null);
+        });
+
+        returnsInstance(output);
+      });
+
+      describe('passing valid value', () => {
+        let getItemsFilteredByActiveStub;
+        let removeItemStub;
+        const value = 'Removed';
+        const items = [
+          {
+            id: '1',
+            value: 'Not removed',
+          },
+          {
+            id: '2',
+            value: 'Removed',
+          },
+          {
+            id: '3',
+            value: 'Removed',
+          },
+        ];
+
+        beforeEach(() => {
+          removeItemStub = stub();
+          getItemsFilteredByActiveStub = stub().returns(items);
+          instance.store.getItemsFilteredByActive = getItemsFilteredByActiveStub;
+          instance._removeItem = removeItemStub;
+
+          output = instance.removeActiveItemsByValue(value);
+        });
+
+        afterEach(() => {
+          instance.store.getItemsFilteredByActive.reset();
+          instance._removeItem.reset();
+        });
+
+        it('removes each active item in store with matching value', () => {
+          expect(removeItemStub.callCount).to.equal(2);
+          expect(removeItemStub.firstCall.args[0]).to.equal(items[1]);
+          expect(removeItemStub.secondCall.args[0]).to.equal(items[2]);
+        });
+      });
     });
 
     describe('removeActiveItems', () => {
-      beforeEach(() => {});
-      it('removes each active item in store', () => {});
+      let getItemsFilteredByActiveStub;
+      let removeItemStub;
+      const items = [
+        {
+          id: '1',
+          value: 'Not removed',
+        },
+        {
+          id: '2',
+          value: 'Removed',
+        },
+        {
+          id: '3',
+          value: 'Removed',
+        },
+      ];
+
+      beforeEach(() => {
+        removeItemStub = stub();
+        getItemsFilteredByActiveStub = stub().returns(items);
+        instance.store.getItemsFilteredByActive = getItemsFilteredByActiveStub;
+        instance._removeItem = removeItemStub;
+      });
+
+      afterEach(() => {
+        instance.store.getItemsFilteredByActive.reset();
+        instance._removeItem.reset();
+      });
+
+      describe('not passing id to exclude', () => {
+        beforeEach(() => {
+          output = instance.removeActiveItems();
+        });
+
+        it('removes all active items in store', () => {
+          expect(removeItemStub.callCount).to.equal(items.length);
+          expect(removeItemStub.firstCall.args[0]).to.equal(items[0]);
+          expect(removeItemStub.secondCall.args[0]).to.equal(items[1]);
+          expect(removeItemStub.thirdCall.args[0]).to.equal(items[2]);
+        });
+      });
+
+      describe('passing id to exclude', () => {
+        const idToExclude = '2';
+
+        beforeEach(() => {
+          output = instance.removeActiveItems(idToExclude);
+        });
+
+        it('removes all active items in store with id that does match excludedId', () => {
+          expect(removeItemStub.callCount).to.equal(2);
+          expect(removeItemStub.firstCall.args[0]).to.equal(items[0]);
+          expect(removeItemStub.secondCall.args[0]).to.equal(items[2]);
+        });
+      });
     });
 
     describe('removeHighlightedItems', () => {