Merge pull request #983 from Choices-js/patch-1

Fix Sanitization of > Characters
This commit is contained in:
Matt Triff 2021-12-21 21:50:44 -05:00 committed by GitHub
commit b92823b70c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 8 deletions

View file

@ -315,7 +315,7 @@ describe('components/input', () => {
const value = '<script>somethingMalicious();</script>';
instance.element.value = value;
expect(instance.value).to.equal(
'&lt;script&rt;somethingMalicious();&lt;/script&rt;',
'&lt;script&gt;somethingMalicious();&lt;/script&gt;',
);
});
});

View file

@ -1,19 +1,20 @@
/* eslint-disable no-new-wrappers */
import { expect } from 'chai';
import { stub } from 'sinon';
import {
getRandomNumber,
cloneObject,
diff,
dispatchEvent,
existsInArray,
generateChars,
generateId,
getRandomNumber,
getType,
isType,
sanitise,
sortByAlpha,
sortByScore,
existsInArray,
cloneObject,
dispatchEvent,
diff,
} from './utils';
describe('utils', () => {
@ -113,7 +114,7 @@ describe('utils', () => {
const value = '<script>somethingMalicious();</script>';
const output = sanitise(value);
expect(output).to.equal(
'&lt;script&rt;somethingMalicious();&lt;/script&rt;',
'&lt;script&gt;somethingMalicious();&lt;/script&gt;',
);
});
});

View file

@ -93,7 +93,7 @@ export const sanitise = <T>(value: T | string): T | string => {
return value
.replace(/&/g, '&amp;')
.replace(/>/g, '&rt;')
.replace(/>/g, '&gt;')
.replace(/</g, '&lt;')
.replace(/"/g, '&quot;');
};