From e64eface11784aef78084dab35c6d45f1f349653 Mon Sep 17 00:00:00 2001 From: Matt Triff Date: Fri, 17 Dec 2021 16:59:43 -0500 Subject: [PATCH] Update all workflows to use Node 12+ for node-sass and other module compatibility, switch IE to Edge for browser testing (IE web driver no longer pre-installed on runner) --- .github/workflows/browsers.yml | 10 +++++----- .github/workflows/build-and-test.yml | 2 +- .github/workflows/bundlesize.yml | 2 +- .github/workflows/deployment.yml | 4 ++-- .github/workflows/unit-tests.yml | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/browsers.yml b/.github/workflows/browsers.yml index 525f993..de9b9ae 100644 --- a/.github/workflows/browsers.yml +++ b/.github/workflows/browsers.yml @@ -18,14 +18,14 @@ jobs: fail-fast: false matrix: os: [windows-latest, macos-latest] - browser: [ie, firefox, safari] + browser: [edge, firefox, safari] exclude: - # On Windows, run tests with only IE and Edge + # On Windows, run tests with Edge only - os: windows-latest browser: safari # On macOS, run tests with only on safari - os: macos-latest - browser: ie + browser: edge - os: macos-latest browser: chrome # Safari workaround is not working in Catalina @@ -82,8 +82,8 @@ jobs: - run: echo "$env:GeckoWebDriver" >> $GITHUB_PATH if: matrix.browser == 'firefox' && matrix.os == 'windows-latest' - - run: echo "C:\SeleniumWebDrivers\IEDriver" >> $GITHUB_PATH - if: matrix.browser == 'ie' && matrix.os == 'windows-latest' + - run: echo "$env:EdgeWebDriver" >> $GITHUB_PATH + if: matrix.browser == 'edge' && matrix.os == 'windows-latest' - run: echo "$env:ChromeWebDriver" >> $GITHUB_PATH if: matrix.browser == 'chrome' && matrix.os == 'windows-latest' diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 63c08ce..565d42c 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -14,7 +14,7 @@ jobs: fetch-depth: 1 - uses: actions/setup-node@v1 with: - node-version: 10 + node-version: 12 - name: Build and run all tests run: | npm ci diff --git a/.github/workflows/bundlesize.yml b/.github/workflows/bundlesize.yml index 168d34f..7fe3ca1 100644 --- a/.github/workflows/bundlesize.yml +++ b/.github/workflows/bundlesize.yml @@ -18,7 +18,7 @@ jobs: - uses: actions/setup-node@v1 with: - node-version: 10 + node-version: 12 - name: Install dependencies and build run: | diff --git a/.github/workflows/deployment.yml b/.github/workflows/deployment.yml index a8137d7..bfca1ef 100644 --- a/.github/workflows/deployment.yml +++ b/.github/workflows/deployment.yml @@ -13,7 +13,7 @@ jobs: fetch-depth: 1 - uses: actions/setup-node@v1 with: - node-version: 10 + node-version: 12 registry-url: https://registry.npmjs.org/ - run: npm ci env: @@ -32,7 +32,7 @@ jobs: fetch-depth: 1 - uses: actions/setup-node@v1 with: - node-version: 10 + node-version: 12 registry-url: https://registry.npmjs.org/ - name: Build run: | diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml index e67e330..8278358 100644 --- a/.github/workflows/unit-tests.yml +++ b/.github/workflows/unit-tests.yml @@ -17,7 +17,7 @@ jobs: - uses: actions/setup-node@v1 with: - node-version: 10 + node-version: 12 - name: Install dependencies run: npm install --no-optional --no-audit --ignore-scripts