From e7b4afd4720202604cddffec8bc558c1e4845fe9 Mon Sep 17 00:00:00 2001
From: Josh Johnson <josh@joshuajohnson.co.uk>
Date: Fri, 15 Nov 2019 19:34:20 +0000
Subject: [PATCH] Fix releases (#761)

* Testing

* Re add "needs" flags

* Further testing

* Add skip husky install flag

* Revert "on" flag
---
 .github/workflows/deployment.yml | 42 +++-----------------------------
 1 file changed, 4 insertions(+), 38 deletions(-)

diff --git a/.github/workflows/deployment.yml b/.github/workflows/deployment.yml
index bc6b1e5..a8137d7 100644
--- a/.github/workflows/deployment.yml
+++ b/.github/workflows/deployment.yml
@@ -5,44 +5,6 @@ on:
     types: [published]
 
 jobs:
-  build-and-test:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v1
-        with:
-          fetch-depth: 1
-      - uses: actions/setup-node@v1
-        with:
-          node-version: 10
-      - run: |
-          npm ci
-          npm run build
-          npx bundlesize
-          npm run test:unit:coverage
-          npm run test:e2e
-        env:
-          CI: true
-          CI_REPO_NAME: ${{ github.event.repository.name }}
-          CI_REPO_OWNER: ${{ github.event.organization.login }}
-          CI_COMMIT_SHA: ${{ github.sha }}
-          GIT_COMMIT: ${{ github.sha }}
-          CI_BRANCH: ${{ github.head_ref }}
-          BUNDLESIZE_GITHUB_TOKEN: ${{secrets.BUNDLESIZE_GITHUB_TOKEN}}
-          FORCE_COLOR: 2
-          HUSKY_SKIP_INSTALL: true
-
-      - name: Upload coverage to Codecov
-        run: bash <(curl -s https://codecov.io/bash)
-          -f ./coverage/lcov.info
-          -B ${{ github.head_ref }}
-          -C ${{ github.sha }}
-          -Z || echo 'Codecov upload failed'
-        env:
-          CI: true
-          GITLAB_CI: true # pretend we are GitLab CI, while Codecov adding support for Github Actions
-          CODECOV_ENV: github-action
-          CODECOV_TOKEN: ${{secrets.CODECOV_TOKEN}}
-
   publish-npm:
     runs-on: ubuntu-latest
     steps:
@@ -62,6 +24,7 @@ jobs:
           NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
 
   deploy-gh-pages:
+    needs: publish-npm
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v1
@@ -76,6 +39,9 @@ jobs:
           npm ci
           npm run build
           rm -rf public/test
+        env:
+          CYPRESS_INSTALL_BINARY: 0
+          HUSKY_SKIP_INSTALL: true
       - name: Deploy
         uses: peaceiris/actions-gh-pages@v2.5.0
         env: