Commit graph

683 commits

Author SHA1 Message Date
Xon
9c43fa60fb Fix searchEnabled being disabled for select-multiple 2026-01-01 07:42:04 +08:00
Xon
51f77558a9
Merge pull request #1358 from samuelhwilliams/search-render-selected-choices
Allow selected options to be hidden when searching
2026-01-01 02:42:08 +08:00
Xon
b47ae9214e Cleanup searchRenderSelectedChoices option to just be a boolean with backwards compatible defaults 2026-01-01 02:34:43 +08:00
Xon
5c81671e7d
Merge pull request #1361 from zoglo/rework/selection-highlight
Improve UX on the select dropdown
2026-01-01 02:14:48 +08:00
Xon
79b65d71cb
Merge pull request #1357 from thewatts/feature/search-disabled-choices
Add `searchDisabledChoices` configuration option to allow disabled choices to appear in search results
2026-01-01 01:53:21 +08:00
Xon
d926bd0219
Merge pull request #1365 from Choices-js/trusted-label-description
Fix data-label-description from source html was not treated as trusted
2026-01-01 01:48:46 +08:00
Xon
ee64830817 Fix data-label-description from source html was not treated as trusted 2026-01-01 01:43:45 +08:00
Xon
ffda4cbdfd Fix KMP search-as-you-type not returning results as expected 2026-01-01 01:43:24 +08:00
Sebastian Zoglowek
cab94ca67b Revert highlight 2025-11-27 14:26:29 +01:00
Sebastian Zoglowek
320a0507be Rebuild 2025-11-27 13:43:47 +01:00
Sebastian Zoglowek
6b30de46e6 Scroll the first selected option into the view 2025-11-26 19:14:25 +01:00
Sebastian Zoglowek
6f1d048e08 Remove highlighted choices on hideDropdown 2025-11-26 18:58:01 +01:00
Sebastian Zoglowek
ada46b0101 Style the unused is-selected class and don't show the selection text on selected 2025-11-26 14:43:50 +01:00
Sebastian Zoglowek
8d844ddb94 Remove the highlight state from the render function (we already have is-selected) 2025-11-26 14:42:39 +01:00
Samuel Williams
b40c7fc59c
Allow selected options to be hidden when searching 2025-10-30 07:51:23 +00:00
Nathaniel Watts
afe7ae455e Add searchDisabledChoices configuration option
This adds a new configuration option `searchDisabledChoices` that allows
disabled choices to appear in search results while remaining non-selectable.

Previously, disabled choices were always excluded from search results via
the Store's searchableChoices getter. This made it impossible for users to
find disabled options even when they wanted to see what options exist but
are currently unavailable.

Changes:
- Add searchDisabledChoices option to Options interface (default: false)
- Update Store.searchableChoices getter to respect the new config
- Add test coverage for the new functionality
- Maintain backward compatibility with default behavior

The selection prevention logic in _handleChoiceAction already prevents
disabled choices from being selected, so they remain non-selectable even
when found in search results.

Fixes the limitation where users couldn't search for disabled options to
see what choices exist but are currently unavailable.
2025-10-24 14:04:50 -05:00
Sebastian Zoglowek
15ffa65b4e Do not highlight the previous dropdown item on an active search 2025-08-23 14:53:03 +02:00
Xon
d5524bdce3 Fix check for invoking _highlightChoice() 2025-08-23 14:53:02 +02:00
Xon
013d1063af Revert "Remove selectableChoices, after refactoring how highlightedEl is set as this state is redundnant"
This reverts commit 605ca42b550d76d37590c50ce63de4ba0f794059.
2025-08-23 14:53:02 +02:00
Xon
3f662608c4 Remove selectableChoices, after refactoring how highlightedEl is set as this state is redundnant 2025-08-23 14:53:02 +02:00
Xon
01aa8ac5da Highlight the first selected choice in the dropdown 2025-08-23 14:53:02 +02:00
Sebastian Zoglowek
46c3b65f34 Initially set highlightPosition for select elements 2025-08-23 14:51:28 +02:00
Sebastian Zoglowek
9a6fd90055 Highlight the first selected choice on render 2025-08-23 14:49:15 +02:00
Xon
62ce325b44
Merge pull request #1335 from zoglo/chore/custom-property-migration
Add CSS `custom properties` support (+ dark mode for the intro page)
2025-08-23 18:24:03 +08:00
Sebastian Zoglowek
97c6c7edef Fix --choices-multiple-item-padding 2025-08-23 12:15:47 +02:00
Xon
4032b42fdc Fix typo 2025-08-23 13:32:58 +08:00
Gaël-Ian
618aef677a
Allow remove button to not be a direct descendant of item 2025-08-20 21:02:20 +02:00
Gaël-Ian
067c95d18e
Allow SVG elements in remove buttons 2025-08-20 21:00:39 +02:00
Sebastian Zoglowek
d2b3e13a73 CS 2025-08-17 21:52:49 +02:00
Sebastian Zoglowek
5a3622849f Welcome dark mode 😎 2025-08-17 21:40:24 +02:00
Sebastian Zoglowek
5059403924 Make the border color adjustable as well 2025-08-17 20:37:34 +02:00
Sebastian Zoglowek
67aef19148 Remove the previous prototype css 2025-08-17 19:33:46 +02:00
Sebastian Zoglowek
4e0624cb4a Add custom properties and remove the usage of sass:color 2025-08-17 19:32:53 +02:00
Xon
d6ae2f78e9 Update choices.css 2025-08-16 23:50:51 +08:00
Sebastian Zoglowek
73b53be12d Run CS 2025-08-16 23:50:51 +08:00
Sebastian Zoglowek
493795e649 Add $choices-invalid-color 2025-08-16 23:50:40 +08:00
Sebastian Zoglowek
a25a095ef7 Add an invalidState 2025-08-16 23:50:40 +08:00
Xon
ea7b5c1071
Merge pull request #1304 from lera-sh/fix_styles
Add additional SCSS variables
2025-08-16 23:33:02 +08:00
Xon
98027b5435 When rendering a choice, fill aria-selected state from choice.selected 2025-08-16 23:09:47 +08:00
Pablo Brasero
d4e8eebc9d Avoid triple state: aria-selected=("true"|"false"|unset) 2025-07-26 21:19:50 +01:00
Xon
04bba88c6b Fix appendGroupInSearch option was non-functional 2025-07-10 04:42:56 +08:00
Xon
ab64051e7f Fix incorrect type being assigned to config.appendGroupInSearch 2025-07-10 04:20:44 +08:00
Xon
5ca0350e8e When resolving the remove item/label/icon, add a 3rd argument item argument. Update default remove item label to use (Fixes #1296) 2025-07-10 04:06:01 +08:00
Xon
acf3dfc4ca Fix setting searchResultLimit to -1 was ineffective if renderChoiceLimit was set to a positive integer 2025-07-10 00:06:29 +08:00
Leo Feyer
b73e735c23 Use config.searchEnabled instead of _canSearch in the _onBlur method 2025-07-09 23:45:46 +08:00
Xon
c90ab39c6d Missing brackets 2025-07-09 22:27:45 +08:00
Xon
856459b905 Tidy up scss 2025-07-09 22:23:56 +08:00
Xon
6977b0ded0 Re-add previous css which was removed 2025-07-09 22:21:55 +08:00
Xon
2abb2d982a Revert css statement ordering changes 2025-07-09 22:17:01 +08:00
Valeryia Shyrko
9bc9d1683c Tune styles 2025-05-13 08:50:43 +02:00