Josh Johnson
3c05016920
Merge branch 'master' of https://github.com/DarrenMack-OD/Choices into DarrenMack-OD-master
2019-03-29 08:57:38 +00:00
Darren Mackintosh
9c021408fa
Update choices.test.js
2019-03-15 16:57:57 +00:00
Darren Mackintosh
aceb838988
Rolled back webpack changes in Choices.js
2019-03-15 16:57:35 +00:00
Darren Mackintosh
03a45094b7
Update index.test.js
2019-03-14 12:31:29 +00:00
Darren Mackintosh
92680c0dc0
Update index.js
2019-03-14 12:20:43 +00:00
Darren Mackintosh
da87fa07cf
Update choices.test.js
2019-03-14 12:13:06 +00:00
Darren Mackintosh
2247eff08a
Added linting exclusion for WebPack
2019-03-14 12:03:22 +00:00
Darren Mackintosh
5018e4a7d4
Updated reference to choices
...
Because I have attempted to fix the WebPack issue with choices, I need to change how it is referenced
2019-03-14 11:47:11 +00:00
Darren Mackintosh
cc32284e8a
Updated reference to choices
...
Because I have attempted to fix the WebPack issue with choices, I need to change how it is referenced
2019-03-14 11:46:39 +00:00
Darren Mackintosh
b1005061ff
Changed reference to Choices
...
Because I have attempted to fix the WebPack issue with choices, I need to change how it is referenced
2019-03-14 11:44:46 +00:00
Darren Mackintosh
6486bbbd6d
Updated tests to reflect changes to choices.js
2019-03-14 11:23:57 +00:00
Darren Mackintosh
f9f63e7aba
Fix for the webpack issue
...
export choices as a class to circumvent the webpack issue
2019-03-14 11:23:12 +00:00
Hans Lemuet
5c17250e20
Allow passing an empty array to setChoices
2019-03-13 10:34:06 +01:00
Hans Lemuet
fc9bca2ece
Rename _clearChoices to clearChoices
2019-03-13 10:05:38 +01:00
Darren Mackintosh
2fa92520ef
Updated Choices.js
...
Fixes scrollbar issue in IE11. There is an EDGE-CASE where-by if a user were to select the same option twice, the dropdown doesn't go away. This is, however a very extreme case and we are on the right track
2019-03-12 20:27:54 +00:00
Josh Johnson
879c97f64c
Resolve undefined error ( #528 )
...
* Remove run-p from test command
* Remove dropdown interaction tests
* Tidy utils
* Use merge lib
* Remove string casting
* Sanitise in constants
* Housekeeping
* Add non-string value tests
2019-02-22 22:04:55 +00:00
Josh Johnson
8540d5aabd
Api changes ( #515 )
...
* Combine regexFilter and addItemFilter + minor tweaks
* Update tests to accomodate fixed dropdown notice
* Remove broken `toggleDropdown` method
* Unskip dropdown interaction tests
* Remove reference to removed method
2019-02-12 18:35:46 +00:00
Josh Johnson
55b356ec69
Add travis pipeline ( #516 )
...
* Update travis.yml
* Simplify ci pipeline
* Include css in bundle size check
* Set npm username via env var
* Specify branches
* Add build scripts
* Consistent ifs
* Add linting stage to pipeline
* Cache npm
* Cache cypress & npm folders + install using ci method
* Unignore package-lock
2019-02-12 18:04:50 +00:00
Glade
ba09fb00e6
callback to filter items before adding ( #485 )
...
* Add item custom callback
* Minor unit test updates
* Test updates, Changed callback name to more clearly distinguish it's function
* Fix description wording in cypress
* Update README
* Updated filter item callback name to be addItemFilter
2019-02-11 22:56:21 +00:00
Josh Johnson
23e5e7674f
Tweak doc page
2019-02-11 21:47:47 +00:00
Guilherme de Oliveira Costa
71a3131d3c
Added custom properties to options
...
Added custom properties to options to be searchable on select.
2019-02-11 16:05:59 -02:00
Josh Johnson
5c9dfdf2db
Upgrade old packages ( #508 )
...
* Upgrade Webpack to v4
* Upgrade Mocha
* Export unminfied and minified version
* Add browserslistrc
* Remove core.js polyfills
* Run bundle size on pre push
* Run bundlesize last
* Update readme gzip side
2019-02-09 18:13:25 +00:00
Josh Johnson
437651411f
Fix render blocking ( #456 )
...
* Reapply changes from PR #310
* Version 4.1.1
* Update action name
* Update test
* Resolved broken test
2019-01-26 12:36:47 +00:00
Jeremy Hou
48b74a91bc
fixes the 'invalid input type' check ( #498 )
2019-01-21 08:46:14 +00:00
Jeremy Hou
9c001487ba
Fixes an issue where deepmerge concatenates array configs ( #496 )
2019-01-19 14:47:22 +00:00
Josh Johnson
826384b9d5
Fix set choice by value bug ( #471 )
...
* Resolve bug with setChoiceByValue not removing choice from dropdown
* 4.1.3
* Version 4.1.3
2018-11-25 12:48:49 +00:00
Josh Johnson
c3e46e55aa
Fix form submission bug in firefox ( #470 )
...
* Fix form submission bug in firefox
* 4.1.1
2018-11-24 17:48:03 +00:00
Josh Johnson
496db95153
Disable input when loading remote data
2018-11-03 13:24:52 +00:00
Josh Johnson
f3c0abef95
Add e2e tests to interact with dropdown
2018-11-03 12:26:02 +00:00
Josh Johnson
feb2a15edc
Disable at a later stage of intialising
2018-10-30 22:04:08 +00:00
Josh Johnson
b0f3b28ef4
Do not open dropdown if element is disabled
2018-10-30 20:28:40 +00:00
Josh Johnson
798b49d565
Disable element if disabled attr passed
2018-10-30 20:21:52 +00:00
Josh Johnson
7e4347b183
Resolve issue with Firefox not selecting choices via enter key
2018-10-30 19:20:16 +00:00
Josh Johnson
608358a9f8
Fix bug where selected options were not being selected
2018-10-28 09:32:35 +00:00
Josh Johnson
de71fb7ef4
Resolve issue with disable/enable methods
2018-10-27 20:16:46 +01:00
Leonard
8149db8436
Make it work in Internet Explorer ( #434 )
...
+ IE does not support multiple-parameter classList.add() /
classList.remove(); Replace it with single-parameter calls
https://caniuse.com/#feat=classlist
+ IE needs polyfills for Array.prototype.find / Array.prototype.includes
2018-10-27 16:26:52 +01:00
Josh Johnson
4193422cf6
Resolve an issue with disabling/enabling instances
2018-10-21 19:26:08 +01:00
Josh Johnson
e07e14bd8f
Add select multiple e2e tests
2018-10-13 16:38:51 +01:00
Josh Johnson
1f06a32b30
Resolve bug with text value
2018-10-13 15:49:44 +01:00
Josh Johnson
2f96c239ff
Better organisation of e2e tests
2018-10-13 12:18:02 +01:00
Josh Johnson
81b2e23d0d
Use test.html for testing + add additional tests
2018-10-11 19:33:19 +01:00
Josh Johnson
3319529b98
Seperate key methods into class methods
2018-10-09 13:17:11 +01:00
Josh Johnson
60d52a2d3b
Check no unknown config keys are passed
2018-10-09 13:16:58 +01:00
Josh Johnson
4431a0ec23
Use deepmerge lib + store all defaults in DEFAULT_CONFIG
2018-10-09 12:43:25 +01:00
Josh Johnson
4824958e4d
Make render method private
2018-10-09 12:26:47 +01:00
Ryan Mahoney
5e215907f4
expose new event that triggers when choice is highlighted
2018-07-03 09:51:18 +01:00
Josh Johnson
129d01c396
Amend copy
2018-05-29 20:39:40 +01:00
Josh Johnson
3886cbbd5c
Minor tweaks
2018-05-29 20:30:58 +01:00
Josh Johnson
9ac62aec31
Codebeat fixes
2018-05-29 20:08:05 +01:00
Josh Johnson
38cc568341
Use objects for args where necessary
2018-05-29 19:55:33 +01:00