Commit graph

200 commits

Author SHA1 Message Date
Josh Johnson e6882f3e4b
Add missing type definitions + rename sortFn (#734)
* Add wrapped element getters + fix some types

* Remove comment

* Add missing config options to types

* Add types to constants

* Rename sortFn to sorter

* Update PR template

* Add refactor to PR template

* Add passed element types to constants

* Add js doc comments to actions

* Add "returns" to js doc comments

* Add missing choice prop to type

* Add types to store.js

* Add jsdoc comments to components

* Ignore strict null checks

* Move loading action into misc.js

* Further type def additions

* Rename itemCompare to valueCompare

* Update badges

* Rename scrollToChoice to scrollToChildElement
2019-11-03 13:18:16 +00:00
Josh Johnson a0fe05f926
Fix #727 (#731)
* Housekeeping

* Resolve placeholder bug + hide from choice list

* Restructure test folder

* Update cypress test to assert one placeholder

* Fix breaking e2e test

* Remove ability to pass placeholder via config for select boxes

* Add further e2e tests covering placeholders

* Add unit tests for _generatePlaceholderValue

* Display placeholder choice for select one

* Add further e2e test to assert on placeholder ordering

* Add labels to exclude from draft releases

* Add failure case to e2e test workflow

* Resolve broken e2e test

* Update puppeteer snapshot baseline
2019-11-02 13:49:33 +00:00
Josh Johnson 0e44a916e3
Fix constructor (#693)
* breaking test

* Remove ablity to pass multiple elements + tests

* Update readme

* Update README.md

* 🔖 Version 8.0.0

* Remove type definition hack

* Update coverage command

* Add some missing list tests

* Remove .only

* Update demo page to loop over elements

* Update constructor to set initialised flag if already active

* Make templates private

* Throw type error once if element is invalid

* Fix list children bug

* Re-add generic examples to index.html

* Housekeeping

* Use typeof instead of isType where applicable

* Remove isElement

* Add test for isIE11
2019-10-29 21:19:56 +00:00
Konstantin Vyatkin 172366d6fa [Tooling] Expand browsers target while keeping Polyfills under control (#709)
* expand browsers target

* add eslint-plugin-compat

* sort polyfils

* adjust readme

* add polyfills sync check action

* only build js

* trim

* add Element.prototype.closest

* add closest to demo links

* fix ignore
2019-10-29 18:19:19 +00:00
Konstantin Vyatkin e3cc6eaf1b [MAJOR] Remove .ajax and allow async function for .setChoices (#701)
* WIP: remove ajax

* copy #700

* remove ajax, add fetchChoices

* extend setChoices

* update README
2019-10-29 18:12:32 +00:00
Konstantin Vyatkin b080bcda7d rename addItemFilterFn (#699) 2019-10-29 17:29:31 +00:00
Konstantin Vyatkin 9504cfcec5 [MAJOR] expose defaults and original Template rendering functions (#708)
* expose original Template rendering functions

* add to types

* add moduleResolution

* use `defaults`
2019-10-29 15:13:00 +00:00
Konstantin Vyatkin a2485392a5 don't reimplement native closest (#696) 2019-10-28 20:26:19 +00:00
Konstantin Vyatkin 64407174e3 closes #587 (#704) 2019-10-28 19:33:27 +00:00
Konstantin Vyatkin ef2c70fb7a use default parameters (#698)
* use default parameters

* Fix argument name in README
2019-10-25 13:21:38 +01:00
Konstantin Vyatkin 7887c05249 [MAJOR] use attribute hidden (#691)
* use attribute hidden

* commit something to re-run tests
2019-10-24 18:09:44 +01:00
Konstantin Vyatkin 6848970fd9 improve Babel and webpack configurations --> reduce JS bundle size (#670)
* simplify babel config

* fix Cypress VSCode checks

* introduce webpack base config

* fix flacky cypress test

* fix class properties definition

* fix default export

* upgrade affected deps, decrease bundlesize

* run ESLint only on changed files
2019-10-22 17:08:43 +01:00
Christophe Coevoet 8782564ddf Add support for standard-compliant placeholder option (#617)
* Add support for standard-compliant placeholder option

* Bump version and rebuild files
2019-10-22 11:25:36 +01:00
Josh Johnson ffc32df462
Resolve vulnerabilities + fix tests (#668)
* Remove GPR Github action (for now)

* Update test badge

* Remove stale.yml

* Upgrade cypress + fix failing tests

* Upgrade postcss-cli

* Update postcss command

* Remove space

* Add slight delay between scrolling animations

* Update test descriptions

* Remove signed commits/tagging (for now)

* chore(release): 🔖 version 7.0.5

* Update commit message

* Revert "Upgrade cypress + fix failing tests"

This reverts commit b6fbd0f51a.
2019-10-21 21:43:38 +01:00
Benoît Rouleau 31ef5bb065 Improve callbackOnCreateTemplates example (#647)
Shows how to add the placeholder class(es) when the item is the placeholder.
2019-10-21 10:51:53 +01:00
Jason Cooke 62ccd923ff docs: fix typos (#605) 2019-06-30 20:02:52 +01:00
David Kennell 43e670d02d fix typo (#596) 2019-05-28 18:52:26 +01:00
Josh Johnson 67382a3f31 Use v3 of polyfill 2019-03-29 09:12:29 +00:00
Hans Lemuet 5c17250e20
Allow passing an empty array to setChoices 2019-03-13 10:34:06 +01:00
Josh Johnson bbbc31594c
Update README.md 2019-03-11 12:19:52 +00:00
Christophe Coevoet 56845e3897 Remove the CustomEvent polyfill from the bundle 2019-02-28 11:51:04 +01:00
Hans Lemuet c424ae2f3b Fix #499 documentation error about passedElement (#517) 2019-02-14 08:34:44 +00:00
Josh Johnson 8540d5aabd
Api changes (#515)
* Combine regexFilter and addItemFilter + minor tweaks

* Update tests to accomodate fixed dropdown notice

* Remove broken `toggleDropdown` method

* Unskip dropdown interaction tests

* Remove reference to removed method
2019-02-12 18:35:46 +00:00
Glade ba09fb00e6 callback to filter items before adding (#485)
* Add item custom callback

* Minor unit test updates

* Test updates, Changed callback name to more clearly distinguish it's function

* Fix description wording in cypress

* Update README

* Updated filter item callback name to be addItemFilter
2019-02-11 22:56:21 +00:00
Josh Johnson 5c9dfdf2db
Upgrade old packages (#508)
* Upgrade Webpack to v4

* Upgrade Mocha

* Export unminfied and minified version

* Add browserslistrc

* Remove core.js polyfills

* Run bundle size on pre push

* Run bundlesize last

* Update readme gzip side
2019-02-09 18:13:25 +00:00
Josh Johnson 6c3bad777d
Add bundlesize (#502)
* Configure bundlesize

* Update travis script

* Remove node modules cache

* Run bundlesize as after script

* Remove duplicate coverage check

* Remove test:size from test command
2019-01-24 23:21:00 +00:00
Andrey Nering 367fee6885 README: Fix CDN URLs (#465)
Thanks 👍
2018-11-22 22:35:43 +00:00
Josh Johnson 307881a068 Update documentation 2018-11-03 12:42:42 +00:00
Josh Johnson ff08408c84 Update README 2018-10-28 11:18:35 +00:00
Josh Johnson 2288d47672 Update CDN badge 2018-10-28 11:17:08 +00:00
Josh Johnson 728b570e57 Woops 2018-10-28 11:15:49 +00:00
Josh Johnson 58a3d66cd3 Update CDN links 2018-10-28 11:13:43 +00:00
Josh Johnson 8e6daa64f0 Update codebeat badge url 2018-10-27 21:16:28 +01:00
Josh Johnson 013058dd7f Update readme to document multiple instances 2018-10-27 20:03:53 +01:00
Josh Johnson 315b2f8f36 Add e2e tests for choice groups 2018-10-27 18:12:15 +01:00
Josh Johnson a06988406a Add Adidas web component link to README 2018-10-27 17:39:46 +01:00
Josh Johnson 0439728374 Add CDN examples to README 2018-10-27 17:01:54 +01:00
Josh Johnson 2c434feb43 Add CDN link to README 2018-10-27 17:00:40 +01:00
Josh Johnson af4dd13ffe Run e2e in travis 2018-10-11 19:46:50 +01:00
Josh Johnson 4824958e4d Make render method private 2018-10-09 12:26:47 +01:00
Joshua Dorenkamp 49c6a648c0 npm --save no longer necessary 2018-08-14 09:14:34 +01:00
Joshua Dorenkamp 28da5683e5 remove bower add yarn 2018-08-14 09:14:34 +01:00
Ryan Mahoney 8dedc6f1e0 update documentation 2018-07-03 09:51:18 +01:00
Josh Johnson 9ac62aec31 Codebeat fixes 2018-05-29 20:08:05 +01:00
Josh Johnson 8a21c12482 Rename duplicateItems to duplicateItemsAllowed for clarity 2018-05-29 09:30:05 +01:00
Egon Richárd Tőrös 0cbf951845 Merge branch 'develop' of https://github.com/jshjohnson/Choices into develop 2018-05-28 16:13:55 +02:00
Josh Johnson 257a038262 Use express for development + folder restructuring 2018-05-27 11:57:21 +01:00
Egon Richárd Tőrös 00ac0d879e 🔥 Typo 2018-03-19 11:48:29 +01:00
Egon Richárd Tőrös e60be87a94 🚑 Add example 2018-03-19 11:46:28 +01:00
Bart Langedijk 2514cbcd51 Update README.md 2018-03-08 12:33:54 +00:00