From c288fe44ce9995a89c6a455b6bb7774b1d943c29 Mon Sep 17 00:00:00 2001 From: koalyptus Date: Sun, 17 Dec 2017 22:50:01 +1100 Subject: [PATCH 1/5] Update PULL_REQUEST_TEMPLATE.md --- PULL_REQUEST_TEMPLATE.md | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 2ba3a08f..7399f6b0 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -1,17 +1,23 @@ -TableFilter welcomes contributions from anyone and everyone. If you want to get -your hands dirty: +# Description -### Pull requests -In general, we follow the "fork-and-pull" Git workflow. +Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. +Fixes # (issue) - 1. **Fork** the repo on GitHub - 2. **Clone** the project to your own machine - 3. **Commit** changes to your own branch - - 3.1 **Bump** package version in `package.json` file - - 3.2. **Add** unit tests covering your change in the `test` folder - - 3.3. **Run** the tests with the `npm run eslint test` command - - 3.4. **Ensure** build is working with `npm run dist` command - 4. **Push** your work back up to your fork - 5. Submit a **Pull request** so that we can review your changes +## Type of change -NOTE: Be sure to merge the latest from "upstream" before making a pull request! +Please delete options that are not relevant. + +- [ ] Bug fix (non-breaking change which fixes an issue) +- [ ] New feature (non-breaking change which adds functionality) +- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) +- [ ] This change requires a documentation update + +# Checklist: + +- [ ] My code follows the style guidelines of this project +- [ ] I have performed a self-review of my own code +- [ ] I have commented my code, particularly in hard-to-understand areas +- [ ] I have made corresponding changes to the documentation +- [ ] My changes do not lower current test coverage +- [ ] I have added tests that prove my fix is effective or that my feature works +- [ ] New and existing unit tests pass locally with my changes From a01c914f0a15017164e8d0622d3902cdb89062f5 Mon Sep 17 00:00:00 2001 From: "greenkeeper[bot]" Date: Sun, 24 Dec 2017 07:17:53 +0000 Subject: [PATCH 2/5] chore(package): update babel-eslint to version 8.1.0 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index e0f2f2ee..80a7a0ff 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ }, "devDependencies": { "babel-core": "^6.24.1", - "babel-eslint": "8.0.3", + "babel-eslint": "8.1.0", "babel-loader": "^7.0.0", "babel-plugin-transform-es2015-classes": "^6.24.1", "babel-preset-es2015": "^6.24.1", From be67034e02454c8dddb3aa20b111aacf2caf2fc4 Mon Sep 17 00:00:00 2001 From: koalyptus Date: Mon, 25 Dec 2017 22:00:58 +1100 Subject: [PATCH 3/5] Update .eslintrc --- .eslintrc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index 21794fe2..4604b80e 100644 --- a/.eslintrc +++ b/.eslintrc @@ -14,7 +14,7 @@ "keyword-spacing": ["error", { "after": true, "before": true }], "max-depth": [2, 7], "max-statements": [2, 130], - "complexity": [2, 33], + "complexity": [2, 41], "no-unused-vars": 2, "no-eval": 2, "no-underscore-dangle": 0, From f4471999054bd0eef9acf3981a6770dd8103eae2 Mon Sep 17 00:00:00 2001 From: koalyptus Date: Mon, 25 Dec 2017 22:15:17 +1100 Subject: [PATCH 4/5] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 80a7a0ff..048cd24c 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ }, "devDependencies": { "babel-core": "^6.24.1", - "babel-eslint": "8.1.0", + "babel-eslint": "8.1.1", "babel-loader": "^7.0.0", "babel-plugin-transform-es2015-classes": "^6.24.1", "babel-preset-es2015": "^6.24.1", From 88d31090b4d604a92ccccc0e8db4fb4aa1565ef2 Mon Sep 17 00:00:00 2001 From: "greenkeeper[bot]" Date: Tue, 26 Dec 2017 02:17:18 +0000 Subject: [PATCH 5/5] chore(package): update babel-eslint to version 8.1.2 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 048cd24c..88860cd5 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ }, "devDependencies": { "babel-core": "^6.24.1", - "babel-eslint": "8.1.1", + "babel-eslint": "8.1.2", "babel-loader": "^7.0.0", "babel-plugin-transform-es2015-classes": "^6.24.1", "babel-preset-es2015": "^6.24.1",