deblan-mirror/TableFilter
1
0
Fork 0
mirror of https://github.com/koalyptus/TableFilter.git synced 2024-05-23 08:42:18 +02:00
Code Issues Releases Wiki Activity
1595 commits 13 branches 101 tags 107 MiB
Commit graph

19 commits

Author SHA1 Message Date
koalyptus df0221d5e7 refactor feature istantiation helpers 2019-02-10 00:27:55 +11:00
Archis Gore fb2f201f29 URL Encode State Hash 
You'll notice a mild asymmetry in how hash was
saved vs retrieved.

The retrieval was:
    JSON.parse(decodeUrlComponent(hash))

The save was:
    JSON.stringify(hash)

I modified it to:
    JSON.stringify(encodeUrlComponent(hash))

The reason I noticed this is in one of my apps,
I wanted to be able to copy/share a stateful filter URL.

However without the url encoding, those auto-parsers
of URLs were missing the full filter.

TESTING CONDUCTED:
1. Updated the Hash unit tests to both parse the
   encoded string, as well as generate it.

2. Ran "grunt", which has built/tested/jslinted
   the code.
 2016-08-22 09:31:03 -07:00
Max Guglielmi d222f32674 Added comments to Storage for auto-generated documentation 2016-08-08 17:22:25 +10:00
Max Guglielmi fb56fab0c7 Added comments for autogenerated documentation (hash, help) 2016-07-23 18:34:19 +10:00
Archis Gore e1e56daac0 Ran full grunt - updated build dates apparently. 2016-07-14 21:03:45 -07:00
Archis Gore 21d45aa6b6 Removed whitespaces 2016-07-14 20:19:15 -07:00
Archis Gore 8d7a7d77e6 Responded to feedback 
1. Moved comment above a line to ensure that
   maximum line length of 80 characters is not breached.

2. Removed a mistaken ()=> which was left behind (that would have
   introduced the exact problem this change was intended to solve.)
 2016-07-14 15:11:58 -07:00
Archis Gore 86ef087310 Store the Sync wrapper in a variable for clean removal. 
This commit primarily fixes this issue:
https://github.com/koalyptus/TableFilter/issues/258

The fix here is to store a Sync call closed over "this" straight within
the object we're referencing. This having access to that object, we can
always retrieve the exact function reference/pointer/instance for removal
from handling events.
 2016-07-13 20:06:58 -07:00
Max Guglielmi 2e2515586e Refactored Event module 2016-06-02 14:13:56 +10:00
Max Guglielmi 0d58349432 Refactored types module 2016-05-15 12:56:12 +10:00
Max Guglielmi f67bb8e15c Added root module 2016-05-08 15:26:52 +10:00
Max Guglielmi 8c2108b3ab Added unit tests 2016-04-08 17:43:55 +02:00
Max Guglielmi df5cd45da1 Fixed hash deep linking on Firefox 2016-03-21 18:36:46 +11:00
Max Guglielmi 209d89582e Remove commented out code left-over 2016-03-21 09:25:17 +11:00
Max Guglielmi ea604b76ba Added state unit tests 2016-03-20 22:09:08 +11:00
Max Guglielmi 4a8613f68b Added comments 2016-03-20 19:56:18 +11:00
Max Guglielmi f45fae30ee Merged master in 2016-03-20 14:51:08 +11:00
Max Guglielmi 9e7253b0df Removed unused imports 2016-03-20 13:22:32 +11:00
Max Guglielmi a75e6902f8 splitted into state and hash modules 2016-03-20 01:10:59 +11:00