deblan-mirror/abraunegg-onedrive
deblan-mirror/abraunegg-onedrive
1
0
Fork 0
mirror of https://github.com/abraunegg/onedrive synced 2024-05-13 11:16:44 +02:00
Code Issues Projects Releases Wiki Activity

Add file validation for moved / renamed files (#929)

Browse source 
* When renaming a file locally, ensure that the target filename is valid before attempting to upload to OneDrive
This commit is contained in:
abraunegg 2020-05-25 10:51:57 +10:00 committed by GitHub
parent b9dd8c754d
commit 0096e7efce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 35 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
src/sync.d
View file

@ -4026,6 +4026,41 @@ final class SyncEngine
void uploadMoveItem(string from, string to)
{
log.log("Moving ", from, " to ", to);
// 'to' file validation .. is the 'to' file valid for upload?
if (isSymlink(to)) {
// if config says so we skip all symlinked items
if (cfg.getValueBool("skip_symlinks")) {
log.vlog("Skipping item - skip symbolic links configured: ", to);
return;
}
// skip unexisting symbolic links
else if (!exists(readLink(to))) {
log.log("Skipping item - invalid symbolic link: ", to);
return;
}
}
// Restriction and limitations about windows naming files
if (!isValidName(to)) {
log.log("Skipping item - invalid name (Microsoft Naming Convention): ", to);
return;
}
// Check for bad whitespace items
if (!containsBadWhiteSpace(to)) {
log.log("Skipping item - invalid name (Contains an invalid whitespace item): ", to);
return;
}
// Check for HTML ASCII Codes as part of file name
if (!containsASCIIHTMLCodes(to)) {
log.log("Skipping item - invalid name (Contains HTML ASCII Code): ", to);
return;
}
// 'to' file has passed file validation
Item fromItem, toItem, parentItem;
if (!itemdb.selectByPath(from, defaultDriveId, fromItem)) {
if (cfg.getValueBool("skip_dotfiles") && isDotFile(to)){