Merge remote-tracking branch 'upstream/master'

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,36 @@
+---
+name: Bug report
+about: Create a report to help us improve
+
+---
+
+### Bug Report Details ###
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**Application and Operating System Details:**
+ - OS: Output of `uname -a`
+- Application version: Output of `onedrive --version`
+
+**To Reproduce**
+Steps to reproduce the behavior if not causing an application crash:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+If issue is replicated by a specific 'file' or 'path' please archive the file and path tree & email to support@mynas.com.au 
+
+**Complete Verbose Log Output**
+A clear and full log of the problem. Please use 3 ` characters to format log output to make it easier to read. See https://guides.github.com/features/mastering-markdown/ for more details.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Additional context**
+Add any other context about the problem here.
+
+### Bug Report Checklist ###
+- [ ] Detailed description
+- [ ] Reproduction steps (if applicable)
+- [ ] Verbose Log Output

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,17 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

README.md

@@ -15,13 +15,16 @@
 ## Setup
 
 ### Build Requirements
-* Build environment must have at least 1GB of memory
+* Build environment must have at least 1GB of memory & 1GB swap space
 * [libcurl](http://curl.haxx.se/libcurl/)
 * [SQLite 3](https://www.sqlite.org/)
 * [Digital Mars D Compiler (DMD)](http://dlang.org/download.html)
 
+**Note:** 32Bit / i686 operating systems are not supported when using this client.
+
 ### Dependencies: Ubuntu/Debian
 ```sh
+sudo apt install build-essential
 sudo apt install libcurl4-openssl-dev
 sudo apt install libsqlite3-dev
 curl -fsS https://dlang.org/install.sh | bash -s dmd
@@ -64,8 +67,6 @@ Using a different compiler (for example [LDC](https://wiki.dlang.org/LDC)):
 make DC=ldmd2
 ```
 
-**Note:** 32Bit / i686 operating systems are not supported when using this client.
-
 ### First run :zap:
 After installing the application you must run it at least once from the terminal to authorize it.
 

src/qxor.d

@@ -2,7 +2,7 @@ import std.algorithm;
 import std.digest.digest;
 
 // implementation of the QuickXorHash algorithm in D
-// https://github.com/OneDrive/onedrive-api-docs/blob/master/snippets/quickxorhash.md
+// https://github.com/OneDrive/onedrive-api-docs/blob/live/docs/code-snippets/quickxorhash.md
 struct QuickXor
 {
 	private immutable int widthInBits = 160;
@@ -32,9 +32,9 @@ struct QuickXor
 			} else {
 				int index1 = vectorArrayIndex;
 				int index2 = isLastCell ? 0 : (vectorArrayIndex + 1);
-				byte low = cast(byte) (bitsInVectorCell - vectorOffset);
+				ubyte low = cast(ubyte) (bitsInVectorCell - vectorOffset);
 
-				byte xoredByte = 0;
+				ubyte xoredByte = 0;
 				for (size_t j = i; j < array.length; j += widthInBits) {
 					xoredByte ^= array[j];
 				}