deblan-mirror/abraunegg-onedrive
deblan-mirror/abraunegg-onedrive
1
0
Fork 0
mirror of https://github.com/abraunegg/onedrive synced 2024-05-15 12:16:49 +02:00
Code Issues Projects Releases Wiki Activity

Validate filename length before download to conform with Linux FS limits #142 (#180)

Browse source 
* Validate filename length before download to conform with Linux FS limits
This commit is contained in:
abraunegg 2018-10-04 09:31:28 +10:00 committed by GitHub
parent 2648612acd
commit 31fc6a4d4f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/sync.d
View file

@ -154,6 +154,8 @@ final class SyncEngine
private long remainingFreeSpace;
// is file malware flag
private bool malwareDetected = false;
// download filesystem issue flag
private bool downloadFailed = false;
this(Config cfg, OneDriveApi onedrive, ItemDatabase itemdb, SelectiveSync selectiveSync)
{
@ -534,6 +536,9 @@ final class SyncEngine
// Reset the malwareDetected flag for this item
malwareDetected = false;
// Reset the downloadFailed flag for this item
downloadFailed = false;
if (isItemRoot(driveItem) || !item.parentId || isRoot) {
item.parentId = null; // ensures that it has no parent
item.driveId = driveId; // HACK: makeItem() cannot set the driveId property of the root
@ -620,9 +625,10 @@ final class SyncEngine
applyNewItem(item, path);
}
if (malwareDetected == false){
if ((malwareDetected == false) && (downloadFailed == false)){
// save the item in the db
// if the file was detected as malware and NOT downloaded, we dont want to falsify the DB as downloading it as otherwise the next pass will think it was deleted, thus delete the remote item
// Likewise if the download failed, we dont want to falsify the DB as downloading it as otherwise the next pass will think it was deleted, thus delete the remote item
if (cached) {
itemdb.update(item);
} else {
@ -681,16 +687,13 @@ final class SyncEngine
// HACK: use mtime+hash instead of cTag because of https://github.com/OneDrive/onedrive-api-docs/issues/765
if (newItem.type == ItemType.file && oldItem.mtime != newItem.mtime && !testFileHash(newPath, newItem)) {
downloadFileItem(newItem, newPath);
} else {
//log.vlog("The item content has not changed");
}
}
// handle changed time
if (newItem.type == ItemType.file && oldItem.mtime != newItem.mtime) {
setTimes(newPath, newItem.mtime, newItem.mtime);
}
} else {
//log.vlog("", oldItem.name, " has not changed");
}
}
}
// downloads a File resource
@ -700,9 +703,6 @@ final class SyncEngine
write("Downloading file ", path, " ... ");
JSONValue fileDetails = onedrive.getFileDetails(item.driveId, item.id);
// Issue #153 Debugging
//log.log("File Details: ", fileDetails);
if (isMalware(fileDetails)){
// OneDrive reports that this file is malware
log.error("ERROR: MALWARE DETECTED IN FILE - DOWNLOAD SKIPPED");
@ -736,6 +736,11 @@ final class SyncEngine
}
}
}
} catch (std.exception.ErrnoException e) {
// There was a file system error
log.error("ERROR: ", e.msg);
downloadFailed = true;
return;
}
writeln("done.");
log.fileOnly("Downloading file ", path, " ... done.");