From 8f82919e5bd17c34e0d23c5890ed9ee0507a7ccd Mon Sep 17 00:00:00 2001
From: abraunegg <alex.braunegg@gmail.com>
Date: Sat, 24 May 2025 12:28:35 +1000
Subject: [PATCH] Only set xattr values when not using --dry-run (#3290)

* We can only set xattr values when not performing a --dry-run operation, as if we are doing --download-only --dry-run .. there is no file locally to set attributes on
---
 src/sync.d | 52 +++++++++++++++++++++++++++-------------------------
 1 file changed, 27 insertions(+), 25 deletions(-)

diff --git a/src/sync.d b/src/sync.d
index 17fbaecb..ff09a1f6 100644
--- a/src/sync.d
+++ b/src/sync.d
@@ -3918,33 +3918,35 @@ class SyncEngine {
 			displayFunctionProcessingStart(thisFunctionName, logKey);
 		}
 		
-		// This function will write the following xattr attributes based on the JSON data received from Microsoft onedrive
-		// - createdBy using the 'displayName' value
-		// - lastModifiedBy using the 'displayName' value
-		
-		string createdBy;
-		string lastModifiedBy;
-		
-		// Configure 'createdBy' from the JSON data
-		if (hasCreatedByUserDisplayName(onedriveJSONItem)) {
-			createdBy = onedriveJSONItem["createdBy"]["user"]["displayName"].str;
-		} else {
-			// required data not in JSON data
-			createdBy = "Unknown";
+		// We can only set xattr values when not performing a --dry-run operation
+		if (!dryRun) {
+			// This function will write the following xattr attributes based on the JSON data received from Microsoft onedrive
+			// - createdBy using the 'displayName' value
+			// - lastModifiedBy using the 'displayName' value
+			string createdBy;
+			string lastModifiedBy;
+			
+			// Configure 'createdBy' from the JSON data
+			if (hasCreatedByUserDisplayName(onedriveJSONItem)) {
+				createdBy = onedriveJSONItem["createdBy"]["user"]["displayName"].str;
+			} else {
+				// required data not in JSON data
+				createdBy = "Unknown";
+			}
+			
+			// Configure 'lastModifiedBy' from the JSON data
+			if (hasLastModifiedByUserDisplayName(onedriveJSONItem)) {
+				lastModifiedBy = onedriveJSONItem["lastModifiedBy"]["user"]["displayName"].str;
+			} else {
+				// required data not in JSON data
+				lastModifiedBy = "Unknown";
+			}
+			
+			// Set the xattr values
+			setXAttr(filePath, "user.onedrive.createdBy", createdBy);
+			setXAttr(filePath, "user.onedrive.lastModifiedBy", lastModifiedBy);
 		}
 		
-		// Configure 'lastModifiedBy' from the JSON data
-		if (hasLastModifiedByUserDisplayName(onedriveJSONItem)) {
-			lastModifiedBy = onedriveJSONItem["lastModifiedBy"]["user"]["displayName"].str;
-		} else {
-			// required data not in JSON data
-			lastModifiedBy = "Unknown";
-		}
-		
-		// Set the xattr values
-		setXAttr(filePath, "user.onedrive.createdBy", createdBy);
-		setXAttr(filePath, "user.onedrive.lastModifiedBy", lastModifiedBy);
-		
 		// Display function processing time if configured to do so
 		if (appConfig.getValueBool("display_processing_time") && debugLogging) {
 			// Combine module name & running Function