deblan-mirror/bold-brew
1
0
Fork 0
mirror of https://github.com/Valkyrie00/bold-brew.git synced 2026-03-14 14:25:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(brewfile): prevent duplicate packages in list after refresh

Browse source 
Add duplicate detection checks in loadBrewfilePackages to ensure each package appears only once in the Brewfile package list, even when refreshing after install/remove operations.
This commit is contained in:
Vito Castellano 2025-12-29 11:05:31 +01:00
commit be8ca02882
No known key found for this signature in database
GPG key ID: E13085DB38BC5819
1 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

12
internal/services/brewfile.go
View file

@ -99,7 +99,7 @@ func (s *AppService) loadBrewfilePackages() error {
}
}
// Track which packages were found in the main package list
// Track which packages were found (to avoid duplicates)
foundPackages := make(map[string]bool)
// Get actual installed packages (2 calls total, much faster than per-package checks)
@ -110,6 +110,10 @@ func (s *AppService) loadBrewfilePackages() error {
*s.brewfilePackages = []models.Package{}
for _, pkg := range *s.packages {
if pkgType, exists := packageMap[pkg.Name]; exists && pkgType == pkg.Type {
// Skip if already added (prevent duplicates)
if foundPackages[pkg.Name] {
continue
}
// Verify installation status against actual installed lists
if pkgType == models.PackageTypeCask {
pkg.LocallyInstalled = installedCasks[pkg.Name]
@ -140,14 +144,18 @@ func (s *AppService) loadBrewfilePackages() error {
// Use DataProvider to load tap packages (from cache only at startup, no fetch)
tapPackages, _ := s.dataProvider.LoadTapPackages(tapEntries, existingPackages, false)
// Add tap packages to brewfilePackages, updating installed status
// Add tap packages to brewfilePackages, updating installed status (avoid duplicates)
for _, pkg := range tapPackages {
if foundPackages[pkg.Name] {
continue // Already added
}
if pkg.Type == models.PackageTypeCask {
pkg.LocallyInstalled = installedCasks[pkg.Name]
} else {
pkg.LocallyInstalled = installedFormulae[pkg.Name]
}
*s.brewfilePackages = append(*s.brewfilePackages, pkg)
foundPackages[pkg.Name] = true
}
}