1 commit

Author	SHA1	Message	Date
Vito Castellano	e234487ac9	refactor(services): restructure and simplify service layer (#46) ... * refactor(services): split brew.go into focused modules Reorganize the services package for better maintainability: - brew.go: Interface and struct definitions - data.go: Data loading, caching, and tap package management - cache.go: Low-level cache I/O helpers - packages.go: Package retrieval (GetFormulae, GetPackages) - operations.go: Package operations (install, update, remove) - parser.go: Brewfile parsing - brewfile.go: Brewfile-specific app logic (extracted from app.go) This reduces the largest file from 1124 to 322 lines and improves separation of concerns across the codebase. * refactor(services): introduce DataProvider pattern for data loading Extract data loading logic into a dedicated DataProvider service that handles all data retrieval operations (formulae, casks, analytics, cache). BrewService now delegates to DataProvider via interface for better testability and separation of concerns. Also centralizes cache file name constants in dataprovider.go for maintainability. * refactor(services): centralize data in DataProvider and improve naming consistency Move all data-related fields and retrieval methods from BrewService to DataProvider, making BrewService focused solely on brew operations. Rename formula fields (all, installed, remote, analytics) to be consistent with cask naming convention (allFormulae, installedFormulae, etc.). Remove redundant data.go and packages.go files. * refactor(services): consolidate code and fix shared dependencies - IOService now receives BrewService as parameter instead of creating new instance - Move API URL constants from brew.go to dataprovider.go (now private) - Move getCacheDir to cache.go where it belongs - Remove unused GetPrefixPath from BrewService interface - Consolidate Brewfile parsing into brewfile.go as standalone function - Delete parser.go (logic merged into brewfile.go) * fix(brewfile): prevent duplicate packages in list after refresh Add duplicate detection checks in loadBrewfilePackages to ensure each package appears only once in the Brewfile package list, even when refreshing after install/remove operations. * refactor(services): extract search methods to dedicated file Move search(), setResults(), and forceRefreshResults() from app.go to search.go for better code organization and separation of concerns. * refactor(services): remove dead code and unify helpers Remove unused methods and fields: - GetFormulae(), IsPackageInstalled() from DataProvider - InstallAllPackages(), RemoveAllPackages() from BrewService - allFormulae, allCasks fields from DataProvider Unify GetInstalledCaskNames and GetInstalledFormulaNames with a common getInstalledNames helper to reduce code duplication. * docs(brewfile): add package documentation with execution sequence Document Brewfile mode functionality including parsing, tap installation, and package loading. Add execution sequence diagram and note that methods are only active in Brewfile mode (bbrew -f <file>). * refactor(services): move fetchFromAPI to dataprovider Move HTTP fetch function from cache.go to dataprovider.go where it belongs semantically. cache.go now contains only cache I/O operations. * refactor(dataprovider): improve method naming consistency Rename Load* methods to Get* with forceRefresh parameter for clarity: - LoadInstalledFormulae → GetInstalledFormulae - LoadRemoteFormulae → GetRemoteFormulae - LoadTapPackages → GetTapPackages (and similar) Rename Get* methods that execute commands to Fetch* for accuracy: - GetInstalledCaskNames → FetchInstalledCaskNames - GetInstalledFormulaNames → FetchInstalledFormulaNames Replace forceDownload parameter with forceRefresh throughout. * refactor(input): rename io.go to input.go and simplify code Rename IOService/IOAction to InputService/InputAction for semantic correctness (io in Go refers to file I/O, not keyboard input). Simplify handleFilterEvent with helper methods: isFilterActive(), setFilterActive(), updateFilterUI() reducing ~30 lines of repetitive code. Extract handleBatchPackageOperation() helper for InstallAll/RemoveAll operations, reducing ~90 lines of duplicate code with a configurable batchOperation struct. * refactor(filters): replace 4 booleans with FilterType enum Replace showOnlyInstalled, showOnlyOutdated, showOnlyLeaves, showOnlyCasks with a single activeFilter field of type FilterType. Add FilterNone constant for no active filter state. Simplify handleFilterEvent to simple toggle logic. Extract applyFilter method with clean switch statement. Remove redundant isFilterActive and setFilterActive helpers. * refactor(brew): merge operations.go into brew.go Consolidate all BrewService methods into a single file. Add section comments to organize code into logical groups: - Core info (GetBrewVersion) - Package operations (Update/Install/Remove) - Tap support (InstallTap/IsTapInstalled) - Internal helpers (executeCommand) * fix(dataprovider): suppress gosec G107 false positive The URL passed to http.Get comes from internal constants (Homebrew API URLs), not from user input.	2025-12-29 14:32:25 +01:00