From fd3459eb02b9c1cb59f674c22e42354f37b6f504 Mon Sep 17 00:00:00 2001 From: Alex Goodman Date: Mon, 7 Oct 2019 18:28:44 -0400 Subject: [PATCH] fix validation errors --- cmd/root.go | 2 +- dive/image/podman/resolver.go | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/cmd/root.go b/cmd/root.go index 41abe52..877bca7 100644 --- a/cmd/root.go +++ b/cmd/root.go @@ -57,7 +57,7 @@ func initCli() { for _, key := range []string{"lowestEfficiency", "highestWastedBytes", "highestUserWastedPercent"} { if err := ciConfig.BindPFlag(fmt.Sprintf("rules.%s", key), rootCmd.Flags().Lookup(key)); err != nil { - log.Fatal("Unable to bind '%s' flag:", key, err) + log.Fatalf("Unable to bind '%s' flag: %v", key, err) } } diff --git a/dive/image/podman/resolver.go b/dive/image/podman/resolver.go index 37f5253..83e8a12 100644 --- a/dive/image/podman/resolver.go +++ b/dive/image/podman/resolver.go @@ -84,6 +84,9 @@ func (r *resolver) resolveFromDockerArchive(id string) (*image.Image, error) { defer os.Remove(path) file, err := os.Open(path) + if err != nil { + return nil, err + } defer file.Close() img, err := docker.NewImageArchive(ioutil.NopCloser(bufio.NewReader(file)))