Upgarde to use gh (#624)

This commit is contained in:
Sung 2023-02-11 17:35:41 +11:00 committed by GitHub
commit 4978e57fbe
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 12 deletions

View file

@ -1,5 +1,5 @@
NPM := $(shell command -v npm 2> /dev/null)
HUB := $(shell command -v hub 2> /dev/null)
GH := $(shell command -v gh 2> /dev/null)
currentDir = $(shell pwd)
serverOutputDir = ${currentDir}/build/server
@ -84,8 +84,8 @@ release-cli: clean build-cli
ifndef version
$(error version is required. Usage: make version=0.1.0 release-cli)
endif
ifndef HUB
$(error please install hub)
ifndef GH
$(error please install github-cli)
endif
if [ ! -d ${cliHomebrewDir} ]; then \
@ -96,7 +96,7 @@ endif
@echo "==> releasing cli"
@${currentDir}/scripts/release.sh cli $(version) ${cliOutputDir}
@echo "===> releading on Homebrew"
@echo "===> releasing on Homebrew"
@(cd "${cliHomebrewDir}" && \
./release.sh "$(version)" "${cliOutputDir}/dnote_$(version)_darwin_amd64.tar.gz")
.PHONY: release-cli
@ -105,8 +105,8 @@ release-server:
ifndef version
$(error version is required. Usage: make version=0.1.0 release-server)
endif
ifndef HUB
$(error please install hub)
ifndef GH
$(error please install github-cli)
endif
@echo "==> releasing server"

View file

@ -34,7 +34,7 @@ git push --tags
files=("$assetPath"/*)
file_flags=()
for file in "${files[@]}"; do
file_flags+=("--attach=$file")
file_flags+=("$file")
done
# mark as prerelease if version is not in a form of major.minor.patch
@ -47,10 +47,11 @@ fi
echo "* creating release"
set -x
# first message is the title and the following are body in markdown
hub release create \
# Create release
gh release create \
"$version_tag" \
"${file_flags[@]}" \
"${flags[@]}" \
--message="$version_tag"\
--message="Please see the [CHANGELOG](https://github.com/dnote/dnote/blob/master/CHANGELOG.md)" \
"$version_tag"
--title="$version_tag"\
--notes="Please see the [CHANGELOG](https://github.com/dnote/dnote/blob/master/CHANGELOG.md)" \
--draft