From 143a539e01c2294d8e25b73a735fa038874259e8 Mon Sep 17 00:00:00 2001 From: Tomoyuki Hata Date: Fri, 19 Feb 2021 00:51:03 +0900 Subject: [PATCH] Fix unstable block cut process (#1485) * Fix unstable block cut process * Update CHANGELOG Co-authored-by: Peter Savchenko --- docs/CHANGELOG.md | 1 + src/components/modules/blockEvents.ts | 8 ++++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 09908483..638cc2c3 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -7,6 +7,7 @@ - `Improvements` - Remove bundles from the repo [#1541](https://github.com/codex-team/editor.js/pull/1541). - `Improvements` - Document will be scrolled when blocks are selected with `SHIFT+UP` or `SHIFT+DOWN` [#1447](https://github.com/codex-team/editor.js/issues/1447) - `Fix` - Fix BlockManager.setCurrentBlockByChildNode() with multiple Editor.js instances [#1503](https://github.com/codex-team/editor.js/issues/1503). +- `Fix` - Fix an unstable block cut process [#1489](https://github.com/codex-team/editor.js/issues/1489). - `Fix` - Type definition of the Sanitizer config: the sanitize function now contains param definition [#1491](https://github.com/codex-team/editor.js/pull/1491). ### 2.19.1 diff --git a/src/components/modules/blockEvents.ts b/src/components/modules/blockEvents.ts index 4da4c921..a2b8d661 100644 --- a/src/components/modules/blockEvents.ts +++ b/src/components/modules/blockEvents.ts @@ -167,7 +167,7 @@ export default class BlockEvents extends Module { * * @param {ClipboardEvent} event - clipboard event */ - public handleCommandC(event: ClipboardEvent): void { + public handleCommandC(event: ClipboardEvent): Promise { const { BlockSelection } = this.Editor; if (!BlockSelection.anyBlockSelected) { @@ -175,7 +175,7 @@ export default class BlockEvents extends Module { } // Copy Selected Blocks - BlockSelection.copySelectedBlocks(event); + return BlockSelection.copySelectedBlocks(event); } /** @@ -183,14 +183,14 @@ export default class BlockEvents extends Module { * * @param {ClipboardEvent} event - clipboard event */ - public handleCommandX(event: ClipboardEvent): void { + public async handleCommandX(event: ClipboardEvent): Promise { const { BlockSelection, BlockManager, Caret } = this.Editor; if (!BlockSelection.anyBlockSelected) { return; } - BlockSelection.copySelectedBlocks(event); + await BlockSelection.copySelectedBlocks(event); const selectionPositionIndex = BlockManager.removeSelectedBlocks();