From 494d6e4b9bf877b53c2bad6077a59b5cb7d36ec3 Mon Sep 17 00:00:00 2001 From: ferntheplant <60588558+ferntheplant@users.noreply.github.com> Date: Tue, 5 Dec 2023 11:26:10 -0500 Subject: [PATCH] fix: use type imports for block events (#2491) * fix: use type imports for block events * add changelog entry --------- Co-authored-by: Peter Savchenko --- docs/CHANGELOG.md | 1 + types/events/block/Base.ts | 2 +- types/events/block/BlockAdded.ts | 2 +- types/events/block/BlockChanged.ts | 2 +- types/events/block/BlockMoved.ts | 2 +- types/events/block/BlockRemoved.ts | 2 +- types/events/block/index.ts | 8 ++++---- 7 files changed, 10 insertions(+), 9 deletions(-) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index d2e16763..9216359e 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -7,6 +7,7 @@ - `Fix` — Layout did not shrink when a large document cleared in Chrome - `Fix` — Multiple Tooltip elements creation fixed - `Fix` — When the focusing Block is out of the viewport, the page will be scrolled. +- `Fix` - Compiler error "This import is never used as a value and must use 'import type'..." fixed - `Fix` — `blocks.render()` won't lead the `onChange` call in Safari - `Fix` — Editor wrapper element growing on the Inline Toolbar close - `Fix` — Fix errors thrown by clicks on a document when the editor is being initialized diff --git a/types/events/block/Base.ts b/types/events/block/Base.ts index f8be5aee..6059d14b 100644 --- a/types/events/block/Base.ts +++ b/types/events/block/Base.ts @@ -1,4 +1,4 @@ -import { BlockAPI } from '../../api'; +import type { BlockAPI } from '../../api'; /** * Details of CustomEvent fired on block mutation diff --git a/types/events/block/BlockAdded.ts b/types/events/block/BlockAdded.ts index 9f230209..4be1311e 100644 --- a/types/events/block/BlockAdded.ts +++ b/types/events/block/BlockAdded.ts @@ -1,4 +1,4 @@ -import { BlockMutationEventDetail } from './Base'; +import type { BlockMutationEventDetail } from './Base'; /** * Type name of CustomEvent related to block added event diff --git a/types/events/block/BlockChanged.ts b/types/events/block/BlockChanged.ts index ad556d32..dfd02daa 100644 --- a/types/events/block/BlockChanged.ts +++ b/types/events/block/BlockChanged.ts @@ -1,4 +1,4 @@ -import { BlockMutationEventDetail } from './Base'; +import type { BlockMutationEventDetail } from './Base'; /** * Type name of CustomEvent related to block changed event diff --git a/types/events/block/BlockMoved.ts b/types/events/block/BlockMoved.ts index 1860861a..26cf4c4d 100644 --- a/types/events/block/BlockMoved.ts +++ b/types/events/block/BlockMoved.ts @@ -1,4 +1,4 @@ -import { BlockMutationEventDetail } from './Base'; +import type { BlockMutationEventDetail } from './Base'; /** * Type name of CustomEvent related to block moved event diff --git a/types/events/block/BlockRemoved.ts b/types/events/block/BlockRemoved.ts index 7e51442e..e7bb2e8b 100644 --- a/types/events/block/BlockRemoved.ts +++ b/types/events/block/BlockRemoved.ts @@ -1,4 +1,4 @@ -import { BlockMutationEventDetail } from './Base'; +import type { BlockMutationEventDetail } from './Base'; /** * Type name of CustomEvent related to block removed event diff --git a/types/events/block/index.ts b/types/events/block/index.ts index 9908b3bc..3c4c20c1 100644 --- a/types/events/block/index.ts +++ b/types/events/block/index.ts @@ -1,7 +1,7 @@ -import { BlockAddedEvent, BlockAddedMutationType } from './BlockAdded'; -import { BlockChangedEvent, BlockChangedMutationType } from './BlockChanged'; -import { BlockMovedEvent, BlockMovedMutationType } from './BlockMoved'; -import { BlockRemovedEvent, BlockRemovedMutationType } from './BlockRemoved'; +import { type BlockAddedEvent, BlockAddedMutationType } from './BlockAdded'; +import { type BlockChangedEvent, BlockChangedMutationType } from './BlockChanged'; +import { type BlockMovedEvent, BlockMovedMutationType } from './BlockMoved'; +import { type BlockRemovedEvent, BlockRemovedMutationType } from './BlockRemoved'; /** * Map for Custom Events related to block mutation types