mirror of
https://github.com/codex-team/editor.js
synced 2024-05-07 00:46:45 +02:00
581289c03e
* Default tunes to popover * Add the rest of default tunes * Add popover * Cleanup * Rename custom content * Cleanup * Add ability to open block settings upwards * Fix tests * Cleanup default tunes * Rename and cleanup * Add ability to display rendered custom tunes * cleanup * Rename * Add flag to close tunes popover * Cleanup * i18n * Cleanup * Fix build and tests * Fix for iframe * Add comments * Display active item, move closeOnActivate to popover * Add confirmation support to popover * Handle boolean value in confirmation param * Clarify flippable logic in popover * Comments * Pass editor element as a param of popover constructor * Fix readability * Tests * Fix flipper for confirmation element * Update confirmation config structure * Rename onClick to onActivate * Fix tests and build * Make confirmation props optional * Simplify processing tunes * Renamings * Fix text block tunes * Docs * Update event type * Move enabling confirmation state to separate method * move popover types * Unhardcode color * Support toggling * Add support of disabled items * Fix tab in empty block leading to selecting second item in popover * Remove margins for styles api settings button class * Fix arrow navigation between blocks after opening block tunes * Cleaup in default tunes code * Fix chaining confirmations * Colors * Types * Change the way flippable elements of popover custom area are set * Remove borders around popover icons * Fix untabbable inline toolbar * Fix locked scroll after closing tunes popover on mobile * Cleanup * Set max popover width * Make popover icon's border outside * Fix tab issue * Fix focus/hover issue * Reformat * Cleanup * Fix opening block tunes via keyboard * Add disableSpecialHoverAndFocusBehavior * Add deprecated comment * Cleanup * Fix popover active state * Fix checklist deletion with confirmation * Fix checklist deletion 2 * Fix popover focus * Fix popover items being impossible to flip after searching * Fix popover item highlighting issue * Update flipper.spec.ts * Fixes after review * Add Tunes Api tests * Fix multiple popover entries configured by one tune * Add tool's renderSettings() tests * Add popover confirmation state test * Fix popover width on mobile * Add popover tests * Add changelog and update version * Update changelog * Fix block tunes being unable to open after tune activation Co-authored-by: Peter Savchenko <specc.dev@gmail.com>
494 lines
13 KiB
TypeScript
494 lines
13 KiB
TypeScript
import { ToolboxConfig, BlockToolData, ToolboxConfigEntry } from '../../../../types';
|
|
import { TunesMenuConfig } from '../../../../types/tools';
|
|
|
|
/* eslint-disable @typescript-eslint/no-empty-function */
|
|
|
|
const ICON = '<svg width="17" height="15" viewBox="0 0 336 276" xmlns="http://www.w3.org/2000/svg"><path d="M291 150V79c0-19-15-34-34-34H79c-19 0-34 15-34 34v42l67-44 81 72 56-29 42 30zm0 52l-43-30-56 30-81-67-66 39v23c0 19 15 34 34 34h178c17 0 31-13 34-29zM79 0h178c44 0 79 35 79 79v118c0 44-35 79-79 79H79c-44 0-79-35-79-79V79C0 35 35 0 79 0z"></path></svg>';
|
|
|
|
describe('Editor Tools Api', () => {
|
|
context('Toolbox', () => {
|
|
it('should render a toolbox entry for tool if configured', () => {
|
|
/**
|
|
* Tool with single toolbox entry configured
|
|
*/
|
|
class TestTool {
|
|
/**
|
|
* Returns toolbox config as list of entries
|
|
*/
|
|
public static get toolbox(): ToolboxConfigEntry {
|
|
return {
|
|
title: 'Entry 1',
|
|
icon: ICON,
|
|
};
|
|
}
|
|
}
|
|
|
|
cy.createEditor({
|
|
tools: {
|
|
testTool: TestTool,
|
|
},
|
|
}).as('editorInstance');
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-block')
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-toolbar__plus')
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-popover__item[data-item-name=testTool]')
|
|
.should('have.length', 1);
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-popover__item[data-item-name=testTool] .ce-popover__item-icon')
|
|
.should('contain.html', TestTool.toolbox.icon);
|
|
});
|
|
|
|
it('should render several toolbox entries for one tool if configured', () => {
|
|
/**
|
|
* Tool with several toolbox entries configured
|
|
*/
|
|
class TestTool {
|
|
/**
|
|
* Returns toolbox config as list of entries
|
|
*/
|
|
public static get toolbox(): ToolboxConfig {
|
|
return [
|
|
{
|
|
title: 'Entry 1',
|
|
icon: ICON,
|
|
},
|
|
{
|
|
title: 'Entry 2',
|
|
icon: ICON,
|
|
},
|
|
];
|
|
}
|
|
}
|
|
|
|
cy.createEditor({
|
|
tools: {
|
|
testTool: TestTool,
|
|
},
|
|
}).as('editorInstance');
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-block')
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-toolbar__plus')
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-popover__item[data-item-name=testTool]')
|
|
.should('have.length', 2);
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-popover__item[data-item-name=testTool]')
|
|
.first()
|
|
.should('contain.text', TestTool.toolbox[0].title);
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-popover__item[data-item-name=testTool]')
|
|
.last()
|
|
.should('contain.text', TestTool.toolbox[1].title);
|
|
});
|
|
|
|
it('should insert block with overriden data on entry click in case toolbox entry provides data overrides', () => {
|
|
const text = 'Text';
|
|
const dataOverrides = {
|
|
testProp: 'new value',
|
|
};
|
|
|
|
/**
|
|
* Tool with default data to be overriden
|
|
*/
|
|
class TestTool {
|
|
private _data = {
|
|
testProp: 'default value',
|
|
}
|
|
|
|
/**
|
|
* Tool contructor
|
|
*
|
|
* @param data - previously saved data
|
|
*/
|
|
constructor({ data }) {
|
|
this._data = data;
|
|
}
|
|
|
|
/**
|
|
* Returns toolbox config as list of entries with overriden data
|
|
*/
|
|
public static get toolbox(): ToolboxConfig {
|
|
return [
|
|
{
|
|
title: 'Entry 1',
|
|
icon: ICON,
|
|
data: dataOverrides,
|
|
},
|
|
];
|
|
}
|
|
|
|
/**
|
|
* Return Tool's view
|
|
*/
|
|
public render(): HTMLElement {
|
|
const wrapper = document.createElement('div');
|
|
|
|
wrapper.setAttribute('contenteditable', 'true');
|
|
|
|
return wrapper;
|
|
}
|
|
|
|
/**
|
|
* Extracts Tool's data from the view
|
|
*
|
|
* @param el - tool view
|
|
*/
|
|
public save(el: HTMLElement): BlockToolData {
|
|
return {
|
|
...this._data,
|
|
text: el.innerHTML,
|
|
};
|
|
}
|
|
}
|
|
|
|
cy.createEditor({
|
|
tools: {
|
|
testTool: TestTool,
|
|
},
|
|
}).as('editorInstance');
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-block')
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-toolbar__plus')
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-popover__item[data-item-name=testTool]')
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-block')
|
|
.last()
|
|
.click()
|
|
.type(text);
|
|
|
|
cy.get('@editorInstance')
|
|
.then(async (editor: any) => {
|
|
const editorData = await editor.save();
|
|
|
|
expect(editorData.blocks[0].data).to.be.deep.eq({
|
|
...dataOverrides,
|
|
text,
|
|
});
|
|
});
|
|
});
|
|
|
|
it('should not display tool in toolbox if the tool has single toolbox entry configured and it has icon missing', () => {
|
|
/**
|
|
* Tool with one of the toolbox entries with icon missing
|
|
*/
|
|
class TestTool {
|
|
/**
|
|
* Returns toolbox config as list of entries one of which has missing icon
|
|
*/
|
|
public static get toolbox(): ToolboxConfig {
|
|
return {
|
|
title: 'Entry 2',
|
|
};
|
|
}
|
|
}
|
|
|
|
cy.createEditor({
|
|
tools: {
|
|
testTool: TestTool,
|
|
},
|
|
}).as('editorInstance');
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-block')
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-toolbar__plus')
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-popover__item[data-item-name=testTool]')
|
|
.should('not.exist');
|
|
});
|
|
|
|
it('should skip toolbox entries that have no icon', () => {
|
|
const skippedEntryTitle = 'Entry 2';
|
|
|
|
/**
|
|
* Tool with one of the toolbox entries with icon missing
|
|
*/
|
|
class TestTool {
|
|
/**
|
|
* Returns toolbox config as list of entries one of which has missing icon
|
|
*/
|
|
public static get toolbox(): ToolboxConfig {
|
|
return [
|
|
{
|
|
title: 'Entry 1',
|
|
icon: ICON,
|
|
},
|
|
{
|
|
title: skippedEntryTitle,
|
|
},
|
|
];
|
|
}
|
|
}
|
|
|
|
cy.createEditor({
|
|
tools: {
|
|
testTool: TestTool,
|
|
},
|
|
}).as('editorInstance');
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-block')
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-toolbar__plus')
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-popover__item[data-item-name=testTool]')
|
|
.should('have.length', 1)
|
|
.should('not.contain', skippedEntryTitle);
|
|
});
|
|
});
|
|
|
|
context('Tunes', () => {
|
|
it('should contain a single block tune configured in tool\'s renderSettings() method', () => {
|
|
/** Tool with single tunes menu entry configured */
|
|
class TestTool {
|
|
/** Returns toolbox config as list of entries */
|
|
public static get toolbox(): ToolboxConfigEntry {
|
|
return {
|
|
title: 'Test tool',
|
|
icon: ICON,
|
|
};
|
|
}
|
|
|
|
/** Returns configuration for block tunes menu */
|
|
public renderSettings(): TunesMenuConfig {
|
|
return {
|
|
label: 'Test tool tune',
|
|
icon: ICON,
|
|
name: 'testToolTune',
|
|
|
|
onActivate: (): void => {},
|
|
};
|
|
}
|
|
|
|
/** Save method stub */
|
|
public save(): void {}
|
|
|
|
/** Renders a block */
|
|
public render(): HTMLElement {
|
|
const element = document.createElement('div');
|
|
|
|
element.contentEditable = 'true';
|
|
element.setAttribute('data-name', 'testBlock');
|
|
|
|
return element;
|
|
}
|
|
}
|
|
|
|
cy.createEditor({
|
|
tools: {
|
|
testTool: TestTool,
|
|
},
|
|
}).as('editorInstance');
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-block')
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-toolbar__plus')
|
|
.click();
|
|
|
|
// Insert test tool block
|
|
cy.get('[data-cy=editorjs]')
|
|
.get(`[data-item-name="testTool"]`)
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('[data-name=testBlock]')
|
|
.type('some text')
|
|
.click();
|
|
|
|
// Open block tunes
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('.ce-toolbar__settings-btn')
|
|
.click();
|
|
|
|
// Expect preconfigured tune to exist in tunes menu
|
|
cy.get('[data-item-name=testToolTune]').should('exist');
|
|
});
|
|
|
|
it('should contain multiple block tunes if configured in tool\'s renderSettings() method', () => {
|
|
/** Tool with single tunes menu entry configured */
|
|
class TestTool {
|
|
/** Returns toolbox config as list of entries */
|
|
public static get toolbox(): ToolboxConfigEntry {
|
|
return {
|
|
title: 'Test tool',
|
|
icon: ICON,
|
|
};
|
|
}
|
|
|
|
/** Returns configuration for block tunes menu */
|
|
public renderSettings(): TunesMenuConfig {
|
|
return [
|
|
{
|
|
label: 'Test tool tune 1',
|
|
icon: ICON,
|
|
name: 'testToolTune1',
|
|
|
|
onActivate: (): void => {},
|
|
},
|
|
{
|
|
label: 'Test tool tune 2',
|
|
icon: ICON,
|
|
name: 'testToolTune2',
|
|
|
|
onActivate: (): void => {},
|
|
},
|
|
];
|
|
}
|
|
|
|
/** Save method stub */
|
|
public save(): void {}
|
|
|
|
/** Renders a block */
|
|
public render(): HTMLElement {
|
|
const element = document.createElement('div');
|
|
|
|
element.contentEditable = 'true';
|
|
element.setAttribute('data-name', 'testBlock');
|
|
|
|
return element;
|
|
}
|
|
}
|
|
|
|
cy.createEditor({
|
|
tools: {
|
|
testTool: TestTool,
|
|
},
|
|
}).as('editorInstance');
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-block')
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-toolbar__plus')
|
|
.click();
|
|
|
|
// Insert test tool block
|
|
cy.get('[data-cy=editorjs]')
|
|
.get(`[data-item-name="testTool"]`)
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('[data-name=testBlock]')
|
|
.type('some text')
|
|
.click();
|
|
|
|
// Open block tunes
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('.ce-toolbar__settings-btn')
|
|
.click();
|
|
|
|
// Expect preconfigured tunes to exist in tunes menu
|
|
cy.get('[data-item-name=testToolTune1]').should('exist');
|
|
cy.get('[data-item-name=testToolTune2]').should('exist');
|
|
});
|
|
|
|
it('should contain block tunes represented as custom html if so configured in tool\'s renderSettings() method', () => {
|
|
const sampleText = 'sample text';
|
|
|
|
/** Tool with single tunes menu entry configured */
|
|
class TestTool {
|
|
/** Returns toolbox config as list of entries */
|
|
public static get toolbox(): ToolboxConfigEntry {
|
|
return {
|
|
title: 'Test tool',
|
|
icon: ICON,
|
|
};
|
|
}
|
|
|
|
/** Returns configuration for block tunes menu */
|
|
public renderSettings(): HTMLElement {
|
|
const element = document.createElement('div');
|
|
|
|
element.textContent = sampleText;
|
|
|
|
return element;
|
|
}
|
|
|
|
/** Save method stub */
|
|
public save(): void {}
|
|
|
|
/** Renders a block */
|
|
public render(): HTMLElement {
|
|
const element = document.createElement('div');
|
|
|
|
element.contentEditable = 'true';
|
|
element.setAttribute('data-name', 'testBlock');
|
|
|
|
return element;
|
|
}
|
|
}
|
|
|
|
cy.createEditor({
|
|
tools: {
|
|
testTool: TestTool,
|
|
},
|
|
}).as('editorInstance');
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-block')
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('div.ce-toolbar__plus')
|
|
.click();
|
|
|
|
// Insert test tool block
|
|
cy.get('[data-cy=editorjs]')
|
|
.get(`[data-item-name="testTool"]`)
|
|
.click();
|
|
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('[data-name=testBlock]')
|
|
.type('some text')
|
|
.click();
|
|
|
|
// Open block tunes
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('.ce-toolbar__settings-btn')
|
|
.click();
|
|
|
|
// Expect preconfigured custom html tunes to exist in tunes menu
|
|
cy.get('[data-cy=editorjs]')
|
|
.get('.ce-popover')
|
|
.should('contain.text', sampleText);
|
|
});
|
|
});
|
|
});
|