deblan-mirror/lego
1
0
Fork 0
mirror of https://github.com/go-acme/lego synced 2026-03-14 14:35:48 +01:00
Code Issues Projects Releases Packages Wiki Activity

review

Browse source
This commit is contained in:
Fernandez Ludovic 2026-02-25 00:54:02 +01:00
commit 1d80d304d1
3 changed files with 17 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

7
challenge/dnspersist01/precheck.go
View file

@ -37,10 +37,10 @@ func DisableAuthoritativeNssPropagationRequirement() ChallengeOption {
}
}
// RecursiveNSsPropagationRequirement requires checks against recursive nameservers.
func RecursiveNSsPropagationRequirement() ChallengeOption {
// DisableRecursiveNSsPropagationRequirement disables recursive nameserver checks.
func DisableRecursiveNSsPropagationRequirement() ChallengeOption {
return func(chlg *Challenge) error {
chlg.preCheck.requireRecursiveNssPropagation = true
chlg.preCheck.requireRecursiveNssPropagation = false
return nil
}
}
@ -80,6 +80,7 @@ type preCheck struct {
func newPreCheck() preCheck {
return preCheck{
requireAuthoritativeNssPropagation: true,
requireRecursiveNssPropagation: true,
}
}

22
cmd/flags.go
View file

@ -131,14 +131,14 @@ const (
// Flag names related to the DNS-PERSIST-01 challenge.
const (
flgDNSPersist = "dns-persist"
flgDNSPersistIssuerDomainName = "dns-persist.issuer-domain-name"
flgDNSPersistPersistUntil = "dns-persist.persist-until"
flgDNSPersistPropagationWait = "dns-persist.propagation.wait"
flgDNSPersistPropagationDisableANS = "dns-persist.propagation.disable-ans"
flgDNSPersistPropagationRNS = "dns-persist.propagation.rns"
flgDNSPersistResolvers = "dns-persist.resolvers"
flgDNSPersistTimeout = "dns-persist.timeout"
flgDNSPersist = "dns-persist"
flgDNSPersistIssuerDomainName = "dns-persist.issuer-domain-name"
flgDNSPersistPersistUntil = "dns-persist.persist-until"
flgDNSPersistPropagationWait = "dns-persist.propagation.wait"
flgDNSPersistPropagationDisableANS = "dns-persist.propagation.disable-ans"
flgDNSSPersistPropagationDisableRNS = "dns-persist.propagation.disable-rns"
flgDNSPersistResolvers = "dns-persist.resolvers"
flgDNSPersistTimeout = "dns-persist.timeout"
)
// Flags names related to hooks.
@ -465,9 +465,9 @@ func createDNSPersistChallengeFlags() []cli.Flag {
},
&cli.BoolFlag{
Category: categoryDNSPersist01Challenge,
Name: flgDNSPersistPropagationRNS,
Sources: cli.EnvVars(toEnvName(flgDNSPersistPropagationRNS)),
Usage: "By setting this flag to true, uses all the recursive name servers (aka resolvers) to check propagation of the TXT record.",
Name: flgDNSSPersistPropagationDisableRNS,
Sources: cli.EnvVars(toEnvName(flgDNSSPersistPropagationDisableRNS)),
Usage: "By setting this flag to true, disables the need to await propagation of the TXT record to all recursive name servers (aka resolvers).",
},
&cli.StringSliceFlag{
Category: categoryDNSPersist01Challenge,

4
cmd/setup_challenges.go
View file

@ -243,8 +243,8 @@ func setupDNSPersist(cmd *cli.Command, client *lego.Client, account registration
dnspersist01.CondOptions(cmd.Bool(flgDNSPersistPropagationDisableANS),
dnspersist01.DisableAuthoritativeNssPropagationRequirement(),
),
dnspersist01.CondOptions(cmd.Bool(flgDNSPersistPropagationRNS),
dnspersist01.RecursiveNSsPropagationRequirement(),
dnspersist01.CondOptions(cmd.Bool(flgDNSSPersistPropagationDisableRNS),
dnspersist01.DisableRecursiveNSsPropagationRequirement(),
),
),
)