deblan-mirror/lego
1
0
Fork 0
mirror of https://github.com/go-acme/lego synced 2026-03-14 14:35:48 +01:00
Code Issues Projects Releases Packages Wiki Activity

Address Pointer comments

Browse source
This commit is contained in:
Samantha 2026-02-24 14:14:05 -05:00
commit 53aa475aa8
1 changed files with 7 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

15
challenge/dnspersist01/dns_persist_challenge_test.go
View file

@ -103,7 +103,7 @@ func TestGetChallengeInfo(t *testing.T) {
issuerDomainName: "authority.example",
accountURI: "https://ca.example/acct/123",
wildcard: true,
persistUntil: ptrTime(time.Unix(4102444800, 0).UTC()),
persistUntil: Pointer(time.Unix(4102444800, 0).UTC()),
expected: ChallengeInfo{
FQDN: "_validation-persist.example.com.",
Value: "authority.example; accounturi=https://ca.example/acct/123; policy=wildcard; persistUntil=4102444800",
@ -396,28 +396,28 @@ func TestChallenge_hasMatchingRecord(t *testing.T) {
desc: "required persistUntil matches",
records: []TXTRecord{{Value: "ca.example;accounturi=acc;persistUntil=4102444800"}},
issuer: "ca.example",
requiredPersistUTC: ptrTime(time.Unix(4102444800, 0).UTC()),
requiredPersistUTC: Pointer(time.Unix(4102444800, 0).UTC()),
expect: true,
},
{
desc: "required persistUntil matches even when expired",
records: []TXTRecord{{Value: BuildIssueValues("ca.example", "acc", false, &expiredPersistUntil)}},
issuer: "ca.example",
requiredPersistUTC: ptrTime(expiredPersistUntil),
requiredPersistUTC: Pointer(expiredPersistUntil),
expect: true,
},
{
desc: "required persistUntil mismatch",
records: []TXTRecord{{Value: "ca.example;accounturi=acc;persistUntil=4102444801"}},
issuer: "ca.example",
requiredPersistUTC: ptrTime(time.Unix(4102444800, 0).UTC()),
requiredPersistUTC: Pointer(time.Unix(4102444800, 0).UTC()),
expect: false,
},
{
desc: "required persistUntil missing",
records: []TXTRecord{{Value: "ca.example;accounturi=acc"}},
issuer: "ca.example",
requiredPersistUTC: ptrTime(time.Unix(4102444800, 0).UTC()),
requiredPersistUTC: Pointer(time.Unix(4102444800, 0).UTC()),
expect: false,
},
}
@ -434,6 +434,5 @@ func TestChallenge_hasMatchingRecord(t *testing.T) {
}
}
func ptrTime(t time.Time) *time.Time {
return &t
}
// TODO(ldez) factorize
func Pointer[T any](v T) *T { return &v }