deblan-mirror/lego
1
0
Fork 0
mirror of https://github.com/go-acme/lego synced 2026-03-14 14:35:48 +01:00
Code Issues Projects Releases Packages Wiki Activity

feat: move enableCommonName option to Request

Browse source
This commit is contained in:
Fernandez Ludovic 2026-02-17 14:45:51 +01:00
commit b0ce512a73
4 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

21
certificate/certificates.go
View file

@ -75,10 +75,11 @@ type ObtainRequest struct {
MustStaple bool
EmailAddresses []string
NotBefore time.Time
NotAfter time.Time
Bundle bool
PreferredChain string
NotBefore time.Time
NotAfter time.Time
Bundle bool
PreferredChain string
EnableCommonName bool
// A string uniquely identifying the profile
// which will be used to affect issuance of the certificate requested by this Order.
@ -104,10 +105,11 @@ type ObtainForCSRRequest struct {
PrivateKey crypto.PrivateKey
NotBefore time.Time
NotAfter time.Time
Bundle bool
PreferredChain string
NotBefore time.Time
NotAfter time.Time
Bundle bool
PreferredChain string
EnableCommonName bool
// A string uniquely identifying the profile
// which will be used to affect issuance of the certificate requested by this Order.
@ -130,7 +132,6 @@ type CertifierOptions struct {
KeyType certcrypto.KeyType
Timeout time.Duration
OverallRequestLimit int
EnableCommonName bool
}
// Certifier A service to obtain/renew/revoke certificates.
@ -309,7 +310,7 @@ func (c *Certifier) getForOrder(ctx context.Context, domains []string, order acm
}
commonName := ""
if len(domains[0]) <= 64 && c.options.EnableCommonName {
if len(domains[0]) <= 64 && request.EnableCommonName {
commonName = domains[0]
}

3
cmd/setup.go
View file

@ -46,7 +46,6 @@ func newClientConfig(cmd *cli.Command, account registration.User, keyType certcr
KeyType: keyType,
Timeout: time.Duration(cmd.Int(flgCertTimeout)) * time.Second,
OverallRequestLimit: cmd.Int(flgOverallRequestLimit),
EnableCommonName: cmd.Bool(flgEnableCommonName),
}
if cmd.IsSet(flgHTTPTimeout) {
@ -168,6 +167,7 @@ func newObtainRequest(cmd *cli.Command, domains []string) certificate.ObtainRequ
NotAfter: cmd.Timestamp(flgNotAfter),
Bundle: !cmd.Bool(flgNoBundle),
PreferredChain: cmd.String(flgPreferredChain),
EnableCommonName: cmd.Bool(flgEnableCommonName),
Profile: cmd.String(flgProfile),
AlwaysDeactivateAuthorizations: cmd.Bool(flgAlwaysDeactivateAuthorizations),
}
@ -180,6 +180,7 @@ func newObtainForCSRRequest(cmd *cli.Command, csr *x509.CertificateRequest) cert
NotAfter: cmd.Timestamp(flgNotAfter),
Bundle: !cmd.Bool(flgNoBundle),
PreferredChain: cmd.String(flgPreferredChain),
EnableCommonName: cmd.Bool(flgEnableCommonName),
Profile: cmd.String(flgProfile),
AlwaysDeactivateAuthorizations: cmd.Bool(flgAlwaysDeactivateAuthorizations),
}

1
lego/client.go
View file

@ -58,7 +58,6 @@ func NewClient(config *Config) (*Client, error) {
KeyType: config.Certificate.KeyType,
Timeout: config.Certificate.Timeout,
OverallRequestLimit: config.Certificate.OverallRequestLimit,
EnableCommonName: config.Certificate.EnableCommonName,
}
certifier := certificate.NewCertifier(core, prober, options)

1
lego/client_config.go
View file

@ -58,7 +58,6 @@ type CertificateConfig struct {
KeyType certcrypto.KeyType
Timeout time.Duration
OverallRequestLimit int
EnableCommonName bool
}
// createDefaultHTTPClient Creates an HTTP client with a reasonable timeout value