diff --git a/Mage/Task/Factory.php b/Mage/Task/Factory.php index e177f6b..db53818 100644 --- a/Mage/Task/Factory.php +++ b/Mage/Task/Factory.php @@ -30,7 +30,7 @@ class Factory * @param boolean $inRollback * @param string $stage * @return \Mage\Task\AbstractTask - * @throws \Exception|\Mage\Task\ErrorWithMessageException + * @throws \Exception */ public static function get($taskData, Config $taskConfig, $inRollback = false, $stage = null) { diff --git a/tests/MageTest/Task/FactoryTest.php b/tests/MageTest/Task/FactoryTest.php index 2413cab..4b31ca2 100644 --- a/tests/MageTest/Task/FactoryTest.php +++ b/tests/MageTest/Task/FactoryTest.php @@ -30,6 +30,15 @@ class FactoryTest extends PHPUnit_Framework_TestCase $this->assertInstanceOf('\\Mage\\Task\\AbstractTask', $task); } + /** + * @dataProvider taskDataProvider + */ + public function testGetWith($taskData) + { + $task = Factory::get($taskData, $this->config); + $this->assertInstanceOf('\\Mage\\Task\\AbstractTask', $task); + } + /** * @expectedException \Exception * @expectedExceptionMessage The Task MyInconsistentTask must be an instance of Mage\Task\AbstractTask. @@ -45,7 +54,7 @@ class FactoryTest extends PHPUnit_Framework_TestCase */ public function testGetClassDoesNotExist() { - Factory::get('notknowntask', $this->config); + Factory::get('unknowntask', $this->config); } /**