Use instanceof instead of method is_a

Since is_a is a method, it is significantly slower than using instanceof

Following is a perfomance comparison:
http://micro-optimization.com/is_a-vs-instanceof
This commit is contained in:
Ismael Ambrosi 2014-12-05 02:40:30 -02:00
parent 5199a915b6
commit 8ae83cbabd

View file

@ -59,7 +59,7 @@ class Factory
$instance = new $className($taskConfig, $inRollback, $stage, $taskParameters);
if (!is_a($instance, 'Mage\Task\AbstractTask')) {
if (!($instance instanceof AbstractTask)) {
throw new Exception('The Task ' . $taskName . ' must be an instance of Mage\Task\AbstractTask.');
}