deblan-mirror/mautrix-go
1
0
Fork 0
mirror of https://mau.dev/mautrix/go.git synced 2026-03-14 14:25:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

crypto/ssss: only accept secret shares from verified devices (#352)

Browse source 
Co-authored-by: Tulir Asokan <tulir@maunium.net>
This commit is contained in:
Brad Murray 2025-02-13 15:52:34 -05:00 • committed by GitHub
commit 14008caaa4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 13 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

13
crypto/sharing.go
View file

@ -173,6 +173,19 @@ func (mach *OlmMachine) receiveSecret(ctx context.Context, evt *DecryptedOlmEven
return
}
// https://spec.matrix.org/v1.10/client-server-api/#msecretsend
// "The recipient must ensure... that the device is a verified device owned by the recipient"
if senderDevice, err := mach.GetOrFetchDevice(ctx, evt.Sender, evt.SenderDevice); err != nil {
log.Err(err).Msg("Failed to get or fetch sender device, rejecting secret")
return
} else if senderDevice == nil {
log.Warn().Msg("Unknown sender device, rejecting secret")
return
} else if !mach.IsDeviceTrusted(ctx, senderDevice) {
log.Warn().Msg("Sender device is not verified, rejecting secret")
return
}
mach.secretLock.Lock()
secretChan := mach.secretListeners[content.RequestID]
mach.secretLock.Unlock()