From c8fa90d6abf559ab8c042b4eece2c4e28bdfb4a5 Mon Sep 17 00:00:00 2001 From: Joachim Bauch Date: Thu, 2 Feb 2023 13:25:39 +0100 Subject: [PATCH 1/3] CI: Also test with Golang 1.20 --- .github/workflows/tarball.yml | 2 ++ .github/workflows/test.yml | 1 + 2 files changed, 3 insertions(+) diff --git a/.github/workflows/tarball.yml b/.github/workflows/tarball.yml index cc71eec..54f6c63 100644 --- a/.github/workflows/tarball.yml +++ b/.github/workflows/tarball.yml @@ -27,6 +27,7 @@ jobs: - "1.17" - "1.18" - "1.19" + - "1.20" runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 @@ -74,6 +75,7 @@ jobs: - "1.17" - "1.18" - "1.19" + - "1.20" runs-on: ubuntu-latest needs: [create] steps: diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d6d35af..2b2ad52 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -29,6 +29,7 @@ jobs: - "1.17" - "1.18" - "1.19" + - "1.20" runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 From cb68e074bb6b87de71460eabb52ad534e59343e7 Mon Sep 17 00:00:00 2001 From: Joachim Bauch Date: Thu, 2 Feb 2023 13:27:27 +0100 Subject: [PATCH 2/3] docker: Build with Golang 1.20 --- docker/proxy/Dockerfile | 2 +- docker/server/Dockerfile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docker/proxy/Dockerfile b/docker/proxy/Dockerfile index 89e934c..d043411 100644 --- a/docker/proxy/Dockerfile +++ b/docker/proxy/Dockerfile @@ -1,4 +1,4 @@ -FROM --platform=${BUILDPLATFORM} golang:1.19 AS builder +FROM --platform=${BUILDPLATFORM} golang:1.20 AS builder ARG TARGETARCH ARG TARGETOS diff --git a/docker/server/Dockerfile b/docker/server/Dockerfile index 180e334..be36ca7 100644 --- a/docker/server/Dockerfile +++ b/docker/server/Dockerfile @@ -1,4 +1,4 @@ -FROM --platform=${BUILDPLATFORM} golang:1.19 AS builder +FROM --platform=${BUILDPLATFORM} golang:1.20 AS builder WORKDIR /workdir From a34f3b609364a144242f05c9f11cb492811ed38c Mon Sep 17 00:00:00 2001 From: Joachim Bauch Date: Wed, 8 Feb 2023 08:40:41 +0100 Subject: [PATCH 3/3] No longer support Golang 1.17. While it might still compile with 1.17, it's no longer tested through CI and at some point, features that require 1.18 will be used. --- .github/workflows/tarball.yml | 2 -- .github/workflows/test.yml | 1 - README.md | 2 +- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/tarball.yml b/.github/workflows/tarball.yml index 54f6c63..4b176e9 100644 --- a/.github/workflows/tarball.yml +++ b/.github/workflows/tarball.yml @@ -24,7 +24,6 @@ jobs: strategy: matrix: go-version: - - "1.17" - "1.18" - "1.19" - "1.20" @@ -72,7 +71,6 @@ jobs: strategy: matrix: go-version: - - "1.17" - "1.18" - "1.19" - "1.20" diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 2b2ad52..9dc8b0d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -26,7 +26,6 @@ jobs: strategy: matrix: go-version: - - "1.17" - "1.18" - "1.19" - "1.20" diff --git a/README.md b/README.md index 958650a..30919fd 100644 --- a/README.md +++ b/README.md @@ -17,7 +17,7 @@ information on the API of the signaling server. The following tools are required for building the signaling server. - git -- go >= 1.17 +- go >= 1.18 (usually the last three versions of go are supported) - make - protobuf-compiler >= 3