From 27989752bffd0184a3f05534f223e06c02c0ec4b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Wed, 13 Apr 2022 03:05:08 +0200 Subject: [PATCH] Remove "update" parameter in favour of "sid" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The "update" parameter was used to know if an offer should be treated by the clients as a renegotiation or a new connection. However, since the introduction of "sid" this is implicitly known (if the "sid" matches an existing connection then it is an update, otherwise it is a new connection), so that specific parameter is no longer needed. Signed-off-by: Daniel Calviño Sánchez --- api_signaling.go | 1 - clientsession.go | 1 - 2 files changed, 2 deletions(-) diff --git a/api_signaling.go b/api_signaling.go index a2c81b9..61cfa45 100644 --- a/api_signaling.go +++ b/api_signaling.go @@ -655,7 +655,6 @@ type AnswerOfferMessage struct { RoomType string `json:"roomType"` Payload map[string]interface{} `json:"payload"` Sid string `json:"sid,omitempty"` - Update bool `json:"update,omitempty"` } // Type "transient" diff --git a/clientsession.go b/clientsession.go index 678d510..9270511 100644 --- a/clientsession.go +++ b/clientsession.go @@ -572,7 +572,6 @@ func (s *ClientSession) sendOffer(client McuClient, sender string, streamType st RoomType: streamType, Payload: offer, Sid: client.Sid(), - Update: true, } offer_data, err := json.Marshal(offer_message) if err != nil {