deblan-mirror/nextcloud-spreed-signaling
deblan-mirror/nextcloud-spreed-signaling
1
0
Fork 0
mirror of https://github.com/strukturag/nextcloud-spreed-signaling synced 2024-06-01 21:42:18 +02:00
Code Issues Releases Wiki Activity

Don't use "select" with a single case that reads from a channel but read channel directly.

Browse source
This commit is contained in:
Joachim Bauch 2020-07-31 15:32:42 +02:00
parent 7d874ac1a7
commit 68477474f8
Failed to extract signature
2 changed files with 7 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/server/main.go
View file

@ -288,8 +288,6 @@ func main() {
} }
} }
select { <-interrupt
case <-interrupt: log.Println("Interrupted")
log.Println("Interrupted")
}
} }

12
src/signaling/natsclient_loopback.go
View file

@ -148,13 +148,11 @@ func (c *LoopbackNatsClient) Request(subject string, data []byte, timeout time.D
c.mu.Unlock() c.mu.Unlock()
ctx, cancel := context.WithTimeout(context.Background(), timeout) ctx, cancel := context.WithTimeout(context.Background(), timeout)
defer cancel() defer cancel()
select { <-ctx.Done()
case <-ctx.Done(): if ctx.Err() == context.DeadlineExceeded {
if ctx.Err() == context.DeadlineExceeded { err = nats.ErrTimeout
err = nats.ErrTimeout } else {
} else { err = ctx.Err()
err = ctx.Err()
}
} }
c.mu.Lock() c.mu.Lock()
return nil, err return nil, err