deblan-mirror/nextcloud-spreed-signaling
deblan-mirror/nextcloud-spreed-signaling
1
0
Fork 0
mirror of https://github.com/strukturag/nextcloud-spreed-signaling synced 2024-05-03 06:13:17 +02:00
Code Issues Releases Wiki Activity

Add missing lock for "roomSessionId" to avoid potential races.

Browse source
This commit is contained in:
Joachim Bauch 2023-06-15 11:22:26 +02:00
parent d22b4ef2ad
commit 6da48e31b5
No known key found for this signature in database
GPG key ID: 77C1D22D53E15F02
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
clientsession.go
View file

@ -150,6 +150,8 @@ func (s *ClientSession) PublicId() string {
}
func (s *ClientSession) RoomSessionId() string {
s.mu.Lock()
defer s.mu.Unlock()
return s.roomSessionId
}
@ -1022,10 +1024,7 @@ func (s *ClientSession) processAsyncMessage(message *AsyncMessage) {
return
case "message":
if message.Message.Type == "bye" && message.Message.Bye.Reason == "room_session_reconnected" {
s.mu.Lock()
roomSessionId := s.RoomSessionId()
s.mu.Unlock()
log.Printf("Closing session %s because same room session %s connected", s.PublicId(), roomSessionId)
log.Printf("Closing session %s because same room session %s connected", s.PublicId(), s.RoomSessionId())
s.LeaveRoom(false)
defer s.closeAndWait(false)
}