deblan-mirror/nextcloud-spreed-signaling
deblan-mirror/nextcloud-spreed-signaling
1
0
Fork 0
mirror of https://github.com/strukturag/nextcloud-spreed-signaling synced 2026-03-14 14:35:44 +01:00
Code Issues Releases Wiki Activity

Close subscriber synchronously on errors.

Browse source 
Otherwise it could happen that a re-subscribe request was still processed by
the (closing) old subscriber for which the deferred processing stopped. Such
requests would then timeout.

Could be triggered by the CI tests under load (e.g. Test_JanusSubscriberTimeout).
This commit is contained in:
Joachim Bauch 2025-12-11 08:51:58 +01:00
commit 8371fbe9bf
No known key found for this signature in database
GPG key ID: 77C1D22D53E15F02
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
mcu_janus_subscriber.go
View file

@ -236,7 +236,7 @@ retry:
switch error_code {
case JANUS_VIDEOROOM_ERROR_NO_SUCH_ROOM:
p.logger.Printf("Publisher %s not created yet for %s, not joining room %d as subscriber", p.publisher, p.streamType, p.roomId)
go p.Close(context.Background())
p.Close(context.Background())
callback(fmt.Errorf("Publisher %s not created yet for %s", p.publisher, p.streamType), nil)
return
case JANUS_VIDEOROOM_ERROR_NO_SUCH_FEED:
@ -249,7 +249,7 @@ retry:
}
if err := waiter.Wait(ctx); err != nil {
go p.Close(context.Background())
p.Close(context.Background())
callback(err, nil)
return
}