From c9ea3a86c2105fe620308b68afca1726731c1050 Mon Sep 17 00:00:00 2001 From: Phreshhh Date: Tue, 29 Jan 2019 14:58:36 +0100 Subject: [PATCH 1/5] Navbar fix for FireFox --- docs/content/docs/components/navbar.md | 58 +++++++++++--------------- package.json | 2 +- src/components/_navbar.scss | 11 ++++- 3 files changed, 34 insertions(+), 37 deletions(-) diff --git a/docs/content/docs/components/navbar.md b/docs/content/docs/components/navbar.md index af015d5..9064667 100644 --- a/docs/content/docs/components/navbar.md +++ b/docs/content/docs/components/navbar.md @@ -9,13 +9,11 @@ description: PaperCSS Navbar
- +
- +
  • Documentation
    • @@ -60,13 +56,11 @@ Add ```.fixed``` to ```
- +
+
+
+
  • Documentation
    • @@ -86,13 +80,11 @@ Add ```.fixed``` to ```
- +
  • Documentation
    • @@ -112,13 +104,11 @@ Add ```.fixed``` to ```
- +
  • Documentation
    • diff --git a/package.json b/package.json index 04d7aa2..33a0ba3 100644 --- a/package.json +++ b/package.json @@ -8,7 +8,7 @@ "build": "node node_modules/gulp/bin/gulp.js build", "test": "echo \"Error: no test specified\" && exit 1", "postinstall": "gulp postinstall", - "stylelint": "node_modules/stylelint/bin/stylelint.js 'src/**/*.scss'" + "stylelint": "node node_modules/stylelint/bin/stylelint.js 'src/**/*.scss'" }, "repository": { "type": "git", diff --git a/src/components/_navbar.scss b/src/components/_navbar.scss index 8af7535..5d7f7b4 100644 --- a/src/components/_navbar.scss +++ b/src/components/_navbar.scss @@ -23,7 +23,7 @@ nav { width: 2rem; } - .collapsible input[id^=collapsible]:checked + button { + .collapsible input[id^=collapsible]:checked + label { .bar1 { transform: rotate(-45deg) translate(-9px, 7px); } @@ -107,6 +107,13 @@ nav { } } + .collapsible { + @include resp(small) { + width: 100%; + margin-top: 50px; + } + } + .collapsible input[id^=collapsible]:checked ~ div.collapsible-body { margin: 0; max-height: 960px; @@ -132,7 +139,7 @@ nav { padding: 0; } - .collapsible > button { + .collapsible > label { background-color: $main-background; display: none; font-size: 0.5rem; From 6bc209efd83d5158f951cdac4cf25fd90d16b67c Mon Sep 17 00:00:00 2001 From: Phreshhh Date: Tue, 29 Jan 2019 15:10:44 +0100 Subject: [PATCH 2/5] margin-top stylelint fix --- src/components/_navbar.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/_navbar.scss b/src/components/_navbar.scss index 5d7f7b4..76b1f60 100644 --- a/src/components/_navbar.scss +++ b/src/components/_navbar.scss @@ -109,8 +109,8 @@ nav { .collapsible { @include resp(small) { - width: 100%; margin-top: 50px; + width: 100%; } } From 72ac948f704465eab23e2690f0d9c20d29b4fd84 Mon Sep 17 00:00:00 2001 From: Phreshhh Date: Tue, 29 Jan 2019 15:39:08 +0100 Subject: [PATCH 3/5] margin-top removed --- src/components/_navbar.scss | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/_navbar.scss b/src/components/_navbar.scss index 76b1f60..fc8746a 100644 --- a/src/components/_navbar.scss +++ b/src/components/_navbar.scss @@ -109,7 +109,6 @@ nav { .collapsible { @include resp(small) { - margin-top: 50px; width: 100%; } } From fad66597ceef693114ec96d98452eab0b28d2e3c Mon Sep 17 00:00:00 2001 From: Phreshhh Date: Tue, 29 Jan 2019 16:21:23 +0100 Subject: [PATCH 4/5] burger borderfix --- src/components/_navbar.scss | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/components/_navbar.scss b/src/components/_navbar.scss index fc8746a..f015594 100644 --- a/src/components/_navbar.scss +++ b/src/components/_navbar.scss @@ -134,8 +134,11 @@ nav { } .collapsible label { - border-bottom: 0; - padding: 0; + border: 2px solid #41403e; + border-bottom-left-radius: 15px 255px; + border-bottom-right-radius: 225px 15px; + border-top-left-radius: 255px 15px; + border-top-right-radius: 15px 225px; } .collapsible > label { From 12af59b98ae44af08d96600a566f62c6a233e4c6 Mon Sep 17 00:00:00 2001 From: Phreshhh Date: Mon, 11 Feb 2019 09:36:27 +0100 Subject: [PATCH 5/5] button fix for backward compatibility --- src/components/_navbar.scss | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/components/_navbar.scss b/src/components/_navbar.scss index f015594..4e23860 100644 --- a/src/components/_navbar.scss +++ b/src/components/_navbar.scss @@ -23,6 +23,7 @@ nav { width: 2rem; } + .collapsible input[id^=collapsible]:checked + button, // Leaving for backwards compatibility. See docs for proper usage .collapsible input[id^=collapsible]:checked + label { .bar1 { transform: rotate(-45deg) translate(-9px, 7px); @@ -101,7 +102,7 @@ nav { h3, h4, h5, - h6, { + h6 { margin: 0; margin-bottom: 0.2rem; } @@ -141,6 +142,11 @@ nav { border-top-right-radius: 15px 225px; } + .collapsible > button { // Leaving for backwards compatibility. See docs for proper usage + border: 0; + } + + .collapsible > button, // Leaving for backwards compatibility. See docs for proper usage .collapsible > label { background-color: $main-background; display: none;