From d6d74706835d4a8220bda063c9af70793bfe268c Mon Sep 17 00:00:00 2001 From: Jan Vitturi Date: Fri, 20 Sep 2019 15:36:14 +0200 Subject: [PATCH 1/2] Add caveats for unexpanded globs --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index 42ba1f3..263ff18 100644 --- a/README.md +++ b/README.md @@ -439,6 +439,8 @@ $ lines ~/.bashrc This works by passing the output of the glob to the function and then counting the number of arguments. +**CAVEAT:** When the glob does not match anything (empty directory or no matching files) it is not expanded and the function returns `1`. + **Example Function:** ```sh @@ -575,6 +577,8 @@ done < "file" Don’t use `ls`. +**CAVEAT:** When the glob does not match anything (empty directory or no matching files) the variable will contain the unexpanded glob. + ```shell # Greedy example. for file in *; do From 02c30875695f0530b42ca497138f9c3f1043c090 Mon Sep 17 00:00:00 2001 From: Jan Vitturi Date: Fri, 20 Sep 2019 18:50:16 +0200 Subject: [PATCH 2/2] Check for unexpanded globs --- README.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 263ff18..979af66 100644 --- a/README.md +++ b/README.md @@ -577,21 +577,24 @@ done < "file" Don’t use `ls`. -**CAVEAT:** When the glob does not match anything (empty directory or no matching files) the variable will contain the unexpanded glob. +**CAVEAT:** When the glob does not match anything (empty directory or no matching files) the variable will contain the unexpanded glob. To avoid working on unexpanded globs check the existence of the file contained in the variable using the appropriate [file conditional](#file-conditionals). Be aware that symbolic links are resolved. ```shell # Greedy example. for file in *; do + [ -e "$file" ] || [ -L "$file" ] || continue printf '%s\n' "$file" done # PNG files in dir. for file in ~/Pictures/*.png; do + [ -f "$file" ] || continue printf '%s\n' "$file" done # Iterate over directories. for dir in ~/Downloads/*/; do + [ -d "$dir" ] || continue printf '%s\n' "$dir" done ```