deblan-mirror/respect-validation
deblan-mirror/respect-validation
1
0
Fork 0
mirror of https://github.com/Respect/Validation.git synced 2024-06-08 00:32:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make clear when Stub should not be executed

Browse source 
Having a named constructor with a name that clarifies that we don't
expect to execute the stub will make it easier to read the tests.

Signed-off-by: Henrique Moody <henriquemoody@gmail.com>
This commit is contained in:
Henrique Moody 2024-02-22 16:15:29 +01:00
parent d25557cd72
commit 3a7ac0240d
No known key found for this signature in database
GPG key ID: 221E9281655813A6
6 changed files with 23 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
tests/library/Rules/Stub.php
View file

@ -34,6 +34,11 @@ final class Stub extends AbstractRule
$this->validations = $validations;
}
public static function daze(): self
{
return new self();
}
public static function pass(int $expectedCount): self
{
return new self(...array_fill(0, $expectedCount, true));

2
tests/unit/FactoryTest.php
View file

@ -99,7 +99,7 @@ final class FactoryTest extends TestCase
{
$factory = new Factory();
$input = 'input';
$rule = Stub::pass(0);
$rule = Stub::daze();
self::assertInstanceOf(ValidationException::class, $factory->exception($rule, $input));
}

10
tests/unit/Rules/EachTest.php
View file

@ -74,7 +74,7 @@ final class EachTest extends RuleTestCase
public static function providerForValidInput(): iterable
{
return [
[new Each(Stub::pass(0)), []],
[new Each(Stub::daze()), []],
[new Each(Stub::pass(5)), [1, 2, 3, 4, 5]],
[new Each(Stub::pass(5)), self::createTraversableInput(1, 5)],
[new Each(Stub::pass(5)), self::createStdClassInput(1, 5)],
@ -85,10 +85,10 @@ final class EachTest extends RuleTestCase
public static function providerForInvalidInput(): iterable
{
return [
[new Each(Stub::fail(0)), 123],
[new Each(Stub::fail(0)), ''],
[new Each(Stub::fail(0)), null],
[new Each(Stub::fail(0)), false],
[new Each(Stub::daze()), 123],
[new Each(Stub::daze()), ''],
[new Each(Stub::daze()), null],
[new Each(Stub::daze()), false],
[new Each(Stub::fail(5)), ['', 2, 3, 4, 5]],
[new Each(Stub::fail(5)), ['a', 2, 3, 4, 5]],
[new Each(Stub::fail(5)), self::createTraversableInput(1, 5)],

16
tests/unit/Rules/KeySetTest.php
View file

@ -33,8 +33,8 @@ final class KeySetTest extends TestCase
$this->expectExceptionMessage('KeySet rule accepts only Key rules');
new KeySet(new AllOf(
new Key('foo', Stub::pass(0), false),
new Key('bar', Stub::pass(0), false),
new Key('foo', Stub::daze(), false),
new Key('bar', Stub::daze(), false),
));
}
@ -44,7 +44,7 @@ final class KeySetTest extends TestCase
$this->expectException(ComponentException::class);
$this->expectExceptionMessage('KeySet rule accepts only Key rules');
new KeySet(new AllOf(Stub::pass(0)));
new KeySet(new AllOf(Stub::daze()));
}
#[Test]
@ -53,7 +53,7 @@ final class KeySetTest extends TestCase
$this->expectException(ComponentException::class);
$this->expectExceptionMessage('KeySet rule accepts only Key rules');
new KeySet(Stub::pass(0));
new KeySet(Stub::daze());
}
#[Test]
@ -65,7 +65,7 @@ final class KeySetTest extends TestCase
$sut = new KeySet(
new Key('foo', Stub::pass(1), true),
new Key('bar', Stub::pass(0), true),
new Key('bar', Stub::daze(), true),
);
self::assertFalse($sut->validate($input));
@ -80,7 +80,7 @@ final class KeySetTest extends TestCase
$sut = new KeySet(
new Key('foo', Stub::pass(1), true),
new Key('bar', Stub::pass(0), false),
new Key('bar', Stub::daze(), false),
);
self::assertTrue($sut->validate($input));
@ -107,8 +107,8 @@ final class KeySetTest extends TestCase
public function shouldValidateKeysWhenEmpty(): void
{
$sut = new KeySet(
new Key('foo', Stub::pass(0), true),
new Key('bar', Stub::pass(0), true),
new Key('foo', Stub::daze(), true),
new Key('bar', Stub::daze(), true),
);
self::assertFalse($sut->validate([]));

4
tests/unit/Rules/NullableTest.php
View file

@ -43,7 +43,7 @@ final class NullableTest extends TestCase
#[DoesNotPerformAssertions]
public function shouldNotAssertRuleWhenInputIsNull(): void
{
$sut = new Nullable(Stub::pass(0));
$sut = new Nullable(Stub::daze());
$sut->assert(null);
}
@ -63,7 +63,7 @@ final class NullableTest extends TestCase
#[DoesNotPerformAssertions]
public function shouldNotCheckRuleWhenInputIsNull(): void
{
$rule = new Nullable(Stub::pass(0));
$rule = new Nullable(Stub::daze());
$rule->check(null);
}

4
tests/unit/Rules/PropertyTest.php
View file

@ -43,7 +43,7 @@ final class PropertyTest extends RuleTestCase
new WithProperties(),
],
'non mandatory attribute is not present with extra validator' => [
new Property('nonexistent', Stub::pass(0), false),
new Property('nonexistent', Stub::daze(), false),
new WithProperties(),
],
'attribute is present but uninitialized with extra validator' => [
@ -58,7 +58,7 @@ final class PropertyTest extends RuleTestCase
{
return [
'attribute is absent without extra validator' => [new Property('barr'), new WithProperties()],
'attribute is absent with extra validator' => [new Property('barr', Stub::fail(0)), new WithProperties()],
'attribute is absent with extra validator' => [new Property('barr', Stub::daze()), new WithProperties()],
'private attribute is not valid based on extra validator' => [
new Property('private', Stub::fail(1)),
new WithProperties(),