deblan-mirror/respect-validation
deblan-mirror/respect-validation
1
0
Fork 0
mirror of https://github.com/Respect/Validation.git synced 2026-03-16 07:15:45 +01:00
Code Issues Projects Releases Packages Wiki Activity

Remove unused argument from Renderer::render()

Browse source 
Apparently, we were not using the argument anywhere, but I didn't notice
that before.
This commit is contained in:
Henrique Moody 2025-12-19 16:26:37 +01:00
commit 423172985b
No known key found for this signature in database
GPG key ID: 221E9281655813A6
4 changed files with 5 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

2
library/Message/Renderer.php
View file

@ -13,5 +13,5 @@ use Respect\Validation\Result;
interface Renderer
{
public function render(Result $result, Translator $translator, string|null $template = null): string;
public function render(Result $result, Translator $translator): string;
}

4
library/Message/StandardRenderer.php
View file

@ -33,7 +33,7 @@ final class StandardRenderer implements Renderer
) {
}
public function render(Result $result, Translator $translator, string|null $template = null): string
public function render(Result $result, Translator $translator): string
{
$parameters = $result->parameters;
$parameters['path'] = $result->path !== null ? Quoted::fromPath($result->path) : null;
@ -51,7 +51,7 @@ final class StandardRenderer implements Renderer
return $this->placeholder($matches[1], $parameters[$matches[1]], $translator, $matches[3] ?? null);
},
$translator->translate($template ?? $this->getTemplateMessage($result)),
$translator->translate($this->getTemplateMessage($result)),
);
if (!$result->hasCustomTemplate() && $result->adjacent !== null) {

4
tests/library/Message/TestingMessageRenderer.php
View file

@ -15,8 +15,8 @@ use Respect\Validation\Result;
final class TestingMessageRenderer implements Renderer
{
public function render(Result $result, Translator $translator, string|null $template = null): string
public function render(Result $result, Translator $translator): string
{
return $template ?? $result->template;
return $result->template;
}
}

12
tests/unit/Message/StandardRendererTest.php
View file

@ -32,18 +32,6 @@ final class StandardRendererTest extends TestCase
self::assertSame($result->template, $renderer->render($result, new DummyTranslator()));
}
#[Test]
public function itShouldRenderResultOverwritingCustomTemplateWhenTemplateIsPassedAsAnArgument(): void
{
$renderer = new StandardRenderer(new TestingStringifier());
$template = 'This is my brand new template';
$result = (new ResultBuilder())->template('This is my template')->build();
self::assertSame($template, $renderer->render($result, new DummyTranslator(), $template));
}
#[Test]
public function itShouldRenderResultProcessingParametersInTheTemplate(): void
{