deblan-mirror/respect-validation
deblan-mirror/respect-validation
1
0
Fork 0
mirror of https://github.com/Respect/Validation.git synced 2026-03-16 23:35:45 +01:00
Code Issues Projects Releases Packages Wiki Activity

Change the contract of the formatters

Browse source 
Both `ArrayFormatter` and `StringFormatter` accept an instance of the
`Translator`. Thinking about it a bit better, I realised that a
formatter might not always need a `Translator`, but it will surely need
a `Renderer`.

Besides, the `InterpolationRenderer` needs to take translation into
account, so it seems more natural to me that this is the one that will
get an instance of the `Translator`, as other implementations of the
`Renderer` might not even deal with translations.
This commit is contained in:
Henrique Moody 2025-12-21 22:22:33 +01:00
commit 644ecb5190
No known key found for this signature in database
GPG key ID: 221E9281655813A6
14 changed files with 91 additions and 121 deletions
Download patch file Download diff file Expand all files Collapse all files

17
tests/unit/Message/Formatter/NestedArrayFormatterTest.php
View file

@ -14,7 +14,6 @@ use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Test;
use Respect\Validation\Exceptions\ComponentException;
use Respect\Validation\Message\StandardFormatter\ResultCreator;
use Respect\Validation\Message\Translator\DummyTranslator;
use Respect\Validation\Result;
use Respect\Validation\Test\Builders\ResultBuilder;
use Respect\Validation\Test\Message\TestingMessageRenderer;
@ -37,21 +36,17 @@ final class NestedArrayFormatterTest extends TestCase
#[DataProvider('provideForArray')]
public function itShouldFormatArrayMessage(Result $result, array $expected, array $templates = []): void
{
$formatter = new NestedArrayFormatter(
renderer: new TestingMessageRenderer(),
templateResolver: new TemplateResolver(),
);
$renderer = new TestingMessageRenderer();
$formatter = new NestedArrayFormatter(new TemplateResolver());
self::assertSame($expected, $formatter->format($result, $templates, new DummyTranslator()));
self::assertSame($expected, $formatter->format($result, $renderer, $templates));
}
#[Test]
public function itShouldThrowAnExceptionWhenTryingToFormatAndTemplateIsInvalid(): void
{
$formatter = new NestedArrayFormatter(
renderer: new TestingMessageRenderer(),
templateResolver: new TemplateResolver(),
);
$renderer = new TestingMessageRenderer();
$formatter = new NestedArrayFormatter(new TemplateResolver());
$result = (new ResultBuilder())->id('foo')->build();
$template = new stdClass();
@ -59,7 +54,7 @@ final class NestedArrayFormatterTest extends TestCase
$this->expectException(ComponentException::class);
$this->expectExceptionMessage(sprintf('Template for "foo" must be a string, %s given', stringify($template)));
$formatter->format($result, ['foo' => $template], new DummyTranslator());
$formatter->format($result, $renderer, ['foo' => $template]);
}
/** @return array<string, array{0: Result, 1: array<string, mixed>, 2?: array<string, mixed>}> */