From 688fbde552599409e88aaaf761f05d75461dbabe Mon Sep 17 00:00:00 2001 From: Henrique Moody Date: Sat, 9 Feb 2019 14:31:56 +0100 Subject: [PATCH] Make PHPUnit tests final Whenever is possible it is better to declare our classes as final. The PHPUnit tests should not be extended, therefore there is no reason for them to not be final. Signed-off-by: Henrique Moody --- tests/unit/Exceptions/CheckExceptionsTest.php | 2 +- tests/unit/Exceptions/NestedValidationExceptionTest.php | 2 +- tests/unit/Rules/AbstractRuleTest.php | 2 +- tests/unit/Rules/AllOfTest.php | 2 +- tests/unit/Rules/AnyOfTest.php | 2 +- tests/unit/Rules/CntrlTest.php | 2 +- tests/unit/Rules/ConsonantTest.php | 2 +- tests/unit/Rules/DomainTest.php | 2 +- tests/unit/Rules/GraphTest.php | 2 +- tests/unit/Rules/HexRgbColorTest.php | 2 +- tests/unit/Rules/KeyNestedTest.php | 2 +- tests/unit/Rules/KeyTest.php | 2 +- tests/unit/Rules/KeyValueTest.php | 2 +- tests/unit/Rules/Locale/PlIdentityCardTest.php | 2 +- tests/unit/Rules/Locale/PlVatinTest.php | 2 +- tests/unit/Rules/NfeAccessKeyTest.php | 2 +- tests/unit/Rules/NoTest.php | 2 +- tests/unit/Rules/NoneOfTest.php | 2 +- tests/unit/Rules/NotTest.php | 2 +- tests/unit/Rules/OneOfTest.php | 2 +- tests/unit/Rules/OptionalTest.php | 2 +- tests/unit/Rules/PhoneTest.php | 2 +- tests/unit/Rules/PostalCodeTest.php | 2 +- tests/unit/Rules/PunctTest.php | 2 +- tests/unit/Rules/RomanTest.php | 2 +- tests/unit/Rules/SizeTest.php | 2 +- tests/unit/Rules/SlugTest.php | 2 +- tests/unit/Rules/SortedTest.php | 2 +- tests/unit/Rules/SpaceTest.php | 2 +- tests/unit/Rules/StartsWithTest.php | 2 +- tests/unit/Rules/SubdivisionCodeTest.php | 2 +- tests/unit/Rules/TypeTest.php | 2 +- tests/unit/Rules/VowelTest.php | 2 +- tests/unit/Rules/XdigitTest.php | 2 +- tests/unit/Rules/ZendTest.php | 2 +- tests/unit/ValidatorTest.php | 2 +- 36 files changed, 36 insertions(+), 36 deletions(-) diff --git a/tests/unit/Exceptions/CheckExceptionsTest.php b/tests/unit/Exceptions/CheckExceptionsTest.php index 90e70826..4aa7dc0d 100644 --- a/tests/unit/Exceptions/CheckExceptionsTest.php +++ b/tests/unit/Exceptions/CheckExceptionsTest.php @@ -25,7 +25,7 @@ use Respect\Validation\Test\TestCase; * @author Gabriel Caruso * @author Henrique Moody */ -class CheckExceptionsTest extends TestCase +final class CheckExceptionsTest extends TestCase { /** * @return string[][] diff --git a/tests/unit/Exceptions/NestedValidationExceptionTest.php b/tests/unit/Exceptions/NestedValidationExceptionTest.php index 5cc9480a..7429b50e 100644 --- a/tests/unit/Exceptions/NestedValidationExceptionTest.php +++ b/tests/unit/Exceptions/NestedValidationExceptionTest.php @@ -22,7 +22,7 @@ use Respect\Validation\Test\TestCase; * @author Gabriel Caruso * @author Henrique Moody */ -class NestedValidationExceptionTest extends TestCase +final class NestedValidationExceptionTest extends TestCase { /** * @test diff --git a/tests/unit/Rules/AbstractRuleTest.php b/tests/unit/Rules/AbstractRuleTest.php index b0bdd3d4..917b119c 100644 --- a/tests/unit/Rules/AbstractRuleTest.php +++ b/tests/unit/Rules/AbstractRuleTest.php @@ -23,7 +23,7 @@ use Respect\Validation\Test\TestCase; * @author Gabriel Caruso * @author Henrique Moody */ -class AbstractRuleTest extends TestCase +final class AbstractRuleTest extends TestCase { /** * @return bool[][] diff --git a/tests/unit/Rules/AllOfTest.php b/tests/unit/Rules/AllOfTest.php index 38ac8b2c..93f6a704 100644 --- a/tests/unit/Rules/AllOfTest.php +++ b/tests/unit/Rules/AllOfTest.php @@ -26,7 +26,7 @@ use Respect\Validation\Validatable; * @author Henrique Moody * @author Nick Lombard */ -class AllOfTest extends TestCase +final class AllOfTest extends TestCase { /** * @test diff --git a/tests/unit/Rules/AnyOfTest.php b/tests/unit/Rules/AnyOfTest.php index fa259f76..aedcd09c 100644 --- a/tests/unit/Rules/AnyOfTest.php +++ b/tests/unit/Rules/AnyOfTest.php @@ -24,7 +24,7 @@ use Respect\Validation\Test\TestCase; * @author Gabriel Caruso * @author Henrique Moody */ -class AnyOfTest extends TestCase +final class AnyOfTest extends TestCase { /** * @test diff --git a/tests/unit/Rules/CntrlTest.php b/tests/unit/Rules/CntrlTest.php index 016a9703..4c72e7ee 100644 --- a/tests/unit/Rules/CntrlTest.php +++ b/tests/unit/Rules/CntrlTest.php @@ -27,7 +27,7 @@ use Respect\Validation\Test\TestCase; * @author Nick Lombard * @author Pascal Borreli */ -class CntrlTest extends TestCase +final class CntrlTest extends TestCase { /** * @dataProvider providerForValidCntrl diff --git a/tests/unit/Rules/ConsonantTest.php b/tests/unit/Rules/ConsonantTest.php index 4a13667c..97419cba 100644 --- a/tests/unit/Rules/ConsonantTest.php +++ b/tests/unit/Rules/ConsonantTest.php @@ -27,7 +27,7 @@ use Respect\Validation\Test\TestCase; * @author Nick Lombard * @author Pascal Borreli */ -class ConsonantTest extends TestCase +final class ConsonantTest extends TestCase { /** * @dataProvider providerForValidConsonants diff --git a/tests/unit/Rules/DomainTest.php b/tests/unit/Rules/DomainTest.php index 7046afe2..2897cb82 100644 --- a/tests/unit/Rules/DomainTest.php +++ b/tests/unit/Rules/DomainTest.php @@ -26,7 +26,7 @@ use Respect\Validation\Validator as v; * @author Henrique Moody * @author Mehmet Tolga Avcioglu */ -class DomainTest extends TestCase +final class DomainTest extends TestCase { /** * @var Domain diff --git a/tests/unit/Rules/GraphTest.php b/tests/unit/Rules/GraphTest.php index e6d4c847..2cb74b5d 100644 --- a/tests/unit/Rules/GraphTest.php +++ b/tests/unit/Rules/GraphTest.php @@ -27,7 +27,7 @@ use Respect\Validation\Test\TestCase; * @author Nick Lombard * @author Pascal Borreli */ -class GraphTest extends TestCase +final class GraphTest extends TestCase { /** * @dataProvider providerForValidGraph diff --git a/tests/unit/Rules/HexRgbColorTest.php b/tests/unit/Rules/HexRgbColorTest.php index 19938501..ea73ddc1 100644 --- a/tests/unit/Rules/HexRgbColorTest.php +++ b/tests/unit/Rules/HexRgbColorTest.php @@ -25,7 +25,7 @@ use stdClass; * @author Gabriel Caruso * @author Henrique Moody */ -class HexRgbColorTest extends TestCase +final class HexRgbColorTest extends TestCase { /** * @dataProvider providerForValidHexRgbColor diff --git a/tests/unit/Rules/KeyNestedTest.php b/tests/unit/Rules/KeyNestedTest.php index 4f4d3b3e..87439768 100644 --- a/tests/unit/Rules/KeyNestedTest.php +++ b/tests/unit/Rules/KeyNestedTest.php @@ -28,7 +28,7 @@ use stdClass; * @author Henrique Moody * @author Ivan Zinovyev */ -class KeyNestedTest extends TestCase +final class KeyNestedTest extends TestCase { /** * @test diff --git a/tests/unit/Rules/KeyTest.php b/tests/unit/Rules/KeyTest.php index 37432364..a6c916bf 100644 --- a/tests/unit/Rules/KeyTest.php +++ b/tests/unit/Rules/KeyTest.php @@ -25,7 +25,7 @@ use Throwable; * @author Gabriel Caruso * @author Henrique Moody */ -class KeyTest extends TestCase +final class KeyTest extends TestCase { /** * @test diff --git a/tests/unit/Rules/KeyValueTest.php b/tests/unit/Rules/KeyValueTest.php index 0a954964..553f42ab 100644 --- a/tests/unit/Rules/KeyValueTest.php +++ b/tests/unit/Rules/KeyValueTest.php @@ -24,7 +24,7 @@ use Respect\Validation\Test\TestCase; * @author Henrique Moody * @author Ian Nisbet */ -class KeyValueTest extends TestCase +final class KeyValueTest extends TestCase { /** * @test diff --git a/tests/unit/Rules/Locale/PlIdentityCardTest.php b/tests/unit/Rules/Locale/PlIdentityCardTest.php index 96d0b48c..08de965c 100644 --- a/tests/unit/Rules/Locale/PlIdentityCardTest.php +++ b/tests/unit/Rules/Locale/PlIdentityCardTest.php @@ -21,7 +21,7 @@ use Respect\Validation\Test\RuleTestCase; * * @author Henrique Moody */ -class PlIdentityCardTest extends RuleTestCase +final class PlIdentityCardTest extends RuleTestCase { /** * {@inheritdoc} diff --git a/tests/unit/Rules/Locale/PlVatinTest.php b/tests/unit/Rules/Locale/PlVatinTest.php index ae1dee88..e5931817 100644 --- a/tests/unit/Rules/Locale/PlVatinTest.php +++ b/tests/unit/Rules/Locale/PlVatinTest.php @@ -23,7 +23,7 @@ use stdClass; * @author Henrique Moody * @author Tomasz Regdos */ -class PlVatinTest extends RuleTestCase +final class PlVatinTest extends RuleTestCase { /** * {@inheritdoc} diff --git a/tests/unit/Rules/NfeAccessKeyTest.php b/tests/unit/Rules/NfeAccessKeyTest.php index 6fb20a02..aebaf734 100644 --- a/tests/unit/Rules/NfeAccessKeyTest.php +++ b/tests/unit/Rules/NfeAccessKeyTest.php @@ -24,7 +24,7 @@ use Respect\Validation\Test\TestCase; * @author Gabriel Caruso * @author Henrique Moody */ -class NfeAccessKeyTest extends TestCase +final class NfeAccessKeyTest extends TestCase { /** * @var NfeAccessKey diff --git a/tests/unit/Rules/NoTest.php b/tests/unit/Rules/NoTest.php index 11729ef5..7cb9e4cd 100644 --- a/tests/unit/Rules/NoTest.php +++ b/tests/unit/Rules/NoTest.php @@ -23,7 +23,7 @@ use Respect\Validation\Test\TestCase; * @author Gabriel Caruso * @author Henrique Moody */ -class NoTest extends TestCase +final class NoTest extends TestCase { /** * @dataProvider validNoProvider diff --git a/tests/unit/Rules/NoneOfTest.php b/tests/unit/Rules/NoneOfTest.php index 6c8082d8..6db67cf8 100644 --- a/tests/unit/Rules/NoneOfTest.php +++ b/tests/unit/Rules/NoneOfTest.php @@ -24,7 +24,7 @@ use Respect\Validation\Test\TestCase; * @author Gabriel Caruso * @author Henrique Moody */ -class NoneOfTest extends TestCase +final class NoneOfTest extends TestCase { /** * @test diff --git a/tests/unit/Rules/NotTest.php b/tests/unit/Rules/NotTest.php index dcc8467c..4ec4d8e5 100644 --- a/tests/unit/Rules/NotTest.php +++ b/tests/unit/Rules/NotTest.php @@ -27,7 +27,7 @@ use Respect\Validation\Validator; * @author Gabriel Caruso * @author Henrique Moody */ -class NotTest extends TestCase +final class NotTest extends TestCase { /** * @doesNotPerformAssertions diff --git a/tests/unit/Rules/OneOfTest.php b/tests/unit/Rules/OneOfTest.php index 367ea974..0c4996ef 100644 --- a/tests/unit/Rules/OneOfTest.php +++ b/tests/unit/Rules/OneOfTest.php @@ -24,7 +24,7 @@ use Respect\Validation\Test\TestCase; * @author Gabriel Caruso * @author Henrique Moody */ -class OneOfTest extends TestCase +final class OneOfTest extends TestCase { /** * @test diff --git a/tests/unit/Rules/OptionalTest.php b/tests/unit/Rules/OptionalTest.php index 3e44601f..743d16bf 100644 --- a/tests/unit/Rules/OptionalTest.php +++ b/tests/unit/Rules/OptionalTest.php @@ -24,7 +24,7 @@ use stdClass; * @author Gabriel Caruso * @author Henrique Moody */ -class OptionalTest extends TestCase +final class OptionalTest extends TestCase { /** * @return mixed[][] diff --git a/tests/unit/Rules/PhoneTest.php b/tests/unit/Rules/PhoneTest.php index eb0b2437..c11e584b 100644 --- a/tests/unit/Rules/PhoneTest.php +++ b/tests/unit/Rules/PhoneTest.php @@ -25,7 +25,7 @@ use Respect\Validation\Test\TestCase; * @author Michael Firsikov * @author Roman Derevianko */ -class PhoneTest extends TestCase +final class PhoneTest extends TestCase { /** * @var Phone diff --git a/tests/unit/Rules/PostalCodeTest.php b/tests/unit/Rules/PostalCodeTest.php index 4a2f2e41..4e5e0c5b 100644 --- a/tests/unit/Rules/PostalCodeTest.php +++ b/tests/unit/Rules/PostalCodeTest.php @@ -25,7 +25,7 @@ use Respect\Validation\Test\TestCase; * @author Henrique Moody * @author Sebastian */ -class PostalCodeTest extends TestCase +final class PostalCodeTest extends TestCase { /** * @test diff --git a/tests/unit/Rules/PunctTest.php b/tests/unit/Rules/PunctTest.php index 64293a03..f4766a39 100644 --- a/tests/unit/Rules/PunctTest.php +++ b/tests/unit/Rules/PunctTest.php @@ -27,7 +27,7 @@ use Respect\Validation\Test\TestCase; * @author Nick Lombard * @author Pascal Borreli */ -class PunctTest extends TestCase +final class PunctTest extends TestCase { /** * @dataProvider providerForValidPunct diff --git a/tests/unit/Rules/RomanTest.php b/tests/unit/Rules/RomanTest.php index 1ab3d848..c02116da 100644 --- a/tests/unit/Rules/RomanTest.php +++ b/tests/unit/Rules/RomanTest.php @@ -24,7 +24,7 @@ use Respect\Validation\Test\TestCase; * @author Henrique Moody * @author Jean Pimentel */ -class RomanTest extends TestCase +final class RomanTest extends TestCase { /** * @var Roman diff --git a/tests/unit/Rules/SizeTest.php b/tests/unit/Rules/SizeTest.php index 55784eac..39cb1e46 100644 --- a/tests/unit/Rules/SizeTest.php +++ b/tests/unit/Rules/SizeTest.php @@ -26,7 +26,7 @@ use SplFileInfo; * @author Gabriel Caruso * @author Henrique Moody */ -class SizeTest extends TestCase +final class SizeTest extends TestCase { /** * @return mixed[][] diff --git a/tests/unit/Rules/SlugTest.php b/tests/unit/Rules/SlugTest.php index d430f3b1..f0748699 100644 --- a/tests/unit/Rules/SlugTest.php +++ b/tests/unit/Rules/SlugTest.php @@ -24,7 +24,7 @@ use Respect\Validation\Test\TestCase; * @author Henrique Moody * @author Marcel dos Santos */ -class SlugTest extends TestCase +final class SlugTest extends TestCase { /** * @dataProvider providerValidSlug diff --git a/tests/unit/Rules/SortedTest.php b/tests/unit/Rules/SortedTest.php index 2f78716e..fbc12e1f 100644 --- a/tests/unit/Rules/SortedTest.php +++ b/tests/unit/Rules/SortedTest.php @@ -24,7 +24,7 @@ use Respect\Validation\Test\TestCase; * @author Henrique Moody * @author Mikhail Vyrtsev */ -class SortedTest extends TestCase +final class SortedTest extends TestCase { /** * @test diff --git a/tests/unit/Rules/SpaceTest.php b/tests/unit/Rules/SpaceTest.php index cbd81270..4a59c6b4 100644 --- a/tests/unit/Rules/SpaceTest.php +++ b/tests/unit/Rules/SpaceTest.php @@ -27,7 +27,7 @@ use Respect\Validation\Test\TestCase; * @author Nick Lombard * @author Pascal Borreli */ -class SpaceTest extends TestCase +final class SpaceTest extends TestCase { /** * @dataProvider providerForValidSpace diff --git a/tests/unit/Rules/StartsWithTest.php b/tests/unit/Rules/StartsWithTest.php index 5d2bfb07..c78aec59 100644 --- a/tests/unit/Rules/StartsWithTest.php +++ b/tests/unit/Rules/StartsWithTest.php @@ -24,7 +24,7 @@ use Respect\Validation\Test\TestCase; * @author Gabriel Caruso * @author Henrique Moody */ -class StartsWithTest extends TestCase +final class StartsWithTest extends TestCase { /** * @dataProvider providerForStartsWith diff --git a/tests/unit/Rules/SubdivisionCodeTest.php b/tests/unit/Rules/SubdivisionCodeTest.php index 4bc6488b..b05a114e 100644 --- a/tests/unit/Rules/SubdivisionCodeTest.php +++ b/tests/unit/Rules/SubdivisionCodeTest.php @@ -22,7 +22,7 @@ use Respect\Validation\Test\TestCase; * @author Gabriel Caruso * @author Henrique Moody */ -class SubdivisionCodeTest extends TestCase +final class SubdivisionCodeTest extends TestCase { /** * @expectedException \Respect\Validation\Exceptions\ComponentException diff --git a/tests/unit/Rules/TypeTest.php b/tests/unit/Rules/TypeTest.php index e544b3a5..c6ace26d 100644 --- a/tests/unit/Rules/TypeTest.php +++ b/tests/unit/Rules/TypeTest.php @@ -25,7 +25,7 @@ use function tmpfile; * @author Henrique Moody * @author Paul Karikari */ -class TypeTest extends RuleTestCase +final class TypeTest extends RuleTestCase { /** * @expectedException \Respect\Validation\Exceptions\ComponentException diff --git a/tests/unit/Rules/VowelTest.php b/tests/unit/Rules/VowelTest.php index 1683bcea..689766a4 100644 --- a/tests/unit/Rules/VowelTest.php +++ b/tests/unit/Rules/VowelTest.php @@ -27,7 +27,7 @@ use Respect\Validation\Test\TestCase; * @author Nick Lombard * @author Pascal Borreli */ -class VowelTest extends TestCase +final class VowelTest extends TestCase { /** * @dataProvider providerForValidVowels diff --git a/tests/unit/Rules/XdigitTest.php b/tests/unit/Rules/XdigitTest.php index 3d10f58b..58af8783 100644 --- a/tests/unit/Rules/XdigitTest.php +++ b/tests/unit/Rules/XdigitTest.php @@ -27,7 +27,7 @@ use Respect\Validation\Test\TestCase; * @author Nick Lombard * @author Pascal Borreli */ -class XdigitTest extends TestCase +final class XdigitTest extends TestCase { /** * @var Xdigit diff --git a/tests/unit/Rules/ZendTest.php b/tests/unit/Rules/ZendTest.php index ec4084a7..9a716a75 100644 --- a/tests/unit/Rules/ZendTest.php +++ b/tests/unit/Rules/ZendTest.php @@ -29,7 +29,7 @@ use Zend\Validator\ValidatorInterface; * @author Henrique Moody * @author Nick Lombard */ -class ZendTest extends TestCase +final class ZendTest extends TestCase { /** * @test diff --git a/tests/unit/ValidatorTest.php b/tests/unit/ValidatorTest.php index cfaf40a5..81deb91c 100644 --- a/tests/unit/ValidatorTest.php +++ b/tests/unit/ValidatorTest.php @@ -24,7 +24,7 @@ use Respect\Validation\Test\TestCase; * @author Henrique Moody * @author Nick Lombard */ -class ValidatorTest extends TestCase +final class ValidatorTest extends TestCase { /** * @test