Update the Coding Standards

This commit will add a couple of rules that we already use but also
introduce new ones and make sure all the code is in accordance with the
new coding standards.

Signed-off-by: Henrique Moody <henriquemoody@gmail.com>

library/Exceptions/NestedValidationException.php

@@ -16,11 +16,13 @@ namespace Respect\Validation\Exceptions;
 use IteratorAggregate;
 use RecursiveIteratorIterator;
 use SplObjectStorage;
+use function array_shift;
 use function count;
 use function current;
 use function implode;
 use function is_array;
 use function spl_object_hash;
+use function sprintf;
 use function str_repeat;
 use const PHP_EOL;
 

library/Exceptions/ValidationException.php

@@ -15,6 +15,9 @@ namespace Respect\Validation\Exceptions;
 
 use InvalidArgumentException;
 use function call_user_func;
+use function is_string;
+use function key;
+use function preg_replace_callback;
 use function Respect\Stringifier\stringify;
 
 /**

library/Factory.php

@@ -23,6 +23,9 @@ use function array_map;
 use function array_merge;
 use function array_unique;
 use function lcfirst;
+use function sprintf;
+use function trim;
+use function ucfirst;
 
 /**
  * Factory of objects.

library/Helpers/CanCompareValues.php

@@ -18,6 +18,7 @@ use DateTimeImmutable;
 use DateTimeInterface;
 use Throwable;
 use function is_numeric;
+use function is_scalar;
 use function is_string;
 use function mb_strlen;
 

library/Helpers/CanValidateDateTime.php

@@ -13,6 +13,10 @@ declare(strict_types=1);
 
 namespace Respect\Validation\Helpers;
 
+use function checkdate;
+use function date_parse_from_format;
+use function preg_match;
+
 /**
  * Helper to handle date/time.
  *

library/Helpers/CanValidateUndefined.php

@@ -13,6 +13,8 @@ declare(strict_types=1);
 
 namespace Respect\Validation\Helpers;
 
+use function in_array;
+
 /**
  * Helper to identify values that Validation consider as "undefined".
  *

library/Rules/AbstractRelated.php

@@ -16,6 +16,7 @@ namespace Respect\Validation\Rules;
 use Respect\Validation\Exceptions\NestedValidationException;
 use Respect\Validation\Exceptions\ValidationException;
 use Respect\Validation\Validatable;
+use function is_null;
 use function is_scalar;
 
 /**

library/Rules/AbstractSearcher.php

@@ -14,6 +14,7 @@ declare(strict_types=1);
 namespace Respect\Validation\Rules;
 
 use Respect\Validation\Helpers\CanValidateUndefined;
+use function in_array;
 
 /**
  * Abstract class for searches into arrays.

library/Rules/AllOf.php

@@ -14,6 +14,7 @@ declare(strict_types=1);
 namespace Respect\Validation\Rules;
 
 use Respect\Validation\Exceptions\AllOfException;
+use function count;
 
 /**
  * @author Alexandre Gomes Gaigalas <alexandre@gaigalas.net>

library/Rules/AnyOf.php

@@ -15,6 +15,7 @@ namespace Respect\Validation\Rules;
 
 use Respect\Validation\Exceptions\AnyOfException;
 use Respect\Validation\Exceptions\ValidationException;
+use function count;
 
 /**
  * @author Alexandre Gomes Gaigalas <alexandre@gaigalas.net>

library/Rules/ArrayType.php

@@ -13,6 +13,8 @@ declare(strict_types=1);
 
 namespace Respect\Validation\Rules;
 
+use function is_array;
+
 /**
  * Validates whether the type of an input is array.
  *

library/Rules/ArrayVal.php

@@ -15,6 +15,7 @@ namespace Respect\Validation\Rules;
 
 use ArrayAccess;
 use SimpleXMLElement;
+use function is_array;
 
 /**
  * Validates if the input is an array or if the input can be used as an array.

library/Rules/Attribute.php

@@ -16,6 +16,8 @@ namespace Respect\Validation\Rules;
 use ReflectionException;
 use ReflectionProperty;
 use Respect\Validation\Validatable;
+use function is_object;
+use function property_exists;
 
 /**
  * Validates an object attribute, event private ones.

library/Rules/Base.php

@@ -16,6 +16,7 @@ namespace Respect\Validation\Rules;
 use Respect\Validation\Exceptions\ComponentException;
 use function is_null;
 use function mb_strlen;
+use function mb_substr;
 use function preg_match;
 use function sprintf;
 
@@ -61,6 +62,6 @@ final class Base extends AbstractRule
     {
         $valid = mb_substr($this->chars, 0, $this->base);
 
-        return (bool) preg_match("@^[$valid]+$@", (string) $input);
+        return (bool) preg_match('@^['.$valid.']+$@', (string) $input);
     }
 }

library/Rules/Cnpj.php

@@ -18,6 +18,7 @@ use function array_sum;
 use function count;
 use function is_scalar;
 use function preg_replace;
+use function str_split;
 
 /**
  * Validates if the input is a Brazilian National Registry of Legal Entities (CNPJ) number.

library/Rules/CountryCode.php

@@ -17,6 +17,7 @@ use Respect\Validation\Exceptions\ComponentException;
 use function array_column;
 use function array_keys;
 use function implode;
+use function sprintf;
 
 /**
  * Validates whether the input is a country code in ISO 3166-1 standard.

library/Rules/Cpf.php

@@ -37,7 +37,7 @@ final class Cpf extends AbstractRule
         // Code ported from jsfromhell.com
         $c = preg_replace('/\D/', '', $input);
 
-        if (mb_strlen($c) != 11 || preg_match("/^{$c[0]}{11}$/", $c)) {
+        if (mb_strlen($c) != 11 || preg_match('/^'.$c[0].'{11}$/', $c)) {
             return false;
         }
 

library/Rules/CreditCard.php

@@ -19,6 +19,7 @@ use function implode;
 use function is_scalar;
 use function preg_match;
 use function preg_replace;
+use function sprintf;
 
 /**
  * Validates whether the input is a credit card number.

library/Rules/Date.php

@@ -15,9 +15,11 @@ namespace Respect\Validation\Rules;
 
 use Respect\Validation\Exceptions\ComponentException;
 use Respect\Validation\Helpers\CanValidateDateTime;
+use function date;
 use function is_scalar;
 use function preg_match;
 use function sprintf;
+use function strtotime;
 
 /**
  * Validates if input is a date.

library/Rules/DateTime.php

@@ -15,6 +15,7 @@ namespace Respect\Validation\Rules;
 
 use DateTimeInterface;
 use Respect\Validation\Helpers\CanValidateDateTime;
+use function date;
 use function is_scalar;
 use function strtotime;
 

library/Rules/Domain.php

@@ -16,6 +16,10 @@ namespace Respect\Validation\Rules;
 use Respect\Validation\Exceptions\DomainException;
 use Respect\Validation\Exceptions\ValidationException;
 use Respect\Validation\Validatable;
+use function array_pop;
+use function count;
+use function explode;
+use function mb_substr_count;
 
 /**
  * @author Alexandre Gomes Gaigalas <alexandre@gaigalas.net>

library/Rules/FilterVar.php

@@ -14,6 +14,7 @@ declare(strict_types=1);
 namespace Respect\Validation\Rules;
 
 use Respect\Validation\Exceptions\ComponentException;
+use function in_array;
 use const FILTER_VALIDATE_BOOLEAN;
 use const FILTER_VALIDATE_EMAIL;
 use const FILTER_VALIDATE_FLOAT;

library/Rules/FloatVal.php

@@ -15,6 +15,7 @@ namespace Respect\Validation\Rules;
 
 use function filter_var;
 use function is_float;
+use const FILTER_VALIDATE_FLOAT;
 
 /**
  * Validate whether the input value is float.

library/Rules/HexRgbColor.php

@@ -13,6 +13,11 @@ declare(strict_types=1);
 
 namespace Respect\Validation\Rules;
 
+use function is_string;
+use function mb_strlen;
+use function mb_strpos;
+use function mb_substr;
+
 /**
  * @author Davide Pastore <pasdavide@gmail.com>
  * @author Henrique Moody <henriquemoody@gmail.com>

library/Rules/Image.php

@@ -18,6 +18,7 @@ use SplFileInfo;
 use function is_file;
 use function is_string;
 use function mb_strpos;
+use const FILEINFO_MIME_TYPE;
 
 /**
  * Validates if the file is a valid image by checking its MIME type.

library/Rules/In.php

@@ -14,6 +14,7 @@ declare(strict_types=1);
 namespace Respect\Validation\Rules;
 
 use function in_array;
+use function is_array;
 use function mb_detect_encoding;
 use function mb_stripos;
 use function mb_strpos;

library/Rules/IntVal.php

@@ -14,7 +14,10 @@ declare(strict_types=1);
 namespace Respect\Validation\Rules;
 
 use function filter_var;
+use function is_bool;
 use function is_float;
+use const FILTER_FLAG_ALLOW_OCTAL;
+use const FILTER_VALIDATE_INT;
 
 /**
  * Validates if the input is an integer.

library/Rules/Ip.php

@@ -26,6 +26,7 @@ use function sprintf;
 use function str_repeat;
 use function str_replace;
 use function strtr;
+use const FILTER_VALIDATE_IP;
 
 /**
  * Validates whether the input is a valid IP address.

library/Rules/Json.php

@@ -16,6 +16,7 @@ namespace Respect\Validation\Rules;
 use function is_string;
 use function json_decode;
 use function json_last_error;
+use const JSON_ERROR_NONE;
 
 /**
  * @author Alexandre Gomes Gaigalas <alexandre@gaigalas.net>

library/Rules/Key.php

@@ -15,6 +15,9 @@ namespace Respect\Validation\Rules;
 
 use Respect\Validation\Exceptions\ComponentException;
 use Respect\Validation\Validatable;
+use function array_key_exists;
+use function is_array;
+use function is_scalar;
 
 /**
  * @author Alexandre Gomes Gaigalas <alexandre@gaigalas.net>

library/Rules/KeyNested.php

@@ -15,6 +15,16 @@ namespace Respect\Validation\Rules;
 
 use ArrayAccess;
 use Respect\Validation\Exceptions\ComponentException;
+use function array_key_exists;
+use function array_shift;
+use function explode;
+use function is_array;
+use function is_null;
+use function is_object;
+use function is_scalar;
+use function property_exists;
+use function rtrim;
+use function sprintf;
 
 /**
  * @author Alexandre Gomes Gaigalas <alexandre@gaigalas.net>

library/Rules/KeyValue.php

@@ -18,6 +18,7 @@ use Respect\Validation\Exceptions\ValidationException;
 use Respect\Validation\Validatable;
 use Respect\Validation\Validator;
 use function array_keys;
+use function in_array;
 
 /**
  * @author Henrique Moody <henriquemoody@gmail.com>

library/Rules/LanguageCode.php

@@ -17,6 +17,7 @@ use Respect\Validation\Exceptions\ComponentException;
 use function array_column;
 use function array_filter;
 use function array_search;
+use function sprintf;
 
 /**
  * Validates whether the input is language code based on ISO 639.

library/Rules/Length.php

@@ -16,12 +16,14 @@ namespace Respect\Validation\Rules;
 use Countable as CountableInterface;
 use Respect\Validation\Exceptions\ComponentException;
 use function count;
+use function get_object_vars;
 use function is_array;
 use function is_int;
 use function is_object;
 use function is_string;
 use function mb_detect_encoding;
 use function mb_strlen;
+use function sprintf;
 
 /**
  * Validates the length of the given input.

library/Rules/Locale/PlIdentityCard.php

@@ -14,6 +14,8 @@ declare(strict_types=1);
 namespace Respect\Validation\Rules\Locale;
 
 use Respect\Validation\Rules\AbstractRule;
+use function ord;
+use function preg_match;
 
 /**
  * Validator for Polish identity card.

library/Rules/Locale/PlVatin.php

@@ -15,6 +15,8 @@ namespace Respect\Validation\Rules\Locale;
 
 use Respect\Validation\Rules\AbstractRule;
 use function array_map;
+use function is_scalar;
+use function preg_match;
 use function str_split;
 
 /**

library/Rules/Nif.php

@@ -13,6 +13,14 @@ declare(strict_types=1);
 
 namespace Respect\Validation\Rules;
 
+use function array_pop;
+use function array_sum;
+use function is_numeric;
+use function is_string;
+use function mb_substr;
+use function preg_match;
+use function str_split;
+
 /**
  * Validates Spain's fiscal identification number (NIF).
  *

library/Rules/No.php

@@ -13,6 +13,10 @@ declare(strict_types=1);
 
 namespace Respect\Validation\Rules;
 
+use function defined;
+use function nl_langinfo;
+use const NOEXPR;
+
 /**
  * @author Henrique Moody <henriquemoody@gmail.com>
  */

library/Rules/NoneOf.php

@@ -14,6 +14,7 @@ declare(strict_types=1);
 namespace Respect\Validation\Rules;
 
 use Respect\Validation\Exceptions\NoneOfException;
+use function count;
 
 /**
  * @author Alexandre Gomes Gaigalas <alexandre@gaigalas.net>

library/Rules/Not.php

@@ -15,6 +15,7 @@ namespace Respect\Validation\Rules;
 
 use Respect\Validation\Exceptions\ValidationException;
 use Respect\Validation\Validatable;
+use function array_shift;
 
 /**
  * @author Alexandre Gomes Gaigalas <alexandre@gaigalas.net>

library/Rules/NotEmpty.php

@@ -13,6 +13,9 @@ declare(strict_types=1);
 
 namespace Respect\Validation\Rules;
 
+use function is_string;
+use function trim;
+
 /**
  * Validates whether the input is not empty
  *

library/Rules/Odd.php

@@ -15,6 +15,7 @@ namespace Respect\Validation\Rules;
 
 use function filter_var;
 use function is_numeric;
+use const FILTER_VALIDATE_INT;
 
 /**
  * Validates whether the input is an odd number or not.

library/Rules/OneOf.php

@@ -15,6 +15,8 @@ namespace Respect\Validation\Rules;
 
 use Respect\Validation\Exceptions\OneOfException;
 use Respect\Validation\Exceptions\ValidationException;
+use function array_shift;
+use function count;
 
 /**
  * @author Bradyn Poulsen <bradyn@bradynpoulsen.com>

library/Rules/Pis.php

@@ -37,7 +37,7 @@ final class Pis extends AbstractRule
         }
 
         $digits = preg_replace('/\D/', '', $input);
-        if (mb_strlen($digits) != 11 || preg_match("/^{$digits[0]}{11}$/", $digits)) {
+        if (mb_strlen($digits) != 11 || preg_match('/^'.$digits[0].'{11}$/', $digits)) {
             return false;
         }
 

library/Rules/PostalCode.php

@@ -14,6 +14,7 @@ declare(strict_types=1);
 namespace Respect\Validation\Rules;
 
 use Respect\Validation\Exceptions\ComponentException;
+use function sprintf;
 
 /**
  * Validates whether the input is a valid postal code or not.

library/Rules/Printable.php

@@ -13,6 +13,8 @@ declare(strict_types=1);
 
 namespace Respect\Validation\Rules;
 
+use function ctype_print;
+
 /**
  * Validates whether an input is printable character(s).
  *

library/Rules/Sf.php

@@ -19,6 +19,7 @@ use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\ConstraintViolationList;
 use Symfony\Component\Validator\Validation;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
+use function trim;
 
 /**
  * Validate the input with a Symfony Validator (>=4.0 or >=3.0) Constraint.

library/Rules/Size.php

@@ -15,6 +15,11 @@ namespace Respect\Validation\Rules;
 
 use Respect\Validation\Exceptions\ComponentException;
 use SplFileInfo;
+use function filesize;
+use function is_numeric;
+use function is_string;
+use function preg_match;
+use function sprintf;
 
 /**
  * Validate file size.
@@ -65,7 +70,7 @@ class Size extends AbstractRule
         $value = $size;
         $units = ['b', 'kb', 'mb', 'gb', 'tb', 'pb', 'eb', 'zb', 'yb'];
         foreach ($units as $exponent => $unit) {
-            if (!preg_match("/^(\d+(.\d+)?){$unit}$/i", (string) $size, $matches)) {
+            if (!preg_match('/^(\d+(.\d+)?)'.$unit.'$/i', (string) $size, $matches)) {
                 continue;
             }
             $value = $matches[1] * 1024 ** $exponent;

library/Rules/Sorted.php

@@ -13,6 +13,8 @@ declare(strict_types=1);
 
 namespace Respect\Validation\Rules;
 
+use function count;
+
 /**
  * @author Henrique Moody <henriquemoody@gmail.com>
  * @author Mikhail Vyrtsev <reeywhaar@gmail.com>

library/Rules/Space.php

@@ -13,6 +13,8 @@ declare(strict_types=1);
 
 namespace Respect\Validation\Rules;
 
+use function ctype_space;
+
 /**
  * @author Andre Ramaciotti <andre@ramaciotti.com>
  * @author Henrique Moody <henriquemoody@gmail.com>

library/Rules/StartsWith.php

@@ -13,6 +13,12 @@ declare(strict_types=1);
 
 namespace Respect\Validation\Rules;
 
+use function is_array;
+use function mb_detect_encoding;
+use function mb_stripos;
+use function mb_strpos;
+use function reset;
+
 /**
  * @author Alexandre Gomes Gaigalas <alexandre@gaigalas.net>
  * @author Henrique Moody <henriquemoody@gmail.com>

library/Rules/Time.php

@@ -15,9 +15,11 @@ namespace Respect\Validation\Rules;
 
 use Respect\Validation\Exceptions\ComponentException;
 use Respect\Validation\Helpers\CanValidateDateTime;
+use function date;
 use function is_scalar;
 use function preg_match;
 use function sprintf;
+use function strtotime;
 
 /**
  * Validates whether an input is a time or not

library/Rules/Xdigit.php

@@ -13,6 +13,8 @@ declare(strict_types=1);
 
 namespace Respect\Validation\Rules;
 
+use function ctype_xdigit;
+
 /**
  * @author Andre Ramaciotti <andre@ramaciotti.com>
  * @author Henrique Moody <henriquemoody@gmail.com>

library/Rules/Zend.php

@@ -17,6 +17,9 @@ use ReflectionClass;
 use Respect\Validation\Exceptions\ComponentException;
 use Respect\Validation\Exceptions\ZendException;
 use Zend\Validator\ValidatorInterface as ZendValidator;
+use function get_object_vars;
+use function is_string;
+use function mb_stripos;
 
 /**
  * @author Alexandre Gomes Gaigalas <alexandre@gaigalas.net>
@@ -59,7 +62,7 @@ class Zend extends AbstractRule
      */
     private function createZendValidator(string $name, array $params): ZendValidator
     {
-        $name = mb_stripos($name, 'Zend') === false ? "Zend\\Validator\\{$name}" : "\\{$name}";
+        $name = mb_stripos($name, 'Zend') === false ? 'Zend\\Validator\\'.$name : '\\'.$name;
 
         $reflection = new ReflectionClass($name);
 

library/Validator.php

@@ -20,6 +20,7 @@ use Respect\Validation\Rules\AllOf;
 use Respect\Validation\Rules\Key;
 use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
+use function count;
 
 /**
  * @method static Validator allOf(Validatable ...$rule)

phpcs.xml.dist

@@ -31,6 +31,7 @@
         </properties>
     </rule>
     <rule ref="Generic.WhiteSpace.ArbitraryParenthesesSpacing" />
+    <rule ref="Generic.WhiteSpace.IncrementDecrementSpacing" />
     <rule ref="PEAR.WhiteSpace.ObjectOperatorIndent" />
     <rule ref="SlevomatCodingStandard.Arrays.DisallowImplicitArrayCreation" />
     <rule ref="SlevomatCodingStandard.Arrays.TrailingArrayComma" />
@@ -73,7 +74,15 @@
     <rule ref="SlevomatCodingStandard.Namespaces.NamespaceSpacing" />
     <rule ref="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly">
         <properties>
-            <property name="searchAnnotations" value="true" />
+            <property name="allowFallbackGlobalConstants" value="false"/>
+            <property name="allowFallbackGlobalFunctions" value="false"/>
+            <property name="allowFullyQualifiedGlobalClasses" value="false"/>
+            <property name="allowFullyQualifiedGlobalConstants" value="false"/>
+            <property name="allowFullyQualifiedGlobalFunctions" value="false"/>
+            <property name="allowFullyQualifiedNameForCollidingClasses" value="true"/>
+            <property name="allowFullyQualifiedNameForCollidingConstants" value="true"/>
+            <property name="allowFullyQualifiedNameForCollidingFunctions" value="true"/>
+            <property name="searchAnnotations" value="true"/>
         </properties>
     </rule>
     <rule ref="SlevomatCodingStandard.Namespaces.RequireOneNamespaceInFile" />
@@ -124,11 +133,31 @@
             <property name="ignoreNewlines" value="true" />
         </properties>
     </rule>
+    <rule ref="Squiz.Strings.DoubleQuoteUsage"/>
+    <rule ref="Squiz.Strings.DoubleQuoteUsage.ContainsVar">
+        <message>Variable "%s" not allowed in double quoted string; use sprintf() or concatenation instead</message>
+    </rule>
     <rule ref="Squiz.WhiteSpace.MemberVarSpacing">
         <properties>
             <property name="spacing" value="1" />
             <property name="spacingBeforeFirst" value="0" />
         </properties>
     </rule>
+    <rule ref="Squiz.WhiteSpace.LanguageConstructSpacing" />
+    <rule ref="Squiz.WhiteSpace.LogicalOperatorSpacing" />
+    <rule ref="Squiz.WhiteSpace.ObjectOperatorSpacing">
+        <properties>
+            <property name="ignoreNewlines" value="true" />
+        </properties>
+    </rule>
     <rule ref="Squiz.WhiteSpace.OperatorSpacing" />
+    <rule ref="Squiz.WhiteSpace.SemicolonSpacing" />
+    <rule ref="Squiz.WhiteSpace.SuperfluousWhitespace">
+        <properties>
+            <property name="ignoreBlankLines" value="false" />
+        </properties>
+    </rule>
+    <rule ref="Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines">
+        <severity>5</severity>
+    </rule>
 </ruleset>

tests/integration/rules/graph.phpt

@@ -24,7 +24,7 @@ try {
 }
 
 try {
-    v::not(v::graph())->check("foobar");
+    v::not(v::graph())->check('foobar');
 } catch (GraphException $exception) {
     echo $exception->getMessage().PHP_EOL;
 }
@@ -48,7 +48,7 @@ try {
 }
 
 try {
-    v::not(v::graph())->assert("foobar");
+    v::not(v::graph())->assert('foobar');
 } catch (NestedValidationException $exception) {
     echo $exception->getFullMessage().PHP_EOL;
 }

tests/unit/Exceptions/CheckExceptionsTest.php

@@ -16,6 +16,9 @@ namespace Respect\Validation\Exceptions;
 use DirectoryIterator;
 use ReflectionClass;
 use Respect\Validation\Test\TestCase;
+use function class_exists;
+use function mb_substr;
+use function sprintf;
 
 /**
  * @coversNothing

tests/unit/Exceptions/ValidationExceptionTest.php

@@ -14,6 +14,7 @@ declare(strict_types=1);
 namespace Respect\Validation\Exceptions;
 
 use Respect\Validation\Test\TestCase;
+use function trim;
 
 /**
  * @group core

tests/unit/Rules/Base64Test.php

@@ -14,6 +14,7 @@ declare(strict_types=1);
 namespace Respect\Validation\Rules;
 
 use Respect\Validation\Test\RuleTestCase;
+use function implode;
 
 /**
  * @group rule

tests/unit/Rules/CountableTest.php

@@ -17,6 +17,7 @@ use ArrayIterator;
 use ArrayObject;
 use Respect\Validation\Test\RuleTestCase;
 use stdClass;
+use const PHP_INT_MAX;
 
 /**
  * @group rule

tests/unit/Rules/DirectoryTest.php

@@ -17,6 +17,7 @@ use Respect\Validation\Test\RuleTestCase;
 use SplFileInfo;
 use SplFileObject;
 use stdClass;
+use function dir;
 
 /**
  * @group rule

tests/unit/Rules/DomainTest.php

@@ -15,6 +15,8 @@ namespace Respect\Validation\Rules;
 
 use Respect\Validation\Test\TestCase;
 use Respect\Validation\Validator as v;
+use function sprintf;
+use function var_export;
 
 /**
  * @group  rule

tests/unit/Rules/EvenTest.php

@@ -14,6 +14,7 @@ declare(strict_types=1);
 namespace Respect\Validation\Rules;
 
 use Respect\Validation\Test\RuleTestCase;
+use const INF;
 
 /**
  * @group rule

tests/unit/Rules/FactorTest.php

@@ -19,6 +19,7 @@ use stdClass;
 use function mt_getrandmax;
 use function mt_rand;
 use function uniqid;
+use const PHP_INT_MAX;
 
 /**
  * @group rule

tests/unit/Rules/FalseValTest.php

@@ -15,6 +15,7 @@ namespace Respect\Validation\Rules;
 
 use Respect\Validation\Test\RuleTestCase;
 use stdClass;
+use function random_int;
 use const PHP_INT_MAX;
 
 /**

tests/unit/Rules/FilterVarTest.php

@@ -15,6 +15,7 @@ namespace Respect\Validation\Rules;
 
 use Respect\Validation\Test\RuleTestCase;
 use const FILTER_FLAG_QUERY_REQUIRED;
+use const FILTER_SANITIZE_EMAIL;
 use const FILTER_VALIDATE_BOOLEAN;
 use const FILTER_VALIDATE_EMAIL;
 use const FILTER_VALIDATE_FLOAT;

tests/unit/Rules/FloatTypeTest.php

@@ -14,6 +14,7 @@ declare(strict_types=1);
 namespace Respect\Validation\Rules;
 
 use Respect\Validation\Test\RuleTestCase;
+use const PHP_INT_MAX;
 
 /**
  * @group rule

tests/unit/Rules/GraphTest.php

@@ -35,7 +35,7 @@ final class GraphTest extends RuleTestCase
     public function providerForValidInput(): array
     {
         $graph = new Graph();
-        
+
         return [
             'String with special characters "LKA#@%.54"' => [$graph, 'LKA#@%.54'],
             'String "foobar"' => [$graph, 'foobar'],
@@ -44,8 +44,8 @@ final class GraphTest extends RuleTestCase
             'String with special characters "#$%&*_"' => [$graph, '#$%&*_'],
             'Ignoring control characters "\n"' => [new Graph("\n"), "#$%&*_\n~"],
             'Ignoring control characters "\n#\t&\r"' => [new Graph("\n#\t&\r"), "#$%&*_\n~\t**\r"],
-            'Ignoring character "_"' => [new Graph("_"), "abc\#$%&*_"],
-            'Ignoring characters "# $"' => [new Graph("# $"), "#$%&*_"],
+            'Ignoring character "_"' => [new Graph('_'), 'abc\#$%&*_'],
+            'Ignoring characters "# $"' => [new Graph('# $'), '#$%&*_'],
             'Ignoring character with space' => [new Graph(' '), '!@#$%^&*(){} abc 123'],
             'Ignoring control characters " \t\n"' => [new Graph(" \t\n"), "[]?+=/\\-_|\"',<>. \t \n abc 123"],
         ];

tests/unit/Rules/IntTypeTest.php

@@ -14,6 +14,7 @@ declare(strict_types=1);
 namespace Respect\Validation\Rules;
 
 use Respect\Validation\Test\RuleTestCase;
+use const PHP_INT_MAX;
 
 /**
  * @group rule

tests/unit/Rules/IntValTest.php

@@ -14,6 +14,7 @@ declare(strict_types=1);
 namespace Respect\Validation\Rules;
 
 use Respect\Validation\Test\RuleTestCase;
+use const PHP_INT_MAX;
 
 /**
  * @group rule

tests/unit/Rules/IpTest.php

@@ -15,6 +15,8 @@ namespace Respect\Validation\Rules;
 
 use Respect\Validation\Exceptions\ComponentException;
 use Respect\Validation\Test\RuleTestCase;
+use const FILTER_FLAG_IPV6;
+use const FILTER_FLAG_NO_PRIV_RANGE;
 
 /**
  * @group rule

tests/unit/Rules/NifTest.php

@@ -15,6 +15,7 @@ namespace Respect\Validation\Rules;
 
 use Respect\Validation\Test\RuleTestCase;
 use stdClass;
+use function stream_context_create;
 
 /**
  * @group  rule

tests/unit/Rules/PrintableTest.php

@@ -14,6 +14,7 @@ declare(strict_types=1);
 namespace Respect\Validation\Rules;
 
 use Respect\Validation\Test\RuleTestCase;
+use function chr;
 
 /**
  * @group rule

tests/unit/Rules/ScalarValTest.php

@@ -15,6 +15,7 @@ namespace Respect\Validation\Rules;
 
 use Respect\Validation\Test\RuleTestCase;
 use stdClass;
+use function tmpfile;
 
 /**
  * @group rule

tests/unit/Rules/SfTest.php

@@ -20,6 +20,7 @@ use Symfony\Component\Validator\Constraints\IsNull;
 use Symfony\Component\Validator\Validation;
 use Symfony\Component\Validator\Validator\TraceableValidator;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
+use function class_exists;
 
 /**
  * @group rule

tests/unit/Rules/UploadedTest.php

@@ -17,6 +17,8 @@ use PHPUnit\Framework\SkippedTestError;
 use Respect\Validation\Test\RuleTestCase;
 use SplFileInfo;
 use stdClass;
+use function extension_loaded;
+use function uopz_set_return;
 
 /**
  * @group rule

tests/unit/Rules/WritableTest.php

@@ -17,6 +17,7 @@ use Respect\Validation\Test\RuleTestCase;
 use SplFileInfo;
 use SplFileObject;
 use stdClass;
+use function chmod;
 
 /**
  * @group rule