mirror of
https://github.com/Respect/Validation.git
synced 2026-03-16 23:35:45 +01:00
Enable adding modifiers without changing InterpolationRenderer
The `InterpolationRenderer` was violating the open-closed principle, because every time we would want to add a new modifier, we would need to change its implementation. This commit changes that behaviour by creating a `Modifier` interface. The classes implementing that interface are using a chain of responsibility to pass the data to the next one. Using a chain of responsibility makes a lot of sense, since it's only possible to have one modifier at a time.
This commit is contained in:
parent
562d98d805
commit
cd6bcd470b
18 changed files with 825 additions and 131 deletions
117
tests/unit/Message/Modifier/RawModifierTest.php
Normal file
117
tests/unit/Message/Modifier/RawModifierTest.php
Normal file
|
|
@ -0,0 +1,117 @@
|
|||
<?php
|
||||
|
||||
/*
|
||||
* Copyright (c) Alexandre Gomes Gaigalas <alganet@gmail.com>
|
||||
* SPDX-License-Identifier: MIT
|
||||
*/
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
namespace Respect\Validation\Message\Modifier;
|
||||
|
||||
use PHPUnit\Framework\Attributes\CoversClass;
|
||||
use PHPUnit\Framework\Attributes\Test;
|
||||
use Respect\Validation\Test\Message\TestingModifier;
|
||||
use Respect\Validation\Test\TestCase;
|
||||
|
||||
#[CoversClass(RawModifier::class)]
|
||||
final class RawModifierTest extends TestCase
|
||||
{
|
||||
#[Test]
|
||||
public function itShouldNotModifyWhenModifierIsNotRaw(): void
|
||||
{
|
||||
$nextModifier = new TestingModifier();
|
||||
$modifier = new RawModifier($nextModifier);
|
||||
|
||||
$value = 'some value';
|
||||
$pipe = 'notRaw';
|
||||
|
||||
$result = $modifier->modify($value, $pipe);
|
||||
|
||||
self::assertSame($nextModifier->modify($value, $pipe), $result);
|
||||
}
|
||||
|
||||
#[Test]
|
||||
public function itShouldNotModifyWhenValueIsNotScalar(): void
|
||||
{
|
||||
$nextModifier = new TestingModifier();
|
||||
$modifier = new RawModifier($nextModifier);
|
||||
|
||||
$value = ['not', 'scalar'];
|
||||
$pipe = 'raw';
|
||||
|
||||
$result = $modifier->modify($value, $pipe);
|
||||
|
||||
self::assertSame($nextModifier->modify($value, null), $result);
|
||||
}
|
||||
|
||||
#[Test]
|
||||
public function itShouldModifyWhenModifierIsRawAndValueIsScalarString(): void
|
||||
{
|
||||
$nextModifier = new TestingModifier();
|
||||
$modifier = new RawModifier($nextModifier);
|
||||
|
||||
$value = 'some string';
|
||||
$pipe = 'raw';
|
||||
|
||||
$result = $modifier->modify($value, $pipe);
|
||||
|
||||
self::assertSame($value, $result);
|
||||
}
|
||||
|
||||
#[Test]
|
||||
public function itShouldModifyWhenModifierIsRawAndValueIsScalarInt(): void
|
||||
{
|
||||
$nextModifier = new TestingModifier();
|
||||
$modifier = new RawModifier($nextModifier);
|
||||
|
||||
$value = 123;
|
||||
$pipe = 'raw';
|
||||
|
||||
$result = $modifier->modify($value, $pipe);
|
||||
|
||||
self::assertSame('123', $result);
|
||||
}
|
||||
|
||||
#[Test]
|
||||
public function itShouldModifyWhenModifierIsRawAndValueIsScalarFloat(): void
|
||||
{
|
||||
$nextModifier = new TestingModifier();
|
||||
$modifier = new RawModifier($nextModifier);
|
||||
|
||||
$value = 123.456;
|
||||
$pipe = 'raw';
|
||||
|
||||
$result = $modifier->modify($value, $pipe);
|
||||
|
||||
self::assertSame('123.456', $result);
|
||||
}
|
||||
|
||||
#[Test]
|
||||
public function itShouldModifyWhenModifierIsRawAndValueIsScalarBoolTrue(): void
|
||||
{
|
||||
$nextModifier = new TestingModifier();
|
||||
$modifier = new RawModifier($nextModifier);
|
||||
|
||||
$value = true;
|
||||
$pipe = 'raw';
|
||||
|
||||
$result = $modifier->modify($value, $pipe);
|
||||
|
||||
self::assertSame('1', $result);
|
||||
}
|
||||
|
||||
#[Test]
|
||||
public function itShouldModifyWhenModifierIsRawAndValueIsScalarBoolFalse(): void
|
||||
{
|
||||
$nextModifier = new TestingModifier();
|
||||
$modifier = new RawModifier($nextModifier);
|
||||
|
||||
$value = false;
|
||||
$pipe = 'raw';
|
||||
|
||||
$result = $modifier->modify($value, $pipe);
|
||||
|
||||
self::assertSame('0', $result);
|
||||
}
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue